To override or not to override?

2016-01-15 Thread Jakub Wilk 

* Gianfranco Costamagna <locutusofb...@debian.org>, 2016-01-15, 15:55:

lintian is wrong in this case, so there is no need to override it.


Um, no; on the contrary, Lintian being wrong is the only legitimate 
reason to add an override.


Here's how one should deal with Lintian tags:

if my package is buggy:
if I'm being lazy:
leave the tag un-overridden,
(so that it serves as a reminder
for the future less-lazy me)
else:
fix the package
else:
    add override
if Lintian could be fixed easily:
file a bug against Lintian
while Lintian is still buggy:
wait patiently
remove override

--
Jakub Wilk

Re: To override or not to override?

2016-01-15 Thread Paul Tagliamonte 
On Fri, Jan 15, 2016 at 04:29:07PM +0100, Jakub Wilk wrote:
> * Gianfranco Costamagna <locutusofb...@debian.org>, 2016-01-15, 15:55:
> >lintian is wrong in this case, so there is no need to override it.
> 
> Um, no; on the contrary, Lintian being wrong is the only legitimate reason
> to add an override.
> 
> Here's how one should deal with Lintian tags:

Here's my flow:

if my package is buggy:
if i'm lazy:
leave it alone
else:
fix the package

elif lintian is buggy:
if the warning is autoreject:
override
file a bug report

else:
# lintian has a sane check, but it's triggered for a false
# positive, but it had no way of knowing that
override


I don't like having overrides sit around, and having them sit around
while the version of lintian that's being used is no longer triggering
makes me feel unfomfortable

   Paul


signature.asc
Description: PGP signature

Re: To override or not to override?

2016-01-15 Thread Russ Allbery 
Paul Tagliamonte <paul...@debian.org> writes:

> I don't like having overrides sit around, and having them sit around
> while the version of lintian that's being used is no longer triggering
> makes me feel unfomfortable

This is why Lintian will warn you about unused overrides so that you can
remove them.  That should make it safer to add an override for a Lintian
bug, since when the bug is fixed, Lintian will tell you that you can
remove it.

-- 
Russ Allbery (r...@debian.org)   <http://www.eyrie.org/~eagle/>