Re: cc1plus: error: -Wformat-security ignored without -Wformat (Re: CMake help needed to enable hdf5 for gatb-core)

2017-12-10 Thread Andreas Tille
On Sun, Dec 10, 2017 at 12:59:30PM +0100, Gert Wollny wrote:
> In summary, Debian flags set -Wformat and -Werror=format-security, but
> the package also sets -Wno-format which overrides the former and
> results in the error message. 
> 
> Pushed another patch.

Cool.  Thanks a lot!

> Now it seems it still wants to install  (non
> existing) HDF5 files. 

I guess this is a relict of the local copy of hdf5 files and it
just needs fixing the install target.  Hmmm, may be I'll manage
tomorrow (if nobody beats me before ;-) ).

Thanks a lot for your help

  Andreas.

-- 
http://fam-tille.de



Re: [Debian-med-packaging] cc1plus: error: -Wformat-security ignored without -Wformat (Re: CMake help needed to enable hdf5 for gatb-core)

2017-12-10 Thread Gert Wollny
Am Sonntag, den 10.12.2017, 11:54 +0100 schrieb Gert Wollny:
> Am Sonntag, den 10.12.2017, 11:44 +0100 schrieb Gert Wollny:
> > Am Sonntag, den 10.12.2017, 08:13 +0100 schrieb Andreas Tille:
> > > Hi again,
> > > 
> > > On Mon, Dec 04, 2017 at 05:59:28PM +0100, Andreas Tille wrote:
> > > > some problems with gatb[1].  With the new upstream version, I
> > > > get:
> > > > 
> > > > cc1plus: error: -Wformat-security ignored without -Wformat [-
> > > > Werror=format-security]
> > > > cc1plus: error: -Wformat-security ignored without -Wformat [-
> > > > Werror=format-security]
> > > 
> > > I received another (unrelated) patch by Gert Wollny who told me
> > > that
> > > he can not reproduce the issue above.  I refreshed by cowbuilder
> > > chroot but the issue remains:
> > 
> > Actually, now that I tried to compile it in a i386 changeroot I
> > also
> > saw it (before I was compiling on amd64). I'll investigate ... 
> 
> Now I understand: My changeroot is sid, but the host machine runs on
> testing, so I didn't get the latest compiler version. The culprit now
> is that with g+++ 7.2.0 one can give -Werror=format-security without
> setting also -Wformat, as of g++ 7.2.1 this is now an error, and one
> needs both, -Wformat and -Werror=format-security, hence the error.  
In summary, Debian flags set -Wformat and -Werror=format-security, but
the package also sets -Wno-format which overrides the former and
results in the error message. 

Pushed another patch. Now it seems it still wants to install  (non
existing) HDF5 files. 

best, 
Gert 



Re: [Debian-med-packaging] cc1plus: error: -Wformat-security ignored without -Wformat (Re: CMake help needed to enable hdf5 for gatb-core)

2017-12-10 Thread Gert Wollny
Am Sonntag, den 10.12.2017, 11:44 +0100 schrieb Gert Wollny:
> Am Sonntag, den 10.12.2017, 08:13 +0100 schrieb Andreas Tille:
> > Hi again,
> > 
> > On Mon, Dec 04, 2017 at 05:59:28PM +0100, Andreas Tille wrote:
> > > some problems with gatb[1].  With the new upstream version, I
> > > get:
> > > 
> > > cc1plus: error: -Wformat-security ignored without -Wformat [-
> > > Werror=format-security]
> > > cc1plus: error: -Wformat-security ignored without -Wformat [-
> > > Werror=format-security]
> > 
> > I received another (unrelated) patch by Gert Wollny who told me
> > that
> > he can not reproduce the issue above.  I refreshed by cowbuilder
> > chroot but the issue remains:
> 
> Actually, now that I tried to compile it in a i386 changeroot I also
> saw it (before I was compiling on amd64). I'll investigate ... 

Now I understand: My changeroot is sid, but the host machine runs on
testing, so I didn't get the latest compiler version. The culprit now
is that with g+++ 7.2.0 one can give -Werror=format-security without
setting also -Wformat, as of g++ 7.2.1 this is now an error, and one
needs both, -Wformat and -Werror=format-security, hence the error.  

Best, 
Gert 
 



Re: [Debian-med-packaging] cc1plus: error: -Wformat-security ignored without -Wformat (Re: CMake help needed to enable hdf5 for gatb-core)

2017-12-10 Thread Gert Wollny
Am Sonntag, den 10.12.2017, 08:13 +0100 schrieb Andreas Tille:
> Hi again,
> 
> On Mon, Dec 04, 2017 at 05:59:28PM +0100, Andreas Tille wrote:
> > some problems with gatb[1].  With the new upstream version, I get:
> > 
> > cc1plus: error: -Wformat-security ignored without -Wformat [-
> > Werror=format-security]
> > cc1plus: error: -Wformat-security ignored without -Wformat [-
> > Werror=format-security]
> 
> I received another (unrelated) patch by Gert Wollny who told me that
> he can not reproduce the issue above.  I refreshed by cowbuilder
> chroot but the issue remains:

Actually, now that I tried to compile it in a i386 changeroot I also
saw it (before I was compiling on amd64). I'll investigate ... 



cc1plus: error: -Wformat-security ignored without -Wformat (Re: CMake help needed to enable hdf5 for gatb-core)

2017-12-09 Thread Andreas Tille
Hi again,

On Mon, Dec 04, 2017 at 05:59:28PM +0100, Andreas Tille wrote:
> some problems with gatb[1].  With the new upstream version, I get:
> 
> cc1plus: error: -Wformat-security ignored without -Wformat 
> [-Werror=format-security]
> cc1plus: error: -Wformat-security ignored without -Wformat 
> [-Werror=format-security]

I received another (unrelated) patch by Gert Wollny who told me that he
can not reproduce the issue above.  I refreshed by cowbuilder chroot but
the issue remains:


...
cd /build/gatb-core-1.4.0+dfsg/obj-x86_64-linux-gnu/src && /usr/bin/c++   
-I/usr/include/hdf5/serial 
-I/build/gatb-core-1.4.0+dfsg/obj-x86_64-linux-gnu/include 
-I/build/gatb-core-1.4.0+dfsg/obj-x86_64-linux-gnu/include/None 
-I/build/gatb-core-1.4.0+dfsg/gatb-core/src 
-I/build/gatb-core-1.4.0+dfsg/gatb-core/thirdparty  -g -O2 
-fdebug-prefix-map=/build/gatb-core-1.4.0+dfsg=. -fstack-protector-strong 
-Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -msse2 
-msse4.2 -mpopcnt   -std=c++11 -O3 -DNDEBUG -Wall -Wno-unused-function 
-Wno-format -Wno-unknown-pragmas -Wno-invalid-offsetof -o 
CMakeFiles/gatbcore-static.dir/gatb/bank/impl/Bank.cpp.o -c 
/build/gatb-core-1.4.0+dfsg/gatb-core/src/gatb/bank/impl/Bank.cpp
cc1plus: error: -Wformat-security ignored without -Wformat 
[-Werror=format-security]
cc1plus: error: -Wformat-security ignored without -Wformat 
[-Werror=format-security]
cc1plus: error: -Wformat-security ignored without -Wformat 
[-Werror=format-security]
cc1plus: error: -Wformat-security ignored without -Wformat 
[-Werror=format-security]
/build/gatb-core-1.4.0+dfsg/gatb-core/src/gatb/bank/impl/BankBinary.cpp: In 
function 'bool gatb::core::bank::impl::checkMagic(FILE*)':
/build/gatb-core-1.4.0+dfsg/gatb-core/src/gatb/bank/impl/BankBinary.cpp:54:11: 
warning: ignoring return value of 'size_t fread(void*, size_t, size_t, FILE*)', 
declared with attribute warn_unused_result [-Wunused-result]
 fread (, sizeof(value), 1, file);
 ~~^~~~
/build/gatb-core-1.4.0+dfsg/gatb-core/src/gatb/bank/impl/BankBinary.cpp: In 
member function 'virtual void 
gatb::core::bank::impl::BankBinary::Iterator::next()':
/build/gatb-core-1.4.0+dfsg/gatb-core/src/gatb/bank/impl/BankBinary.cpp:453:15: 
warning: ignoring return value of 'size_t fread(void*, size_t, size_t, FILE*)', 
declared with attribute warn_unused_result [-Wunused-result]
 fread (_bufferData->getBuffer(), sizeof( char),block_size, 
binary_read_file); // read a block of reads into the buffer
 
~~^~
cc1plus: some warnings being treated as errors
src/CMakeFiles/gatbcore-static.dir/build.make:113: recipe for target 
'src/CMakeFiles/gatbcore-static.dir/gatb/bank/impl/BankBinary.cpp.o' failed
make[3]: *** 
[src/CMakeFiles/gatbcore-static.dir/gatb/bank/impl/BankBinary.cpp.o] Error 1


Does this (obviously not always reproducible) problem ring a bell?

Kind regards

   Andreas.
 
> [1] https://anonscm.debian.org/git/debian-med/gatb-core.git

-- 
http://fam-tille.de