Bug#829520: RFS: mbpfan/1.9.1-1 ITP

[Sean Whitton]

Dear Herminio,

On Sun, Sep 18, 2016 at 01:13:48AM -0700, Herminio Hernandez Jr wrote:
> On 08/31, Herminio Hernandez, Jr. wrote:
> I am trying to convert my package using git. I am running into the lintian 
> error
> 
> gbp:error: Can't determine upstream version from changelog

Are you running gbp from the root of your source package?

> I am trying to convert my package using git. I am running into the lintian 
> error
> 
> W: mbpfan source: source-nmu-has-incorrect-version-number 1.9.1-1
> 
> Based on what I read here: 
> https://lintian.debian.org/tags/source-nmu-has-incorrect-version-number.html 
> I tried to change the version to -0.1 in the changelog. Now I am getting this 
> error
> 
> gbp:error: upstream/0 is not a valid treeish

This probably means that the Maintainer: field does not match your
DEBEMAIL and DEBFULLNAME environment variables.

-- 
Sean Whitton


signature.asc
Description: PGP signature

Bug#829520: RFS: mbpfan/1.9.1-1 ITP

[Herminio Hernandez Jr]

On 08/31, Herminio Hernandez, Jr. wrote:
Mentors,

I am trying to convert my package using git. I am running into the lintian error

gbp:error: Can't determine upstream version from changelog

Mentors,

I am trying to convert my package using git. I am running into the lintian error

gbp:error: Can't determine upstream version from changelog

Mentors,

I am trying to convert my package using git. I am running into the lintian error

gbp:error: Can't determine upstream version from changelog

Mentors,

I am trying to convert my package using git. I am running into the lintian error

gbp:error: Can't determine upstream version from changelog

Mentors,

I am trying to convert my package using git. I am running into the lintian error

gbp:error: Can't determine upstream version from changelog

Mentors,

I am trying to convert my package using git. I am running into the lintian error

W: mbpfan source: source-nmu-has-incorrect-version-number 1.9.1-1

Based on what I read here: 
https://lintian.debian.org/tags/source-nmu-has-incorrect-version-number.html I 
tried to change the version to -0.1 in the changelog. Now I am getting this 
error

gbp:error: upstream/0 is not a valid treeish

If can point into the right direction I would appreciate it.

Thanks!

Herminio
Aug 31, 2016 at 2:43 PM, Sean Whitton 
> wrote:
> 
> > Dear Herminio,
> >
> > [please CC the RFS so that your e-mail gets recorded and others can
> > provide feedback as well as me -- use reply-to-all]
> >
> > On Tue, Aug 30, 2016 at 10:23:09PM -0700, Herminio Hernandez, Jr. wrote:
> > > I have combined the patches using combinediff. I know you want me to
> > convert to
> > > git. Can you recommend good documentation to convert my package? Thanks!
> >
> > One easy way is to do this:
> >
> > apt-get install git-buildpackage
> > gbp import-dsc mbpfan_1.9.1-1.dsc
> >
> > --
> > Sean Whitton
> >


signature.asc
Description: PGP signature

Bug#829520: RFS: mbpfan/1.9.1-1 ITP

[Herminio Hernandez, Jr.]

will do apologies

On Wed, Aug 31, 2016 at 2:43 PM, Sean Whitton 
wrote:

> Dear Herminio,
>
> [please CC the RFS so that your e-mail gets recorded and others can
> provide feedback as well as me -- use reply-to-all]
>
> On Tue, Aug 30, 2016 at 10:23:09PM -0700, Herminio Hernandez, Jr. wrote:
> > I have combined the patches using combinediff. I know you want me to
> convert to
> > git. Can you recommend good documentation to convert my package? Thanks!
>
> One easy way is to do this:
>
> apt-get install git-buildpackage
> gbp import-dsc mbpfan_1.9.1-1.dsc
>
> --
> Sean Whitton
>

Bug#829520: RFS: mbpfan/1.9.1-1 ITP

[Sean Whitton]

Dear Herminio,

[please CC the RFS so that your e-mail gets recorded and others can
provide feedback as well as me -- use reply-to-all]

On Tue, Aug 30, 2016 at 10:23:09PM -0700, Herminio Hernandez, Jr. wrote:
> I have combined the patches using combinediff. I know you want me to convert 
> to
> git. Can you recommend good documentation to convert my package? Thanks!

One easy way is to do this:

apt-get install git-buildpackage
gbp import-dsc mbpfan_1.9.1-1.dsc

-- 
Sean Whitton

Bug#829520: RFS: mbpfan/1.9.1-1 ITP

[Sean Whitton]

Hello,

On Tue, Aug 30, 2016 at 12:05:51AM -0700, Herminio Hernandez Jr wrote:
> > 5. You have lots and lots of patches without proper patch headers.  The
> > patches seem to be revisions of each other.  You need one patch for each
> > meaningful change, with the reason for the change explained in the patch
> > header (ideally a DEP-3-compatible header).
> > 
> I am aware of this. I have been trying to figure out how to merge these 
> patches. Any suggestions would be appreciated.

You can use gbp-pq(1) to convert the patches to a git branch, and then
use an interactive rebase to merge them.

Or there is combinediff(1).

> > 6. You shouldn't patch the makefile's install target.  Override
> > dh_auto_install to disable it, and use dh_install to install the
> > files where they should go.  (See the manpages for those tools.)
> > 
> I will look into this. I did put in a pull request upstream with my Makefile 
> changes and I believe it will be merged.

Great -- as I said, remove the moreinfo tag from the bug when you think
it's ready for another review.

-- 
Sean Whitton

Bug#829520: RFS: mbpfan/1.9.1-1 ITP

[Sean Whitton]

control: tag -1 +moreinfo

Dear Herminio,

I'd like to review this package and help you get it into good shape for
an upload to Debian, but it's quite hard to review right now because the
debian/ subdir has a lot of cruft.

If you resolve the following clean-up issues, please remove the moreinfo
tag from the RFS bug, let me know and I'll review it.

1. Please make the packaging available in git, rather than a .dsc from
mentors.  This makes it easy to see when you've made suggested fixes
using `git diff`.

2. You have a lot of *.ex files that aren't doing anything in the
debian/ subdir.  And README.source.  There shouldn't be any template
files you aren't using.

3. Similarly lots of example text in d/rules.

4. And d/watch.

5. You have lots and lots of patches without proper patch headers.  The
patches seem to be revisions of each other.  You need one patch for each
meaningful change, with the reason for the change explained in the patch
header (ideally a DEP-3-compatible header).

6. You shouldn't patch the makefile's install target.  Override
dh_auto_install to disable it, and use dh_install to install the files
where they should go.  (See the manpages for those tools.)

Hope we can make progress with this one!  Thanks!

-- 
Sean Whitton


signature.asc
Description: PGP signature

Bug#829520: RFS: mbpfan/1.9.1-1 ITP

[Herminio Hernandez Jr]

Package: sponsorship-requests
Severity: normal [important for RC bugs, wishlist for new packages]

Dear mentors,

I am looking for a sponsor for my package "mbpfan"

 Package name: mbpfan
 Version : 1.9.1-1
 Upstream Author : Daniel Graziotin 
 URL : https://github.com/dgraziotin/mbpfan
 License : GPL-3

It builds those binary packages:

  mbpfan - Fan-Control-Daemon for MacBook Pro

To access further information about this package, please visit the following 
URL:

https://mentors.debian.net/package/mbpfan


Alternatively, one can download the package with dget using this command:

 dget -x https://mentors.debian.net/debian/pool/main/m/mbpfan/mbpfan_1.9.1-1.dsc

More information about mbpfan can be obtained from 
https://github.com/dgraziotin/mbpfan.

Regards,
Herminio


signature.asc
Description: PGP signature