Bug#831792: RFS: scid/1:4.6.4+dfsg1-1
hi, done! thanks, G.
Bug#831792: RFS: scid/1:4.6.4+dfsg1-1
> Hi, can you please have a look at the build failures? > > thanks > > > g++ -MMD -g -O2 -fdebug-prefix-map=/«BUILDDIR»/scid-4.6.4+dfsg1=. -fPIE > -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time > -D_FORTIFY_SOURCE=2 -O3 -march=native -fno-rtti -fno-exceptions -std=c++11 > -pthread -Wall -DZLIB -I/usr/include/tk -o src/sortcache.o -c > src/sortcache.cpp > g++ -MMD -g -O2 -fdebug-prefix-map=/«BUILDDIR»/scid-4.6.4+dfsg1=. -fPIE > -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time > -D_FORTIFY_SOURCE=2 -O3 -march=native -fno-rtti -fno-exceptions -std=c++11 > -pthread -Wall -DZLIB -I/usr/include/tk -o src/pgnparse.o -c > src/pgnparse.cpp > g++ -MMD -g -O2 -fdebug-prefix-map=/«BUILDDIR»/scid-4.6.4+dfsg1=. -fPIE > -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time > -D_FORTIFY_SOURCE=2 -O3 -march=native -fno-rtti -fno-exceptions -std=c++11 > -pthread -Wall -DZLIB -I/usr/include/tk -o src/engine.o -c src/engine.cpp > src/engine.cpp: In member function 'int Engine::Think(MoveList*)': > src/engine.cpp:1482:51: warning: suggest parentheses around '&&' within '||' > [-Wparentheses] > if (mlist->Size() <= depth || depth >= 5 && IsMatingScore (bestScore)) { > break; } > ^ > g++ -MMD -g -O2 -fdebug-prefix-map=/«BUILDDIR»/scid-4.6.4+dfsg1=. -fPIE > -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time > -D_FORTIFY_SOURCE=2 -O3 -march=native -fno-rtti -fno-exceptions -std=c++11 > -pthread -Wall -DZLIB -I/usr/include/tk -o src/sc_base.o -c src/sc_base.cpp > In file included from src/gfile.h:26:0, > from src/scidbase.h:25, > from src/sc_base.cpp:21: > src/fastgame.h: In static member function 'static squareT > FastGame::decodeKing(squareT, byte)': > src/fastgame.h:436:63: error: narrowing conversion of '-9' from 'int' to > 'char' inside { } [-Wnarrowing] > static const char sqdiff[] = { 0, -9, -8, -7, -1, 1, 7, 8, 9}; > ^ > src/fastgame.h:436:63: error: narrowing conversion of '-8' from 'int' to > 'char' inside { } [-Wnarrowing] > src/fastgame.h:436:63: error: narrowing conversion of '-7' from 'int' to > 'char' inside { } [-Wnarrowing] > src/fastgame.h:436:63: error: narrowing conversion of '-1' from 'int' to > 'char' inside { } [-Wnarrowing] > src/fastgame.h: In static member function 'static squareT > FastGame::decodeKnight(squareT, byte)': > src/fastgame.h:450:91: error: narrowing conversion of '-17' from 'int' to > 'char' inside { } [-Wnarrowing] > static const char sqdiff[] = { 0, -17, -15, -10, -6, 6, 10, 15, 17, 0, 0, 0, > 0, 0, 0, 0 }; > ^ > src/fastgame.h:450:91: error: narrowing conversion of '-15' from 'int' to > 'char' inside { } [-Wnarrowing] > src/fastgame.h:450:91: error: narrowing conversion of '-10' from 'int' to > 'char' inside { } [-Wnarrowing] > src/fastgame.h:450:91: error: narrowing conversion of '-6' from 'int' to > 'char' inside { } [-Wnarrowing] > Makefile:334: recipe for target 'src/sc_base.o' failed Hi Gianfranco, I've uploaded a new revision to mentors[0] that fixes errors on building for some architectures. Thanks again! Regards, [0]https://mentors.debian.net/package/scid pgpnFeGmljER2.pgp Description: PGP signature
Bug#831792: RFS: scid/1:4.6.4+dfsg1-1
Hi, can you please have a look at the build failures? thanks g++ -MMD -g -O2 -fdebug-prefix-map=/«BUILDDIR»/scid-4.6.4+dfsg1=. -fPIE -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -O3 -march=native -fno-rtti -fno-exceptions -std=c++11 -pthread -Wall -DZLIB -I/usr/include/tk -o src/sortcache.o -c src/sortcache.cpp g++ -MMD -g -O2 -fdebug-prefix-map=/«BUILDDIR»/scid-4.6.4+dfsg1=. -fPIE -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -O3 -march=native -fno-rtti -fno-exceptions -std=c++11 -pthread -Wall -DZLIB -I/usr/include/tk -o src/pgnparse.o -c src/pgnparse.cpp g++ -MMD -g -O2 -fdebug-prefix-map=/«BUILDDIR»/scid-4.6.4+dfsg1=. -fPIE -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -O3 -march=native -fno-rtti -fno-exceptions -std=c++11 -pthread -Wall -DZLIB -I/usr/include/tk -o src/engine.o -c src/engine.cpp src/engine.cpp: In member function 'int Engine::Think(MoveList*)': src/engine.cpp:1482:51: warning: suggest parentheses around '&&' within '||' [-Wparentheses] if (mlist->Size() <= depth || depth >= 5 && IsMatingScore (bestScore)) { break; } ^ g++ -MMD -g -O2 -fdebug-prefix-map=/«BUILDDIR»/scid-4.6.4+dfsg1=. -fPIE -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -O3 -march=native -fno-rtti -fno-exceptions -std=c++11 -pthread -Wall -DZLIB -I/usr/include/tk -o src/sc_base.o -c src/sc_base.cpp In file included from src/gfile.h:26:0, from src/scidbase.h:25, from src/sc_base.cpp:21: src/fastgame.h: In static member function 'static squareT FastGame::decodeKing(squareT, byte)': src/fastgame.h:436:63: error: narrowing conversion of '-9' from 'int' to 'char' inside { } [-Wnarrowing] static const char sqdiff[] = { 0, -9, -8, -7, -1, 1, 7, 8, 9}; ^ src/fastgame.h:436:63: error: narrowing conversion of '-8' from 'int' to 'char' inside { } [-Wnarrowing] src/fastgame.h:436:63: error: narrowing conversion of '-7' from 'int' to 'char' inside { } [-Wnarrowing] src/fastgame.h:436:63: error: narrowing conversion of '-1' from 'int' to 'char' inside { } [-Wnarrowing] src/fastgame.h: In static member function 'static squareT FastGame::decodeKnight(squareT, byte)': src/fastgame.h:450:91: error: narrowing conversion of '-17' from 'int' to 'char' inside { } [-Wnarrowing] static const char sqdiff[] = { 0, -17, -15, -10, -6, 6, 10, 15, 17, 0, 0, 0, 0, 0, 0, 0 }; ^ src/fastgame.h:450:91: error: narrowing conversion of '-15' from 'int' to 'char' inside { } [-Wnarrowing] src/fastgame.h:450:91: error: narrowing conversion of '-10' from 'int' to 'char' inside { } [-Wnarrowing] src/fastgame.h:450:91: error: narrowing conversion of '-6' from 'int' to 'char' inside { } [-Wnarrowing] Makefile:334: recipe for target 'src/sc_base.o' failed G.
Bug#831792: RFS: scid/1:4.6.4+dfsg1-1
On Mon, 8 Aug 2016 17:30:38 + (UTC) Gianfranco Costamagnawrote: Hi Gianfranco, > new review: > 1) please convert the versioning into 1:4.6.2-1 and remove the NMU syntax. > and add a "Set myself as Maintainer" Versioning is 1:4.6.4+dfsg1-1 due to repackaging of upstream sources. I've seen other examples using this versioning nomenclature. > > 2) missing newline between last entry and your signature > to make it DFSG compliant. > -- Jose G. López Mon, 08 Aug 2016 11:23:07 +0200 Fixed. > > 3) copyrights missing > grep -i copyright . -R |grep -v Fulv |grep -v Shane |grep -vi pascal Sorry for this. Completed and hope this time is ok. > > after that we should be *really* good, and I'll put the package in deferred, > to make it reach unstable in 15 days or so > (mia team should orphan the package in the meanwhile). > In case it gets orphaned close the bug with > "set myself as Maintainer (Closes: #) Thanks for advertising scid was orphaned. Added myself as adopter ;-) New revision uploaded to mentors[0], the last one uploaded at 2016-08-26 18:59 I'll have a look to other packages orphaned to see if I can help with them. Thanks and regards, [0]https://mentors.debian.net/package/scid pgpbJi7TYoo_M.pgp Description: PGP signature