Bug#836215: RFS: phalanx/25-1 [ITA]

[Jose G. López]

On Wed, 14 Sep 2016 09:55:36 + (UTC)
Gianfranco Costamagna  wrote:

> you might even consider fixing the actual RC bug without a new upstream 
> release,
> let the package migrate, and upload the new version (crippled) in experimental
> or later in unstable.

Hi Gianfranco,

All right, I prefer to fix and improve the actual version and not trim
useful features that I as a user, would like to have.
I've uploaded the new debian revision to mentors[0]. To keep the
previous work I have created a new branch (debian/sid) where I
cherry-picked changes.

Thanks for your help and suggestions!

[0]https://mentors.debian.net/package/phalanx
[1]https://gitlab.com/deb-pkg/phalanx/tree/debian/sid


pgpsXbe1alMtI.pgp
Description: PGP signature

Bug#836215: RFS: phalanx/25-1 [ITA]

[Gianfranco Costamagna]

Hi

>Thanks for reviwing! I must say I've addressed most of your points but

>testing the new version (25), I've found that it doesn't work as
>expected in Scid. Scid has a feature to play versus Phalanx (tactical
>game) but it needs a special version. The package in sid works well
>while new version only works if you choose the option to play
>a specific opening.


mmm ok
>Apart from that, the engine works well both in scid
>(analyzing) and xboard (analyzing and playing with). I've tried to
>figure out the changes done to phalanx-scid engine but I don't come by
>with a solution.
>
>So don't know if it's better to fix and improve the version in
>sid (22+d051004) while asking Scid upstream to import the new version
>of Phalanx and knowing what changes need to be tweaked.
>
>What do you think?


you want to adopt the package, so I guess you need to be the one knowing if
the package is worth an upload or not.

you might even consider fixing the actual RC bug without a new upstream release,
let the package migrate, and upload the new version (crippled) in experimental
or later in unstable.

Just use your judgment, is upstream active/fast in answering?
it this a problem that will cause headaches to your end users and lots of bug 
reports?
or is something that probably nobody would notice, or not a real usability 
issue?

let me know,

Gianfranco

Bug#836215: RFS: phalanx/25-1 [ITA]

[Jose G. López]

Hi Gianfranco,

Thanks for reviwing! I must say I've addressed most of your points but
testing the new version (25), I've found that it doesn't work as
expected in Scid. Scid has a feature to play versus Phalanx (tactical
game) but it needs a special version. The package in sid works well
while new version only works if you choose the option to play
a specific opening.

Apart from that, the engine works well both in scid
(analyzing) and xboard (analyzing and playing with). I've tried to
figure out the changes done to phalanx-scid engine but I don't come by
with a solution.

So don't know if it's better to fix and improve the version in
sid (22+d051004) while asking Scid upstream to import the new version
of Phalanx and knowing what changes need to be tweaked.

What do you think?

Regards,


pgp3RgkkHVa86.pgp
Description: PGP signature

Bug#836215: RFS: phalanx/25-1 [ITA]

[Gianfranco Costamagna]

control: owner -1 !
control: tags -1 moreinfo


>I am looking for a sponsor for my package "phalanx":


  * New upstream version.

- New version builds with GCC 6. (Closes: #811584)

this one can become a subsection of "new upstream version"


>  * debian/copyright: Update and change Format tag to the accepted one.

please "Format" field in https


>  * debian/install: Adjust destination files.

why?

>- 03_makefile_DEFINES.diff: Refresh and renamed it to

>01_makefile.patch

missing 

--  $(CC) $(CFLAGS) $(DEFINES) $(LDFLAGS) $(OBJ) -o phalanx
-+  $(CC) $(CFLAGS) $(DEFINES) $(OBJ) $(LDFLAGS) -o phalanx

change

>05_PG_version-string.diff

disappeared


>- 10_hardening-string-literal_search.diff,

disappeared

>  16_hardening-pointer-sign_bcreate: Remove, not needed anymore.

why?


missing changelog entries:
remove TARGET=optimized

and... why did you remove it?


and now the review:
"getopt.c" <-- missing copyright

>
-pbook.phalanx usr/share/games/phalanx/
-sbook.phalanx usr/lib/games/phalanx/
+pbook.phalanx usr/share/phalanx/
+sbook.phalanx usr/share/phalanx/
+phalanx.eng usr/share/phalanx/plugins/xboard/


why?

it's all for now

G.

Bug#836215: RFS: phalanx/25-1 [ITA]

[Jose G. Lopez]

Package: sponsorship-requests
Severity: normal

Dear mentors,

I am looking for a sponsor for my package "phalanx":

* Package name: phalanx
  Version : 25-1
  Upstream Author : Dusan Dobes < dusa...@users.sf.net>
* URL : https://sourceforge.net/projects/phalanx/
* License : GPL v2
  Section : games

It builds those binary packages:

  phalanx - Chess playing program

To access further information about this package, please visit the
following URL:

  https://mentors.debian.net/package/phalanx

Alternatively, one can download the package with dget using this
command:

  dget -x https://mentors.debian.net/debian/pool/main/p/phalanx/phalanx_25-1.dsc

It was removed from testing due to an FTBFS with GCC 6 (bug 811584).
Package development is on the following repo:

https://gitlab.com/deb-pkg/phalanx

Changes since the last upload:

phalanx (25-1) unstable; urgency=medium

  * New upstream version.
  * Set myself as Maintainer. (Closes: #835309)
  * New version builds with GCC 6. (Closes: #811584)
  * debian/compat: Upgrade to version 9.
  * debian/config: Fix lintian report 'maintainer-script-without-set-e'.
  * debian/control:
- Bump to Standards-Version 3.9.8. No changes required.
- Add Vcs-* fields to show where development is done.
  * debian/copyright: Update and change Format tag to the accepted one.
  * debian/install: Adjust destination files.
  * debian/patches:
- 03_makefile_DEFINES.diff: Refresh and renamed it to
01_makefile.patch
- 04_PG_setboard_command.diff: Remove, applied upstream.
- 10_hardening-string-literal_search.diff,
  12_hardening-string-literal_io.diff,
  14_hardening-string-literal_book.diff,
  16_hardening-pointer-sign_bcreate: Remove, not needed anymore.
- 16_hardening-unused-but-set_endgame,
  17_bcreate,
  20_fix_linker_problem, 
  25_arch_compiler-flags: Not applicable
  * debian/po:
- pt_BR.po: New, thanks to Adriano Rafael Gomes. (Closes: #811526)
- ca.po: Update to remove fuzzy translations.
  * debian/rules:
- Add hardening flags.
- Add --parallel option to debhelper.
- Add override_dh_auto_install to overwrite install dir.

Regards,


pgp_cPCNqD1n9.pgp
Description: PGP signature