Bug#840750: RFS: picocoin/0.1-2.gbp43047g

[Joel DeJesus]

I uploaded a few different versions of what I had to try to clean up the
errors.

I think I am pretty close to the final version (latest at 0.1-4)

I could not figure out how to fix the warning about "ldconfig", but I
did add a trigger file for that to take care of it.

- Joel


PS added link for easy reference:
https://mentors.debian.net/package/picocoin

On 04/10/2017 11:53 AM, David Steele wrote:
> On Sun, Apr 9, 2017 at 9:13 PM, Joel DeJesus
>  wrote:
>> I have uploaded a new source package to fix some of the smaller issues
>> with the control files, copyrights, etc.  However, I seem to be stuck at
>> what to do with the library name, libccoin.
>>
>> I was planning on just have libccoin as the package name and just
>> managing the soname with the proper Makefile.am files.  However,
>> according to the "package-name-doesnt-match-sonames", I will need to
>> rename the package to libccoin0.
>>
>> Is it better for me to just change the name to libccoin0?
> Take a look at what the policy says.
>
> https://www.debian.org/doc/debian-policy/ch-sharedlibs.html
>
>> As for the dependencies, I will have to learn how to use pbuilder under
>> git-buildpackage and try to submit another source package.
> git-buildpackage is useful, but complicated first time out, and not
> necessary for this.
>
> https://pbuilder.alioth.debian.org/
>
> If you are using gbp, put the config file in the debian folder.See
> "builder=git-pbuilder".



signature.asc
Description: OpenPGP digital signature

Bug#840750: RFS: picocoin/0.1-2.gbp43047g

[David Steele]

On Sun, Apr 9, 2017 at 9:13 PM, Joel DeJesus
 wrote:
> I have uploaded a new source package to fix some of the smaller issues
> with the control files, copyrights, etc.  However, I seem to be stuck at
> what to do with the library name, libccoin.
>
> I was planning on just have libccoin as the package name and just
> managing the soname with the proper Makefile.am files.  However,
> according to the "package-name-doesnt-match-sonames", I will need to
> rename the package to libccoin0.
>
> Is it better for me to just change the name to libccoin0?

Take a look at what the policy says.

https://www.debian.org/doc/debian-policy/ch-sharedlibs.html

>
> As for the dependencies, I will have to learn how to use pbuilder under
> git-buildpackage and try to submit another source package.

git-buildpackage is useful, but complicated first time out, and not
necessary for this.

https://pbuilder.alioth.debian.org/

If you are using gbp, put the config file in the debian folder.See
"builder=git-pbuilder".

Bug#840750: RFS: picocoin/0.1-2.gbp43047g

[Joel DeJesus]

Thank you for the reply/update.

I have uploaded a new source package to fix some of the smaller issues
with the control files, copyrights, etc.  However, I seem to be stuck at
what to do with the library name, libccoin.

I was planning on just have libccoin as the package name and just
managing the soname with the proper Makefile.am files.  However,
according to the "package-name-doesnt-match-sonames", I will need to
rename the package to libccoin0.

Is it better for me to just change the name to libccoin0?

As for the dependencies, I will have to learn how to use pbuilder under
git-buildpackage and try to submit another source package.


- Joel

On 04/09/2017 07:23 AM, Dave Steele wrote:
> Sorry for the delay.
>
> Concerning your latest upload, 0.1-2+nmu1:
>
> - The yellow flags on the mentors page should be cleared
>   - This is not an NMU (non-maintainer upload). Look at
> the help message associated with the lintian issue.
>   - the home page and Vcs links are commented out in
> control. Those should be enabled.
>   - The watch file is important, and not complicated in
> this case. Google 'debian watch github'.
>
> - The package failed to build from source (FTBFS), using
>   pdebuild. Is there a missing build dependency?
>
> I haven't looked much farther than that.




signature.asc
Description: OpenPGP digital signature

Bug#840750: RFS: picocoin/0.1-2.gbp43047g

[Dave Steele]

Sorry for the delay.

Concerning your latest upload, 0.1-2+nmu1:

- The yellow flags on the mentors page should be cleared
  - This is not an NMU (non-maintainer upload). Look at
the help message associated with the lintian issue.
  - the home page and Vcs links are commented out in
control. Those should be enabled.
  - The watch file is important, and not complicated in
this case. Google 'debian watch github'.

- The package failed to build from source (FTBFS), using
  pdebuild. Is there a missing build dependency?

I haven't looked much farther than that.

Bug#840750: RFS: picocoin/0.1-2.gbp43047g

[David Steele]

Expanding on the previous feedback (from a quick review):

You should clear all of the non-green issues on the [mentors page]. Note that 
debuild includes a lintian run.

changelog:
  - The NMU complaint is there because your names in control and changelog 
don't match.

control
  - You should also populate the Vcs fields in control. This references your 
Debian repository.

rules
  - There are many who would require you to clear out the comments in that file.

copyright
  - The ftp masters pay particularly close attention to the copyright file of 
packages in the NEW queue. Yours has an error in it (missing License line in 
the claim paragraph). It also is missing references to third party Copyright 
claims in the source tree, and to your files in the debian directory. Do a 
careful search of copyright claims, and make sure all are documented.
  - "The MIT License (MIT)" (exact text) is not on the 'official' list. See the 
[license list], referenced from the [copyright file spec]. The one you are 
looking for is probably 'Expat', though you should verify the text carefully.

[mentors page]: https://mentors.debian.net/package/picocoin
[license list]: https://spdx.org/licenses/
[copyright files spec]: 
https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/


You can upload again to mentors when complete. Update the revision, and mark 
previous revisions as "UNRELEASED" (that may just be my personal preference).

-- 
"Le mieux est l'ennemi du bien" - Voltaire


signature.asc
Description: GooPG digital signature

Bug#840750: RFS: picocoin/0.1-2.gbp43047g

[Andrey Rahmatullin]

Control: tags -1 + moreinfo

The package has lots of lintian warnings, please fix them first.

-- 
WBR, wRAR


signature.asc
Description: PGP signature

Bug#840750: RFS: picocoin/0.1-2.gbp43047g

[Joel DeJesus]

Package: sponsorship-requests
Severity: normal

Dear mentors,

I am looking for a sponsor for my package "picocoin"

 * Package name: picocoin
   Version : 0.1-2.gbp43047g
   Upstream Author : Jef Garzik
 * URL : https://github.com/jgarzik/picocoin
 * License : MIT/X
   Section : libs

It builds those binary packages:

 picocoin-dev - bitcoin library - development files
 picocoin0  - bitcoin library - shared library

To access further information about this package, please visit the
following URL:

https://mentors.debian.net/package/picocoin


Alternatively, one can download the package with dget using this command:

  dget -x
https://mentors.debian.net/debian/pool/main/p/picocoin/picocoin_0.1-2.gbp43047g.dsc

More information about hello can be obtained from
https://github.com/jgarzik/picocoin/blob/master/README.md and
https://github.com/favioflamingo/picocoin (maintainer's page)

Changes since the last upload:

* added debian folder
* set patches to change constants to avoid conflict with perl


Regards,

Joel De Jesus