Bug#851606: RFS: rmlint/2.4.6-1 [ITP]

[Carlos Maddela]

On 14/02/17 18:56, Axel Beckert wrote:
> Hi,
>
> Carlos Maddela wrote:
>> Thanks for your suggestions. I have made the fixes and re-uploaded the
>> source files as the same version (since it still has yet to be
>> officially released) to mentors. I have applied for access to
>> collab-maint (just a few minutes ago), so I probably won't be able to
>> push my changes for another 24 hours. For the meantime, my changes are
>> available in the debian branch of https://github.com/e7appew/rmlint.git.
> Carlos: Thanks for the updated package.
>
> Roger: Thanks for the review and the reminder about this RFS.
>
> I've did a short first review. Will have a closer look at it probably
> this evening.
>
> One thing I noticed is that the upstream tar ball available at
> https://github.com/sahib/rmlint/releases and in the source package are
> not identical due to different compression.
>
> Is there a reason not to use the official source tarballs from
> https://github.com/sahib/rmlint/releases? (AFAIK and according to a
> short check, GitHub no more produces different tarballs upon
> subsequent downloads as it did in the past.)
>
> (Contentwise the contained files seem to be identical, so it's ok-ish,
> but such differences always cause extra work on any review of a source
> package, so it's preferred to use official tar balls if possible --
> which seems to be possible here.)
There wasn't any specific reason, except for trying to keep file sizes
as small as possible. I have reverted to using the original tarballs now.
>
> In debian/rules I found this:
>
> # Automatically disable tests in sbuild and pbuilder.
> ifneq (,$(filter /%nonexistent,$(HOME)))
> export DEB_BUILD_MAINT_OPTIONS += nocheck
> endif
>
> If this is to avoid issues with the test suite, it's a very unlucky
> solution as all of Debian's build daemon run sbuild and some sponsors
> upload packages using pbuilder. So when the binary packages are built
> which are to become the official binary packages, the test suite is
> not run. This especially applies to all other architectures than the
> maintainer's one and hence contradicts the idea that the test suite
> should be run at build time on all architectures to find
> architecture-specific issues.
>
> If a non-existent home is really such an issue, I'd rather set it to
> some other value and create that home directory with some sane
> contents, e.g. debian/tmp-home or so.
I only disabled the tests to speed up builds. There was initially some
problems with the tests inside of sbuild, which prevented successful
builds, but they have been resolved. The test suite doesn't make use of
any $HOME directory. It was just my way of detecting if the build was
being done from a chroot.

Anyway, I have removed those lines completely, and the tests are
performed now.

Cheers,

Carlos




signature.asc
Description: OpenPGP digital signature

Bug#851606: RFS: rmlint/2.4.6-1 [ITP]

[Axel Beckert]

Hi,

Carlos Maddela wrote:
> Thanks for your suggestions. I have made the fixes and re-uploaded the
> source files as the same version (since it still has yet to be
> officially released) to mentors. I have applied for access to
> collab-maint (just a few minutes ago), so I probably won't be able to
> push my changes for another 24 hours. For the meantime, my changes are
> available in the debian branch of https://github.com/e7appew/rmlint.git.

Carlos: Thanks for the updated package.

Roger: Thanks for the review and the reminder about this RFS.

I've did a short first review. Will have a closer look at it probably
this evening.

One thing I noticed is that the upstream tar ball available at
https://github.com/sahib/rmlint/releases and in the source package are
not identical due to different compression.

Is there a reason not to use the official source tarballs from
https://github.com/sahib/rmlint/releases? (AFAIK and according to a
short check, GitHub no more produces different tarballs upon
subsequent downloads as it did in the past.)

(Contentwise the contained files seem to be identical, so it's ok-ish,
but such differences always cause extra work on any review of a source
package, so it's preferred to use official tar balls if possible --
which seems to be possible here.)

In debian/rules I found this:

# Automatically disable tests in sbuild and pbuilder.
ifneq (,$(filter /%nonexistent,$(HOME)))
export DEB_BUILD_MAINT_OPTIONS += nocheck
endif

If this is to avoid issues with the test suite, it's a very unlucky
solution as all of Debian's build daemon run sbuild and some sponsors
upload packages using pbuilder. So when the binary packages are built
which are to become the official binary packages, the test suite is
not run. This especially applies to all other architectures than the
maintainer's one and hence contradicts the idea that the test suite
should be run at build time on all architectures to find
architecture-specific issues.

If a non-existent home is really such an issue, I'd rather set it to
some other value and create that home directory with some sane
contents, e.g. debian/tmp-home or so.

Will continue with the review later. Gotta go.

Regards, Axel
-- 
 ,''`.  |  Axel Beckert , http://people.debian.org/~abe/
: :' :  |  Debian Developer, ftp.ch.debian.org Admin
`. `'   |  4096R: 2517 B724 C5F6 CA99 5329  6E61 2FF9 CD59 6126 16B5
  `-|  1024D: F067 EA27 26B9 C3FC 1486  202E C09E 1D89 9593 0EDE


signature.asc
Description: Digital signature

Bug#851606: RFS: rmlint/2.4.6-1 [ITP]

[Carlos Maddela]

Dear Roger,

Thanks for your suggestions. I have made the fixes and re-uploaded the
source files as the same version (since it still has yet to be
officially released) to mentors. I have applied for access to
collab-maint (just a few minutes ago), so I probably won't be able to
push my changes for another 24 hours. For the meantime, my changes are
available in the debian branch of https://github.com/e7appew/rmlint.git.

This is the updated RFS:

I am looking for a sponsor for my package "rmlint"

 * Package name: rmlint
   Version : 2.4.6-1
   Upstream Author : Christopher Pahl 
 * URL : https://rmlint.readthedocs.io/
 * License : GPL-3
   Section : utils

  It builds these binary packages:

 rmlint - Extremely fast tool to remove filesystem lint
 rmlint-doc - HTML documentation for rmlint
 rmlint-gui - GTK+ frontend to rmlint

  To access further information about this package, please visit the
following URL:

  https://mentors.debian.net/package/rmlint


  Alternatively, one can download the package with dget using this command:

dget -x
https://mentors.debian.net/debian/pool/main/r/rmlint/rmlint_2.4.6-1.dsc

  More information about rmlint can be obtained from
https://rmlint.readthedocs.io/.

  Changes since the last upload:

  rmlint (2.4.6-1) unstable; urgency=medium

  * Initial upload to Debian. Thanks to Axel Beckert for getting
it all started, and to Roger Shimizu for suggested improvements.
(Closes: #845155)

 -- Carlos Maddela   Tue, 14 Feb 2017 10:04:33 +1100

  Regards,
   Carlos Maddela


On 10/02/17 00:21, Roger Shimizu wrote:
> Control: tag -1 +moreinfo
>
> Dear Carlos,
>
> I cannot sponsor the upload. But here's my review that I hope it's helpful.
>
> On Tue, Jan 17, 2017 at 3:56 AM, Carlos Maddela  wrote:
>>   I am looking for a sponsor for my package "rmlint"
>>
>>  * Package name: rmlint
>>Version : 2.4.6-1
>>Upstream Author : Christopher Pahl 
>>  * URL : https://rmlint.readthedocs.io/
>>  * License : GPL-3
>>Section : utils
> Here're the items need to be fixed:
>  - license/copyright
>There're many files not under GPL-3, which need to be mentioned in
> d/copyright
>
>  - There's Vcs-* line set for collab-maint, but I cannot access it.
>Please push your work in collab-maint or other git repo, which make
> the review easier.
>
>  - There's doc/ folder, but you didn't install them?
>
> Cheers,

Bug#851606: RFS: rmlint/2.4.6-1 [ITP]

[Roger Shimizu]

Control: tag -1 +moreinfo

Dear Carlos,

I cannot sponsor the upload. But here's my review that I hope it's helpful.

On Tue, Jan 17, 2017 at 3:56 AM, Carlos Maddela  wrote:
>
>   I am looking for a sponsor for my package "rmlint"
>
>  * Package name: rmlint
>Version : 2.4.6-1
>Upstream Author : Christopher Pahl 
>  * URL : https://rmlint.readthedocs.io/
>  * License : GPL-3
>Section : utils

Here're the items need to be fixed:
 - license/copyright
   There're many files not under GPL-3, which need to be mentioned in
d/copyright

 - There's Vcs-* line set for collab-maint, but I cannot access it.
   Please push your work in collab-maint or other git repo, which make
the review easier.

 - There's doc/ folder, but you didn't install them?

Cheers,
-- 
Roger Shimizu, GMT +9 Tokyo
PGP/GPG: 4096R/6C6ACD6417B3ACB1

Bug#851606: RFS: rmlint/2.4.6-1 [ITP]

[Axel Beckert]

Hi Carlos,

Carlos Maddela wrote:
>rmlint (2.4.6-1) unstable; urgency=medium
> 
>  * Initial upload to Debian. Thanks to Axel Beckert for getting
>it all started. (Closes: #845155)
> 
> -- Carlos Maddela   Tue, 17 Jan 2017 04:45:28 +1100

Thanks a lot for taking care of the rmlint Debian package!

I'll surely have a look it, but chances are high that I will do so
only after 24th of January due to the imminent freeze in Testing.

Regards, Axel
-- 
 ,''`.  |  Axel Beckert , http://people.debian.org/~abe/
: :' :  |  Debian Developer, ftp.ch.debian.org Admin
`. `'   |  4096R: 2517 B724 C5F6 CA99 5329  6E61 2FF9 CD59 6126 16B5
  `-|  1024D: F067 EA27 26B9 C3FC 1486  202E C09E 1D89 9593 0EDE

Bug#851606: RFS: rmlint/2.4.6-1 [ITP]

[Carlos Maddela]

Package: sponsorship-requests
Severity: wishlist

Dear mentors,

  I am looking for a sponsor for my package "rmlint"

 * Package name: rmlint
   Version : 2.4.6-1
   Upstream Author : Christopher Pahl 
 * URL : https://rmlint.readthedocs.io/
 * License : GPL-3
   Section : utils

  It builds these binary packages:

rmlint - Extremely fast tool to remove filesystem lint
rmlint-gui - GTK+ frontend to rmlint

  To access further information about this package, please visit the following 
URL:

https://mentors.debian.net/package/rmlint


  Alternatively, one can download the package with dget using this command:

dget -x 
https://mentors.debian.net/debian/pool/main/r/rmlint/rmlint_2.4.6-1.dsc

  More information about rmlint can be obtained from 
https://rmlint.readthedocs.io/.

  Initial upload:

   rmlint (2.4.6-1) unstable; urgency=medium

 * Initial upload to Debian. Thanks to Axel Beckert for getting
   it all started. (Closes: #845155)

-- Carlos Maddela   Tue, 17 Jan 2017 04:45:28 +1100


  Regards,
   Carlos Maddela