Bug#870042: RFS: gsettings-qt/0.1+16.04.20170729-1 [ITP]

[Boyuan Yang]

2017-07-31 9:07 GMT+08:00 Boyuan Yang <073p...@gmail.com>:
> 2017-07-31 9:04 GMT+08:00 Lisandro Damián Nicanor Pérez Meyer
> :
>> On sábado, 29 de julio de 2017 11:21:40 -03 Pino Toscano wrote:
>>> Hi,
>>>
>>> I'm not uploading it myself,
>>
>> Neither me, but I wanted to add some more info to what Pino already provided.
>>
>>> but there are various things that ought to
>>> be fixed:
>>>
>>> a) qtchooser is not needed in Build-Depends, it's an "implementation
>>>detail"
>>
>> You might want to take a look at
>>
>> 
>>
>>> b) we don't use a "qtdeclarative5-" prefix for QML modules, but
>>>"qml-module-"
>>
>> See 
>>
>>
>>
>> --
>> Alas, I am dying beyond my means.
>>   Oscar Wilde, as he sipped champagne on his deathbed
>>
>> Lisandro Damián Nicanor Pérez Meyer
>> http://perezmeyer.com.ar/
>> http://perezmeyer.blogspot.com/
>
> Thank you all for the detailed review, which really helps.
>
> I'm not really familiar with C++/Qt/KDE packaging but this package
> falls in this range as a dependency unfortunately.
> I will read those instructions and fix problems.
>
> Regards,
> Boyuan Yang

OK. All problems mentioned above should be fixed now, both in git repo
and source package
on mentors.debian.net. (Many thanks to pino@ and perezmeyer.)

Future development and upstream maintenance is likely be taken by
Deepin Co.,Ltd. if
Canonical quits since Deepin software depends on this package heavily.
Pkg-deepin team
is working together with deepin upstream on it. As a result I believe
n) should not be a blocker
for package uploading.

Package maintainer was set back to pkg-deepin since we are taking care
of it in reality. Thanks
for the suggestion.

After enabling the test, this package would fail one test in Debian
Unstable. Investigations show
that it is a bug of Qt 5.7. [1][2] This bug has been fixed since Qt 5.8.
Qt in Ubuntu already have this bug fixed by backporting upstream patch.

With no visible time schedule for new Qt in Debian, I choose to
disable that test for now and re-enable
it after Qt 5.9 enters unstable. Meanwhile, anyone interested please
consider reviewing the package
again and help sponsor this package if you feel comfortable. This
package is blocking the workflow of
pkg-deepin team and it would be great if we could get the problem
fixed in a reasonable time period.

* https://anonscm.debian.org/git/collab-maint/gsettings-qt.git
* https://mentors.debian.net/package/gsettings-qt

[1] https://bugs.launchpad.net/ubuntu/+source/gsettings-qt/+bug/1624251
[2] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=871265

Regards,
Boyuan Yang

Bug#870042: RFS: gsettings-qt/0.1+16.04.20170729-1 [ITP]

[Lisandro Damián Nicanor Pérez Meyer]

On sábado, 29 de julio de 2017 11:21:40 -03 Pino Toscano wrote:
> Hi,
> 
> I'm not uploading it myself,

Neither me, but I wanted to add some more info to what Pino already provided.

> but there are various things that ought to
> be fixed:
> 
> a) qtchooser is not needed in Build-Depends, it's an "implementation
>detail"

You might want to take a look at



> b) we don't use a "qtdeclarative5-" prefix for QML modules, but
>"qml-module-"

See 



-- 
Alas, I am dying beyond my means.
  Oscar Wilde, as he sipped champagne on his deathbed

Lisandro Damián Nicanor Pérez Meyer
http://perezmeyer.com.ar/
http://perezmeyer.blogspot.com/


signature.asc
Description: This is a digitally signed message part.

Bug#870042: RFS: gsettings-qt/0.1+16.04.20170729-1 [ITP]

[Boyuan Yang]

2017-07-31 9:04 GMT+08:00 Lisandro Damián Nicanor Pérez Meyer
:
> On sábado, 29 de julio de 2017 11:21:40 -03 Pino Toscano wrote:
>> Hi,
>>
>> I'm not uploading it myself,
>
> Neither me, but I wanted to add some more info to what Pino already provided.
>
>> but there are various things that ought to
>> be fixed:
>>
>> a) qtchooser is not needed in Build-Depends, it's an "implementation
>>detail"
>
> You might want to take a look at
>
> 
>
>> b) we don't use a "qtdeclarative5-" prefix for QML modules, but
>>"qml-module-"
>
> See 
>
>
>
> --
> Alas, I am dying beyond my means.
>   Oscar Wilde, as he sipped champagne on his deathbed
>
> Lisandro Damián Nicanor Pérez Meyer
> http://perezmeyer.com.ar/
> http://perezmeyer.blogspot.com/

Thank you all for the detailed review, which really helps.

I'm not really familiar with C++/Qt/KDE packaging but this package
falls in this range as a dependency unfortunately.
I will read those instructions and fix problems.

Regards,
Boyuan Yang

Bug#870042: RFS: gsettings-qt/0.1+16.04.20170729-1 [ITP]

[Pino Toscano]

Hi,

I'm not uploading it myself, but there are various things that ought to
be fixed:

a) qtchooser is not needed in Build-Depends, it's an "implementation
   detail"

b) we don't use a "qtdeclarative5-" prefix for QML modules, but
   "qml-module-"

c) seen while building:
dpkg-gencontrol: warning: Depends field of package libgsettings-qt-dev: unknown 
substitution variable ${shlibs:Depends}

d) lines like "usr/lib/*/lib*.so*" are way too generic, and they will
   silently adapt to breaking changes like library renaming, or even
   SONAME bump; a way better option is:
   - libfoo1.install: "usr/lib/*/libfoo.so.1" + "usr/lib/*/libfoo.so.1.*"
   - libfoo-dev.install: "usr/lib/*/libfoo.so"

e) the descriptions could be improved:
   - short descriptions don't start with an uppercase letter
   - longer description could say something more...

f) there is no watch file, so upstream does not do releases at all?
   in this case, you need to specify in changelog that you did a new
   upstream snapshot

g) the QML example in the -dev package? that does not seem to logic to
   me, since you would install the QML package to run it, not the -dev
   (which is needed for using the C++ library)

h) all the "Pre-Depends" fields in control should not be needed anymore
   at this point

i) "Format" in copyright should be https now

j) the symbols file needs "Build-Depends-Package:"; also you added an
   entry as mangled (line 35), while the rest of the file is with
   unmangled symbols (and no old commented entries, please)

k) the tests don't seem to be run at all?

l) the package with the QML module could be "Multi-Arch: same", and
   most probably the -dev package too (but needs to be checked)

m) strictly speaking, there is no need to have this under the qt-kde
   umbrella, since you already put it under collab-maint, and the
   prospected users are other packages in the pkg-deepin team;
   collab-maint with you as single maintainer, or pkg-deepin, would
   be better choices IMHO

n) considering (f) above, the patches, and the logs of the upstream
   repository (especially that few names are not Canonical employees
   anymore), I have some doubt whether this software is still
   maintained/fixed/worked on at all, and thus that it would be
   unmaintained code in Debian right from the first upload

That should be enough notes for now; as general recommendation, please
check the build logs, and fix the lintian issues when possible (info
tags included).

-- 
Pino Toscano

signature.asc
Description: This is a digitally signed message part.

Bug#870042: RFS: gsettings-qt/0.1+16.04.20170729-1 [ITP]

[Boyuan Yang]

Package: sponsorship-requests
Severity: wishlist
X-Debbugs-CC: czc...@debian.org debian-qt-...@lists.debian.org

Dear mentors,

I am looking for a sponsor for my package "gsettings-qt".

 * Package name: gsettings-qt
   Version : 0.1+16.04.20170729-1
   Upstream Author : Canonical Ltd.
 * URL : https://launchpad.net/gsettings-qt
 * License : LGPL-3
   Section : libs


  It builds those binary packages:

 libgsettings-qt-dev - Library to access GSettings from Qt - devel
 libgsettings-qt1 - Library to access GSettings from Qt
 qtdeclarative5-gsettings1.0 - QML Bindings for GSettings

  To access further information about this package, please visit the following 
URL:

  https://mentors.debian.net/package/gsettings-qt

  Alternatively, one can download the package with dget using this command:

dget -x https://mentors.debian.net/debian/pool/main/g/gsettings-qt/
gsettings-qt_0.1+16.04.20170729-1.dsc

  Alternatively, one can view build status on deb-o-matic amd64:
dget -x http://debomatic-amd64.debian.net/debomatic/unstable/pool/
gsettings-qt_0.1+16.04.20170729-1/gsettings-qt_0.1+16.04.20170729-1.dsc

  Git packaging repository can be found on Alioth:
https://anonscm.debian.org/git/collab-maint/gsettings-qt.git

  Changes since last upload:

 gsettings-qt (0.1+16.04.20170729-1) unstable; urgency=medium
 .
   * Initial Release in Debian. (Closes: #870031)
   * Fix FTBFS problem due to incorrect link path. (LP: #1706682)

Regards,
Boyuan Yang

signature.asc
Description: This is a digitally signed message part.