Bug#886827: RFS: youtube-dl-gui/0.4-1 [ITP]

[Lumin]

Hi Félix,

I'm sure youtube-dl is working when invoked from command line for
downloading an youtube video. However youtube-dl-gui doesn't work
with the same URL.

I got this from youtube-dl-gui's log, and it seems to be the reason why
youtube-dlg doesn't work for me:

[Sun Mar 25 07:35:30 2018] Traceback (most recent call last):
[Sun Mar 25 07:35:30 2018]   File "/usr/bin/youtube-dl", line 6, in 
[Sun Mar 25 07:35:30 2018] from pkg_resources import load_entry_point
[Sun Mar 25 07:35:30 2018]   File
"/usr/lib/python2.7/dist-packages/pkg_resources/__init__.py", line
3195, in 
[Sun Mar 25 07:35:30 2018] @_call_aside
[Sun Mar 25 07:35:30 2018]   File
"/usr/lib/python2.7/dist-packages/pkg_resources/__init__.py", line
3179, in _call_aside
[Sun Mar 25 07:35:30 2018] f(*args, **kwargs)
[Sun Mar 25 07:35:30 2018]   File
"/usr/lib/python2.7/dist-packages/pkg_resources/__init__.py", line
3208, in _initialize_master_working_set
[Sun Mar 25 07:35:30 2018] working_set = WorkingSet._build_master()
[Sun Mar 25 07:35:30 2018]   File
"/usr/lib/python2.7/dist-packages/pkg_resources/__init__.py", line
681, in _build_master
[Sun Mar 25 07:35:30 2018] ws.require(__requires__)
[Sun Mar 25 07:35:30 2018]   File
"/usr/lib/python2.7/dist-packages/pkg_resources/__init__.py", line
999, in require
[Sun Mar 25 07:35:30 2018] needed =
self.resolve(parse_requirements(requirements))
[Sun Mar 25 07:35:30 2018]   File
"/usr/lib/python2.7/dist-packages/pkg_resources/__init__.py", line
885, in resolve
[Sun Mar 25 07:35:30 2018] raise DistributionNotFound(req, requirers)
[Sun Mar 25 07:35:30 2018] pkg_resources.DistributionNotFound: The
'youtube-dl==2018.3.14' distribution was not found and is required by
the application

The root of problem turns to be clear if you take a look at the package
content of youtube-dl provided by debian:

$ dpkg -L youtube-dl
...
/usr/lib/python3/dist-packages/youtube_dl-2018.3.14.egg-info
...

It has been migrated to python3. So tt is impossible for youtube-dl-gui
to import any python2 resource of youtube-dl. This GUI package only
works when user have installed youtube-dl with python2 version of pip
or some other methods alike.

Unfortunately, I guess this package would get stuck before its
transition to python3. Unless there is a simple way to use
python3 version of youtube-dl from python2 version of gui.
I'm not sure whether it's possible since I didn't look into the code.

Regards,
Lumin.


On 22 February 2018 at 09:51, Félix Sipma  wrote:
> On 2018-02-22 03:27+, Lumin wrote:
>> I built the package locally, but I did not get it working correctly
>> With a YouTube URL. It downloads nothing.
>> Could you please provide a url for test so I can make sure
>> it is working?
>>
>> I will look into this problem later.
>
> It definitely works here... Are you sure entered your urls, selected the 
> output
> format and directory, clicked "add", and then clicked "start"?



-- 
Best,

Bug#886827: RFS: youtube-dl-gui/0.4-1 [ITP]

[Félix Sipma]

On 2018-02-22 03:27+, Lumin wrote:
> I built the package locally, but I did not get it working correctly
> With a YouTube URL. It downloads nothing.
> Could you please provide a url for test so I can make sure
> it is working?
> 
> I will look into this problem later.

It definitely works here... Are you sure entered your urls, selected the output
format and directory, clicked "add", and then clicked "start"?


signature.asc
Description: PGP signature

Bug#886827: RFS: youtube-dl-gui/0.4-1 [ITP]

[Lumin]

On Fri, 16 Feb 2018 at 01:22 Félix Sipma  wrote:

>
> > This part seems unrelated to auto update functionality. Would you
> > mind splitting it to another patch?
>
> It is a part of the patch: youtube-dl-gui tries to download youtube-dl in
> 'youtubedl_path', and then launches "youtubedl_path/youtube-dl". The next
> version should be patch free, upstream agreed to add a build option to
> turn the
> update functionality off.


Got it.

>
> > Please provide an uploaded version of this package via mentors
> > so I can check it on debomatic :-)
> > (if you don't have access to debomatic)
>
> The version on mentors should be up to date, I updated it after every
> modification.
>

I built the package locally, but I did not get it working correctly
With a YouTube URL. It downloads nothing.
Could you please provide a url for test so I can make sure
it is working?

I will look into this problem later.
-- 
Best,

Bug#886827: RFS: youtube-dl-gui/0.4-1 [ITP]

[Félix Sipma]

On 2018-02-15 16:23+, Lumin wrote:
> One more problem:
> 
> 146 diff --git a/youtube_dl_gui/optionsmanager.py
> b/youtube_dl_gui/optionsmanager.py
> 147 index 794f590..baa6b83 100644
> 148 --- a/youtube_dl_gui/optionsmanager.py
> 149 +++ b/youtube_dl_gui/optionsmanager.py
> 150 @@ -276,7 +276,7 @@ class OptionsManager(object):
> 151  'username': '',
> 152  'password': '',
> 153  'video_password': '',
> 154 -'youtubedl_path': self.config_path,
> 155 +'youtubedl_path': '/usr/bin/',
> 156  'cmd_args': '',
> 157  'enable_log': True,
> 158  'log_time': True,
> 
> This part seems unrelated to auto update functionality. Would you
> mind splitting it to another patch?

It is a part of the patch: youtube-dl-gui tries to download youtube-dl in
'youtubedl_path', and then launches "youtubedl_path/youtube-dl". The next
version should be patch free, upstream agreed to add a build option to turn the
update functionality off.

> Please provide an uploaded version of this package via mentors
> so I can check it on debomatic :-)
> (if you don't have access to debomatic)

The version on mentors should be up to date, I updated it after every
modification.


signature.asc
Description: PGP signature

Bug#886827: RFS: youtube-dl-gui/0.4-1 [ITP]

[Lumin]

On 15 February 2018 at 15:33, Félix Sipma  wrote:

> I don't get the harm in having a little more verbose initial changelog, we're
> talking about 10 lines there, not a whole book... Anyway, I've just kept the
> attribution and a line mentioning the lack of python3 support.
>

>> OK. You can override it and leave a note in lintian-overrides file.
>
> I'd really prefer keeping the warning reported, so that adding the manpage in 
> not
> forgotten later :-).

OK.

 I: youtube-dl-gui: dependency-on-python-version-marked-for-end-of-life
 (Depends: python)
>>
>> I noticed that python3-wxgtk4.0 is in the NEW queue [1].
>> Do we have a chance to build on python3-wxgtk4.0 and
>> get rid of python2?
>>
>> [1] https://ftp-master.debian.org/new/wxpython4.0_4.0.1+dfsg-1.html
>
> Sorry, I don't have the resources to do the wxgtk3.0->4.0 migration myself, 
> but
> I'll see with upstream what can be done, I'll be happy to drop python2, too

One more problem:

146 diff --git a/youtube_dl_gui/optionsmanager.py
b/youtube_dl_gui/optionsmanager.py
147 index 794f590..baa6b83 100644
148 --- a/youtube_dl_gui/optionsmanager.py
149 +++ b/youtube_dl_gui/optionsmanager.py
150 @@ -276,7 +276,7 @@ class OptionsManager(object):
151  'username': '',
152  'password': '',
153  'video_password': '',
154 -'youtubedl_path': self.config_path,
155 +'youtubedl_path': '/usr/bin/',
156  'cmd_args': '',
157  'enable_log': True,
158  'log_time': True,

This part seems unrelated to auto update functionality. Would you
mind splitting it to another patch?

Please provide an uploaded version of this package via mentors
so I can check it on debomatic :-)
(if you don't have access to debomatic)


-- 
Best,

Bug#886827: Fwd: Bug#886827: RFS: youtube-dl-gui/0.4-1 [ITP]

[Lumin]

-- Forwarded message --
From: Lumin <cdlumin...@gmail.com>
Date: 15 February 2018 at 14:51
Subject: Re: Bug#886827: RFS: youtube-dl-gui/0.4-1 [ITP]
To: Félix Sipma <felix+deb...@gueux.org>


Hi,

On 15 February 2018 at 09:41, Félix Sipma <felix+deb...@gueux.org> wrote:

> Changelog: is there a problem with being more verbose? I like writing about
> specificities of a package and it's one of the places (with debian/rules) 
> where
> I did write a comment concerning python3 support (needs python3-wxgtk3.0)

Bug#886827: RFS: youtube-dl-gui/0.4-1 [ITP]

[Félix Sipma]

Control: tag -1 -moreinfo

Hi,

Thanks for your review.

Changelog: is there a problem with being more verbose? I like writing about
specificities of a package and it's one of the places (with debian/rules) where
I did write a comment concerning python3 support (needs python3-wxgtk3.0).

> compat & control
> -
> 
> * I'd recommend to use debhelper compat level 11
>  since 10 is old.

Done.


> * This package looks like a front-end of youtube-dl,
>   why is "youtube-dl" in Recommends section
>   instead of Depends section?

Done.

> Would you mind to fix the following: (lintian -EviI --pedantic)
> 
> W: youtube-dl-gui: binary-without-manpage usr/bin/youtube-dl-gui

I already asked upstream to provide a manpage.
https://github.com/MrS0m30n3/youtube-dl-gui/issues/259
I'll push the manpage with the next release.

> I: youtube-dl-gui: dependency-on-python-version-marked-for-end-of-life
> (Depends: python)

See debian/rules & debian/changelog

> P: youtube-dl-gui: image-file-in-usr-lib
> usr/lib/python2.7/dist-packages/youtube_dl_gui/data/pixmaps/arrow_down_32px.png

It's a "P", so I guess it's not so important...


signature.asc
Description: PGP signature

Bug#886827: RFS: youtube-dl-gui/0.4-1 [ITP]

[Lumin]

control: owner -1 !
control: tag -1 +moreinfo

Hi Félix,

Some comments on your package:

changelog
---

* One line is enough for the initial upload, e.g.
 "Initial release. (Closes: #753350)"

compat & control
-

* I'd recommend to use debhelper compat level 11
  since 10 is old.

* This package looks like a front-end of youtube-dl,
   why is "youtube-dl" in Recommends section
   instead of Depends section?

* Python2 faces its end of life. Does upstream support
  python3? see [1]

rules
---

You may need to add this to override_dh_auto_test target
if you bump debhelper compat to 11:

override_dh_auto_test:
ifeq (,$(filter nocheck,$(DEB_BUILD_OPTIONS)))
YOUR TEST STUFF
endif

lintian


Would you mind to fix the following: (lintian -EviI --pedantic)

W: youtube-dl-gui: binary-without-manpage usr/bin/youtube-dl-gui
I: youtube-dl-gui: dependency-on-python-version-marked-for-end-of-life
(Depends: python)
P: youtube-dl-gui: image-file-in-usr-lib
usr/lib/python2.7/dist-packages/youtube_dl_gui/data/pixmaps/arrow_down_32px.png

[1] https://www.debian.org/doc/packaging-manuals/python-policy/python3.html

-- 
Best,