Bug#917854: RFS: pygithub/1.43.3-1
[2019-02-02 00:51] Dmitry Shachnev > Hi Dmitry! > > On Thu, Jan 03, 2019 at 04:12:53AM +, Dmitry Bogatov wrote: > > Looks fine, but I do not understand following line in `debian/rules': > > > > rm -rfv debian/python3-github/usr/lib/python3.* > > > > What is removed and why same statement it is not needed for python2 > > version? Comment in `debian/rules' would be nice. > > I suggested to add that line. Quoting from my mail in #900368: > [...] > Now that Python 3.6 is no longer supported (and there is only one supported > Python 3 version), that hack can be dropped. Comment [remote it at/when] in such cases would be definitely helpful. -- Note, that I send and fetch email in batch, once every 24 hours. If matter is urgent, try https://t.me/kaction --
Bug#917854: RFS: pygithub/1.43.3-1
Hi Dmitry! On Thu, Jan 03, 2019 at 04:12:53AM +, Dmitry Bogatov wrote: > Looks fine, but I do not understand following line in `debian/rules': > > rm -rfv debian/python3-github/usr/lib/python3.* > > What is removed and why same statement it is not needed for python2 > version? Comment in `debian/rules' would be nice. I suggested to add that line. Quoting from my mail in #900368: """ - When building in the current sid, I get Lintian warnings about three files shipped in /usr/lib/python3.7/dist-packages/. That probably happens because of output of 2to3 is slightly different in Python 3.6 and 3.7 (e.g. files.items() vs. iter(files.items())), and dh_python3 does not remove the file if it does not match. I would recommend removing debian/python3-github/usr/lib/python3.* manually in debian/rules. """ Normally files should be installed in /usr/lib/python3/dist-packages (not .../python3.x/...). But if there are mulitple supported Python 3 versions and some installed files differ between these versions, dh_python3 can leave some files in /usr/lib/python3.x/dist-packages, which causes Lintian warnings and should be avoided. Now that Python 3.6 is no longer supported (and there is only one supported Python 3 version), that hack can be dropped. -- Dmitry Shachnev signature.asc Description: PGP signature
Bug#917854: RFS: pygithub/1.43.3-1
Hi Dmitry! El jue., 3 de ene. de 2019 a la(s) 01:13, Dmitry Bogatov (kact...@debian.org) escribió: > > As other folks already mentioned, you do not use CC: you already use > X-Debbugs-CC. In this particular case, email with bug number got > filtered-out as duplicate in my setup. > > Ok. The next time I will use just X-Debbugs-CC > [2018-12-31 00:16] eamanu15 > > I am looking for a sponsor for my package "pygithub" > > > > * Package name: pygithub > > Version : 1.43.3-1 > > Upstream Author : Adam Dangoor > > Vincent Jacques > > Jeremy Phelps > > * URL : https://pypi.python.org/pypi/PyGithub > > * License : LGPL-3+ > > Section : python > > > > It builds those binary packages: > > > > python-github - Access to full Github API v3 from Python2 > > python3-github - Access the full Github API v3 from Python3 > > Looks fine, but I do not understand following line in `debian/rules': > > rm -rfv debian/python3-github/usr/lib/python3.* > > What is removed and why same statement it is not needed for python2 > version? Comment in `debian/rules' would be nice. > Really I don't remember and I don't sit down in front of own system right now. > > And some very minor suggestions: > > * Standards-Version slightly outdated > * debhelper-compat style reduces redundancy > * Probably F-variables could be used to avoid repetition in >binary package descriptions? (See dpkg-substvars(5)) > Thanks for your suggestions I will work in it. > > I do not know habits of Python Modules Team, but would not it be more > apporiate for this packages to be sponsored by DD from team? I can check > basic things, but I do not know whole picture, like transitions or > reverse dependencies. > Yes, I'll keep looking. > > PS. I am glad to see that pygithub finally moved under aegis of > Python Modules Team. > Regards! -- Arias Emmanuel http://eamanu.com Github/Gitlab; @eamanu Debian: @eamanu-guest
