Your message dated Sun, 08 Apr 2018 18:23:27 +0000
with message-id <e1f5eyn-000f0i...@fasolo.debian.org>
and subject line Bug#895103: fixed in why3 0.88.3-2
has caused the Debian Bug report #895103,
regarding why3 server broken on multiple architectures
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
895103: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=895103
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: why3
Version: 0.88.3-1
Severity: grave
Tags: patch
Justification: renders package unusable
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu bionic ubuntu-patch autopkgtest

Dear Ralf,

The 0.88.3 version of why3 has been blocked for a while from being included
in the upcoming Ubuntu 18.04 release due to failing autopkgtests on multiple
architectures, e.g.:

autopkgtest [08:58:21]: test why3+alt-ergo: [-----------------------
client_connect: connection failed: Connection refused (connect,) 
(socket_name=/tmp/why3server3f8c61sock)
autopkgtest [08:58:57]: test why3+alt-ergo: -----------------------]
why3+alt-ergo        FAIL non-zero exit status 1

  
https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-bionic/bionic/arm64/w/why3/20180405_094212_aa650@/log.gz

I finally had a chance to track this down, and it turns out why3 0.88.3 is
completely broken upstream on various architectures (arm64, armhf, ppc64el,
and s390x, at least) due to wrong handling of return values from
getopt_long() that prevents why3-server from ever starting.

This issue was not seen in Debian's automated test runs because Debian only
runs autopkgtests for amd64: https://ci.debian.net/packages/w/why3/ but in
any case this would not have prevented the why3 package from being broken in
Debian testing because Debian unfortunately does not gate testing on
autopkgtest failures.

The attached patch fixes the trivial portability issue in why3, and as seen
at http://autopkgtest.ubuntu.com/packages/w/why3 the tests are now passing
for 0.88.3 on all architectures where they previously passed.

Cheers,
-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                    http://www.debian.org/
slanga...@ubuntu.com                                     vor...@debian.org
diff -Nru why3-0.88.3/debian/patches/portable-getopt.patch 
why3-0.88.3/debian/patches/portable-getopt.patch
--- why3-0.88.3/debian/patches/portable-getopt.patch    1969-12-31 
16:00:00.000000000 -0800
+++ why3-0.88.3/debian/patches/portable-getopt.patch    2018-04-06 
17:22:54.000000000 -0700
@@ -0,0 +1,19 @@
+Description: fix unportable assumptions in getopt_long() handling
+ Don't store an int in a char and expect comparison to -1 to work across
+ architectures.
+Author: Steve Langasek <steve.langa...@ubuntu.com>
+Last-Modified: 2018-04-06
+
+Index: why3-0.88.3/src/server/options.c
+===================================================================
+--- why3-0.88.3.orig/src/server/options.c
++++ why3-0.88.3/src/server/options.c
+@@ -30,7 +30,7 @@ void parse_options(int argc, char **argv
+   };
+   while (1) {
+      int option_index = 0;
+-     char c = 0;
++     int c = 0;
+      c = getopt_long (argc, argv, "j:s:",
+                       long_options, &option_index);
+      /* Detect the end of the options. */
diff -Nru why3-0.88.3/debian/patches/series why3-0.88.3/debian/patches/series
--- why3-0.88.3/debian/patches/series   2018-01-14 14:46:38.000000000 -0800
+++ why3-0.88.3/debian/patches/series   2018-04-06 17:20:54.000000000 -0700
@@ -0,0 +1 @@
+portable-getopt.patch

--- End Message ---
--- Begin Message ---
Source: why3
Source-Version: 0.88.3-2

We believe that the bug you reported is fixed in the latest version of
why3, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 895...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Ralf Treinen <trei...@debian.org> (supplier of updated why3 package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sat, 07 Apr 2018 11:54:01 +0200
Source: why3
Binary: why3 why3-coq libwhy3-ocaml-dev why3-examples why3-doc-html why3-doc-pdf
Architecture: source
Version: 0.88.3-2
Distribution: unstable
Urgency: medium
Maintainer: Debian OCaml Maintainers <debian-ocaml-maint@lists.debian.org>
Changed-By: Ralf Treinen <trei...@debian.org>
Description:
 libwhy3-ocaml-dev - OCaml librariries for why3 (dev)
 why3       - Software verification platform
 why3-coq   - Coq support for the why3 verification platform
 why3-doc-html - HTML Documentation of the why3 verification platform
 why3-doc-pdf - PDF Documentation of the why3 verification platform
 why3-examples - Examples for the why3 verification platform
Closes: 895103
Changes:
 why3 (0.88.3-2) unstable; urgency=medium
 .
   * Standards-version 4.1.4 (no change).
   * d/copyright: https in format specification
   * Add patch getopt_long-return-value which fixes a portability issue
     (closes: #895103). Thanks a lot to Steve Langasek for the patch!
Checksums-Sha1:
 a0a52ac4900b659279165f2b4cd85782d74f8b26 2642 why3_0.88.3-2.dsc
 93f773363b95517349ce168feadc75b7876fb56d 12992 why3_0.88.3-2.debian.tar.xz
 2e5de66ef47ae1a5498f138bcd1472fcd6665311 12338 why3_0.88.3-2_source.buildinfo
Checksums-Sha256:
 e1e40b89064471adc699c9025abd3385fc3d0c0df8b0a2d8f25b3e7bcead9e9f 2642 
why3_0.88.3-2.dsc
 ba3e27a855241da1fda3a153b26305e186466c690b44aa7226e3a39cb9e89388 12992 
why3_0.88.3-2.debian.tar.xz
 7acdc9491767d77e3666f48dcd2f800987ac7a508484400bb39905d6cd590e1a 12338 
why3_0.88.3-2_source.buildinfo
Files:
 394bc89c8c1f2e2ba5cc3b3f664bde90 2642 math optional why3_0.88.3-2.dsc
 5f278b38b6f1eeb4908fbcfd86c42f3b 12992 math optional 
why3_0.88.3-2.debian.tar.xz
 bf816039cbc6a72599bf9f5afb5ff15e 12338 math optional 
why3_0.88.3-2_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEAgVIKeEtDyqOZI5idFxHZtTKzf8FAlrKWQ8ACgkQdFxHZtTK
zf8dlRAAsK6PhQz5yqkuje7A29D+TdfBtXmzp2ZD/apWhkPvfeBMCYSzt0N3mgQW
tpNDEJ/OlrHdPR9LBKNPATG43bTTzfgt4qhPAY3LTn1iVfOyQF8IOS9JPhMPsgx+
R11ZAEZeSPI+orjKJwiViNLQ3kDWQ2LxFFtYHPDzCetwrDsEdYwqBb//edbvTN0f
k8VuN0REdmAH+NrfP0ZWJaAuYdtIezbZSCE9MDZAIu2BLFygpqAeGzS0G75P1ce3
HTjlt0W9AKd4OLcd4oPg6Ue59o03MKOGGyuNTabZfnu+2bul60Hl7RvvhUcEVx5x
tBUdSB49qgv1/PySW56qo31CWx1XkSgE6LB8vnx8rU1XF8Pix74M9aAcFSkzAteT
1Lt29fl7XCPWOHH8pqtMaRzVxe7X2wy10WD4H8EiGVtC3N2miBngV1RG8P7UM6F1
n0OC+yqkEkAP2n5z4sHhaHn9d4n/QdUTGE0DVCIe5NIqBbXX/Df8jqBjTLqLPnkk
VzwO5mgMDUfUzpXPHRMNzU1g36mC+7mqTPwgfBk8vNT14lTUlHTPXL7Riuwel80X
lQJzLxuV866LBxISsU2d+wNbotPI0CjID6HW8fufL8x70nAI8zgbx3Efv+NJq0dL
Uy6D4sGsr/m1fxPF1JoSlmZteEgJWL3Yx95Pb/bx/+08DxBH0Ig=
=H4z8
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to