Re: RFS: mwic 0.7.4-1

2018-03-24 Thread Georg Faerber
On 18-03-25 11:05:25, Paul Wise wrote: > On Wed, Mar 21, 2018 at 8:43 PM, Paul Wise wrote: > > I'll take a look, probably on Friday. > > Uploaded to NEW, thanks for your contribution. Thanks a lot, will tag accordingly once it hits unstable. > If you are so inclined, I would appreciated a

Re: RFS: mwic 0.7.4-1

2018-03-24 Thread Paul Wise
On Wed, Mar 21, 2018 at 8:43 PM, Paul Wise wrote: > I'll take a look, probably on Friday. Uploaded to NEW, thanks for your contribution. If you are so inclined, I would appreciated a commit (or patch) adding mwic support to check-all-the-things:

Re: RFS: mwic 0.7.4-1

2018-03-21 Thread Paul Wise
On Wed, Mar 21, 2018 at 6:02 PM, Georg Faerber wrote: > To put it differently, especially regarding this upstream metadata > check: If someone opens a bug against lintian to add a new check, does > "this new check" needs to be backed up by some general consensus within > the project? Is there

Re: RFS: mwic 0.7.4-1

2018-03-21 Thread Georg Faerber
Hi, On 18-03-21 11:36:58, Paul Wise wrote: > On Wed, Mar 21, 2018 at 1:11 AM, Georg Faerber wrote: > >> doc/mwic.1 and tests/coverage are generated files, they should be > >> removed from the upstream VCS and tarballs and be always built from > >> source. If upstream refuses, you should remove

Re: RFS: mwic 0.7.4-1

2018-03-20 Thread Paul Wise
On Wed, Mar 21, 2018 at 1:11 AM, Georg Faerber wrote: > Thanks a lot for your review, and sorry for not responding earlier, too > much stuff on my table: There is no need to apologise for being busy :) > On 18-03-18 11:33:59, Paul Wise wrote: >> The copyright years are missing 2012, I'm not

Re: RFS: mwic 0.7.4-1

2018-03-20 Thread Georg Faerber
Hi, On 18-03-20 18:11:50, Georg Faerber wrote: > > > Yeah, I've used this as well, but in this case it's not that > > > helpful as it finds the code defining the error [2]. > > > > I'd guess this is the source of the line you quoted: > > > >

Re: RFS: mwic 0.7.4-1

2018-03-20 Thread Georg Faerber
On 18-03-20 20:21:20, Dmitry Shachnev wrote: > On Mon, Mar 19, 2018 at 11:31:07PM +0100, Georg Faerber wrote: > > On 18-03-20 00:46:16, Dmitry Shachnev wrote: > > > On Sat, Mar 17, 2018 at 10:49:26AM +0100, Georg Faerber wrote: > > > > Also, AFAIK, debian/tests/control is obsolete nowadays if > >

Re: RFS: mwic 0.7.4-1

2018-03-20 Thread Dmitry Shachnev
On Mon, Mar 19, 2018 at 11:31:07PM +0100, Georg Faerber wrote: > On 18-03-20 00:46:16, Dmitry Shachnev wrote: > > On Sat, Mar 17, 2018 at 10:49:26AM +0100, Georg Faerber wrote: > > > Also, AFAIK, debian/tests/control is obsolete nowadays if > > > debian/control contains Testsuite:. > > > > This is

Re: RFS: mwic 0.7.4-1

2018-03-20 Thread Georg Faerber
Hi pabs, Thanks a lot for your review, and sorry for not responding earlier, too much stuff on my table: On 18-03-18 11:33:59, Paul Wise wrote: > The copyright years are missing 2012, I'm not sure if the ftp-masters > would reject the package on that basis. I've referred to the upstream git

Re: RFS: mwic 0.7.4-1

2018-03-20 Thread Gregor Riepl
> autopkgtest (debian/tests/) is a form of as-installed testing, which takes > the packages that were built, installs them in a relatively complete and > realistic environment (typically a lxc container or a qemu/kvm virtual > machine) and runs further tests there. Sometimes these tests just

Re: RFS: mwic 0.7.4-1

2018-03-20 Thread Simon McVittie
On Tue, 20 Mar 2018 at 12:18:39 +0100, Gregor Riepl wrote: > > In case I've misunderstood you, and you're referring to unit tests > > shipped debian/tests/*, than yes, I agree. :) > > As far as I understand, these tests are executed by the package builder after > the upstream build script has

Re: RFS: mwic 0.7.4-1

2018-03-20 Thread Gregor Riepl
> In case I've misunderstood you, and you're referring to unit tests > shipped debian/tests/*, than yes, I agree. :) As far as I understand, these tests are executed by the package builder after the upstream build script has finished. They're meant as a sort of integration test, i.e. "does this

Re: RFS: mwic 0.7.4-1

2018-03-19 Thread Georg Faerber
Hi Dimitry, On 18-03-20 00:46:16, Dmitry Shachnev wrote: > On Sat, Mar 17, 2018 at 10:49:26AM +0100, Georg Faerber wrote: > > Also, AFAIK, debian/tests/control is obsolete nowadays if > > debian/control contains Testsuite:. > > This is not true. With autodep8 you can test only whether a package

Re: RFS: mwic 0.7.4-1

2018-03-19 Thread Dmitry Shachnev
On Sat, Mar 17, 2018 at 10:49:26AM +0100, Georg Faerber wrote: > Also, AFAIK, debian/tests/control is obsolete nowadays if debian/control > contains Testsuite:. This is not true. With autodep8 you can test only whether a package can be imported. If you want to run some actual unit tests, you

Re: RFS: mwic 0.7.4-1

2018-03-17 Thread Paul Wise
On Sat, Mar 17, 2018 at 5:49 PM, Georg Faerber wrote: > Thanks a lot; sure, see [1]. These things block the upload: The copyright years are missing 2012, I'm not sure if the ftp-masters would reject the package on that basis. I require these things to be fixed before I would sponsor the

Re: RFS: mwic 0.7.4-1

2018-03-17 Thread Georg Faerber
Hi Paul, On 18-03-17 11:28:51, Paul Wise wrote: > On Sat, Mar 17, 2018 at 5:29 AM, Georg Faerber wrote: > > I'm searching a sponsor for the initial upload of mwic. > > I'll be happy to sponsor this, but I will need you to upload the > source package to mentors.d.n first. Thanks a lot; sure, see

Re: RFS: mwic 0.7.4-1

2018-03-16 Thread Paul Wise
On Sat, Mar 17, 2018 at 5:29 AM, Georg Faerber wrote: > I'm searching a sponsor for the initial upload of mwic. I'll be happy to sponsor this, but I will need you to upload the source package to mentors.d.n first. > - Running autopkgtest gives "SKIP no tests in this package". I've > searched

RFS: mwic 0.7.4-1

2018-03-16 Thread Georg Faerber
Hi all, I'm searching a sponsor for the initial upload of mwic. Currently, the repo is at [1], I've pushed into the debian/0.7.4-1. Some further notes: - Could someone move the repo into the python-team namespace? I'm not able to do so, yet. - Running autopkgtest gives "SKIP no tests in this