Re: Bug#900368: RFS: pygithub/1.40a3-1 [ITP]

2018-07-04 Thread eamanu15
Hello Dmitry,

I just pushed the update the package to Salsa. I pushed the PyGithub_1.40
version.

Regards!
Emmanuel

El mié., 4 de jul. de 2018 a la(s) 10:41, eamanu15 <
emmanuelaria...@gmail.com> escribió:

> Ok! Thanks !!!
>
> El mié., 4 de jul. de 2018 a la(s) 09:13, Dmitry Shachnev <
> mity...@debian.org> escribió:
>
>> On Wed, Jul 04, 2018 at 07:09:20AM -0300, eamanu15 wrote:
>> > Hello Dmitry,
>> >
>> > I have the fixes almost already, Just, I have a doubt in this point:
>> >
>> > > - When building in the current sid, I get Lintian warnings about
>> three files
>> > >   shipped in /usr/lib/python3.7/dist-packages/.
>> >
>> > To fix this problem I could add in the d/rules the next line:
>> >
>> > override_dh_auto_install:
>> > dh_auto_install
>> > find ./debian/python3-github/usr/lib/ -type f -name python3.*
>> -delete
>> >
>> > isn't?
>>
>> It is a directory, not a file. Also you need to do it after dh_python3
>> runs.
>> So better use this:
>>
>> override_dh_python3:
>> dh_python3
>> rm -rfv debian/python3-github/usr/lib/python3.*
>>
>> --
>> Dmitry Shachnev
>>
> --
> Arias Emmanuel
> https://www.linkedin.com/in/emmanuel-arias-437a6a8a
> http://eamanu.com
>
-- 
Arias Emmanuel
https://www.linkedin.com/in/emmanuel-arias-437a6a8a
http://eamanu.com


Re: Bug#900368: RFS: pygithub/1.40a3-1 [ITP]

2018-07-04 Thread eamanu15
Ok! Thanks !!!

El mié., 4 de jul. de 2018 a la(s) 09:13, Dmitry Shachnev <
mity...@debian.org> escribió:

> On Wed, Jul 04, 2018 at 07:09:20AM -0300, eamanu15 wrote:
> > Hello Dmitry,
> >
> > I have the fixes almost already, Just, I have a doubt in this point:
> >
> > > - When building in the current sid, I get Lintian warnings about three
> files
> > >   shipped in /usr/lib/python3.7/dist-packages/.
> >
> > To fix this problem I could add in the d/rules the next line:
> >
> > override_dh_auto_install:
> > dh_auto_install
> > find ./debian/python3-github/usr/lib/ -type f -name python3.* -delete
> >
> > isn't?
>
> It is a directory, not a file. Also you need to do it after dh_python3
> runs.
> So better use this:
>
> override_dh_python3:
> dh_python3
> rm -rfv debian/python3-github/usr/lib/python3.*
>
> --
> Dmitry Shachnev
>
-- 
Arias Emmanuel
https://www.linkedin.com/in/emmanuel-arias-437a6a8a
http://eamanu.com


Re: Bug#900368: RFS: pygithub/1.40a3-1 [ITP]

2018-07-04 Thread Dmitry Shachnev
On Wed, Jul 04, 2018 at 07:09:20AM -0300, eamanu15 wrote:
> Hello Dmitry,
>
> I have the fixes almost already, Just, I have a doubt in this point:
>
> > - When building in the current sid, I get Lintian warnings about three files
> >   shipped in /usr/lib/python3.7/dist-packages/.
>
> To fix this problem I could add in the d/rules the next line:
>
> override_dh_auto_install:
> dh_auto_install
> find ./debian/python3-github/usr/lib/ -type f -name python3.* -delete
>
> isn't?

It is a directory, not a file. Also you need to do it after dh_python3 runs.
So better use this:

override_dh_python3:
dh_python3
rm -rfv debian/python3-github/usr/lib/python3.*

--
Dmitry Shachnev


signature.asc
Description: PGP signature


Re: Bug#900368: RFS: pygithub/1.40a3-1 [ITP]

2018-07-04 Thread eamanu15
Hello Dmitry,

I have the fixes almost already, Just, I have a doubt in this point:

- When building in the current sid, I get Lintian warnings about three files
>   shipped in /usr/lib/python3.7/dist-packages/.
>
>   That probably happens because of output of 2to3 is slightly different in
>   Python 3.6 and 3.7 (e.g. files.items() vs. iter(files.items())), and
>   dh_python3 does not remove the file if it does not match.
>
>   I would recommend removing debian/python3-github/usr/lib/python3.*
> manually
>   in debian/rules. Keeping debian-python@ in Cc in case someone has a
> better
>   idea.
>

To fix this problem I could add in the d/rules the next line:

override_dh_auto_install:
dh_auto_install
find ./debian/python3-github/usr/lib/ -type f -name python3.* -delete

isn't?

Regards!
Thanks!
Emmanuel
-- 
Arias Emmanuel
https://www.linkedin.com/in/emmanuel-arias-437a6a8a
http://eamanu.com


Re: How to enable Python3 for python-freecontact

2018-07-04 Thread Andreas Tille
Dear Lumin,

On Wed, Jul 04, 2018 at 02:26:36AM +, Lumin wrote:
> I'm not sure whether there is a better way to workaround this,
> but the following solution works fine
> 
> 
> -libraries = ['freecontact', 'boost_python'])]
> +libraries = ['freecontact', 
> 'boost_python-py%d%d'%(sys.version_info[0], sys.version_info[1])])]
> 
> 
> works for all python versions, i.e. 2.7, 3.6, 3.7 .

Works perfectly for building the modules.

Unfortunately the test does not work for Python3.  If I try inside
pbuilder chroot:

root:/build/python-freecontact-1.1# 
PYTHONPATH=.pybuild/cpython3_3.6_freecontact/build/ python3.6 test/test01.py 
Traceback (most recent call last):
  File "test/test01.py", line 87, in 
test_main()
  File "test/test01.py", line 83, in test_main
test_support.run_unittest(MyTestCase1
AttributeError: module 'test.test_support' has no attribute 'run_unittest'


This also happens if I build without testing and after installing
the python3-freecontact package:


/python-freecontact(master) $ python3 test/test01.py
Traceback (most recent call last):
  File "test/test01.py", line 87, in 
test_main()
  File "test/test01.py", line 83, in test_main
test_support.run_unittest(MyTestCase1
AttributeError: module 'test.test_support' has no attribute 'run_unittest'


Any clue how to work around this?

Kind regards

  Andreas.
 

-- 
http://fam-tille.de