Re: RFS: python-click-log/0.3.2-1 -- Logging integration for Click - Python 3.x
Hi Nilesh (2021.06.05_15:21:22_+) > > * What about adding an autopkgtest? > > The test is running during build time.[1] I don't think running the same > thing as autopkgtest does a very significant improvement. I think there's generally an advantage in running the same upstream tests at build time, as well as in an autopkgtest: 1. If something regresses the test suite, it'll block migration of that package into testing. 2. It verifies that the package behaves correctly, as installed. (This can mean that you need to disable part of the test-suite, that can't handle the installed layout.) Yes, it's also good to have other kinds of tests in autopkgtests, that verify installed behaviour (e.g. calling --help on an executable, to see that it can start-up, and smoke testing library public interfaces). SR -- Stefano Rivera http://tumbleweed.org.za/ +1 415 683 3272
Re: RFS: python-click-log/0.3.2-1 -- Logging integration for Click - Python 3.x
On 6/5/21 8:04 PM, Emmanuel Arias wrote: > Hi, > > I'm not DD, but I send you some review, to gain time: > > * d/changelog says: `Bump debhelper from old 10 to 12.` but actuall> > debhelper-compat version is 13. > * Please use UNRELEASED instead of unstable, that can be confused. Fixed > * What about enable salsa-ci? Enabled > * What about adding an autopkgtest? The test is running during build time.[1] I don't think running the same thing as autopkgtest does a very significant improvement. @Fabrice, more review: * The pristine tar contained .tar.gz.*, it should instead contain .orig.tar.gz for origtargz both for the sake of consistency and for origtargz to run fine * We are in freeze time, and a new version upload unless absolutely necessary isn't appropriate[2]. This package does not seem to have any (RC) bug or affecting any package that a version bump would be desired. Hence, this should be uploaded after bullseye release. Feel free to ping me then, and I'll happily sponsor. Also, please take a look at my commits in salsa. Thanks a lot for your work! [1]: https://salsa.debian.org/python-team/packages/python-click-log/-/blob/master/debian/rules#L13 [2]: https://release.debian.org/testing/freeze_policy.html Nilesh signature.asc Description: OpenPGP digital signature
Re: RFS: python-click-log/0.3.2-1 -- Logging integration for Click - Python 3.x
Hi, I'm not DD, but I send you some review, to gain time: * d/changelog says: `Bump debhelper from old 10 to 12.` but actually debhelper-compat version is 13. * Please use UNRELEASED instead of unstable, that can be confused. * What about enable salsa-ci? * What about adding an autopkgtest? Cheers, El vie, 4 de jun. de 2021 a la(s) 20:30, Fabrice Bauzac-Stehly ( n...@mykolab.com) escribió: > Package: sponsorship-requests > Severity: normal > > Dear mentors, > > I am looking for a sponsor for my package "python-click-log": > > * Package name: python-click-log >Version : 0.3.2-1 >Upstream Author : [fill in name and email of upstream] > * URL : https://github.com/click-contrib/click-log > * License : Expat > * Vcs : > https://salsa.debian.org/python-team/packages/python-click-log >Section : python > > It builds those binary packages: > > python3-click-log - Logging integration for Click - Python 3.x > > To access further information about this package, please visit the > following URL: > > https://mentors.debian.net/package/python-click-log/ > > Alternatively, one can download the package with dget using this command: > > dget -x > https://mentors.debian.net/debian/pool/main/p/python-click-log/python-click-log_0.3.2-1.dsc > > Changes since the last upload: > > python-click-log (0.3.2-1) unstable; urgency=medium > . >[ Debian Janitor ] >* Bump debhelper from old 10 to 12. >* Set upstream metadata fields: Bug-Database, Repository, Repository- > Browse. >* Remove constraints unnecessary since stretch: > + Build-Depends: Drop versioned constraint on dh-python. > . >[ Ondřej Nový ] >* d/control: Update Maintainer field with new Debian Python Team > contact address. >* d/control: Update Vcs-* fields with new Debian Python Team Salsa > layout. > . >[ Fabrice Bauzac-Stehly ] >* New upstream release. >* Upgrade d/watch to version 4. >* Upgrade the Standards-Version to 4.5.1. >* Declare Rules-Requires-Root: no. > > Best regards > > -- > Fabrice Bauzac-Stehly > PGP 01EEACF8244E9C14B551C5256ADA5F189BD322B6 > >
