On 07/10/2016 03:34 AM, Brian May wrote:
> Moved to debian-python list from bug report.
>
> Dmitry Shachnev writes:
>
>> You say that we can read some flag set by dh-python. However, dh-python
>> (aka pybuild) already sets http{,s}_proxy environment variables which
>> disable network access for Sphinx. So packages using dh-python are already
>> safe.
>
> Not sure I understand how dh-python / pybuild help with this problem.
It doesn't, it simply hides the issue.
Also, sometimes exporting http{s,}_proxy simply breaks unit testing (I
did have such case, yes...). So that's not really a fit-all solution either.
> I thought the recommended way to deal with building documentation was
> something like this in debian/rules:
>
> override_dh_auto_build:
> dh_auto_build
> PYTHONPATH=. sphinx-build -b html -N Doc/ Doc/.build/html
I find this not the top-noch way. Here's what I do:
override_dh_sphinxdoc:
ifeq (,$(findstring nodocs, $(DEB_BUILD_OPTIONS)))
PYTHONPATH=. sphinx-build -b html doc/source \
debian/python-foo-doc/usr/share/doc/python-foo-doc/html
dh_sphinxdoc
endif
IMO, that's better because you don't need to clean Doc/.build/html.
Also, the dh_auto_build isn't the correct target. Some derivative may
well choose not to implement dh_sphinxdoc (for example, for small
systems where they don't want docs), and here, you're making their lives
miserable.
Cheers,
Thomas Goirand (zigo)
