Re: DPMT membership request

2016-08-08 Thread Thomas Goirand
On 08/08/2016 01:06 PM, Filip Pytloun wrote:
>> 1.c. Using update-alternatives for /usr/bin
>>
>> Instead of doing:
>>  rm -rf debian/python-aptly/usr/bin
>>  mkdir -p debian/aptly-publisher/usr
>>  mv debian/python3-aptly/usr/bin debian/aptly-publisher/usr/
>>
>> you can have a look at using pkgos-alternative-bin from
>> openstack-pkg-tools. This will generate postinst, prerm and postrm for
>> you, so it handles /usr/bin with python2 or python3 alternatives.
>> Optionally, you can fix py3 as higher priority in the postinst files if
>> you prefer.
> 
> I was thinking about using alternatives vs forcing python3 (didn't know
> pkgos-alternative-bin anyway or any reference package for this case) but
> decided to force Python 3 as it should be Debian's default.

I very much agree that Python 3 should be the default, however, IMO
there's not much point supporting Python 2 and not providing the needed
command line tools. To me, either you support Py2 fully, or you just
don't support it at all. YMMV I guess.

>> 2/ debian/control
>> =
>> 2.a X-Python{3,}-Version headers
>>
>> Please remove X-Python-Version: >= 2.6 and X-Python3-Version: >= 3.2
>> stuff. Jessie has Python 2.6 and Python 3.4, so these are completely
>> useless. It isn't even needed in oldstable!!!
> 
> Good, didn't know it's not needed now.

Well, it may sometimes be needed. For example, let's say Stretch is
released, and at some point, Buster gets Python 3.6. Some packages may
support only that, and then you may need X-Python3-Version: >= 3.6. But
if we have already 3.4, and you're declaring "I'm supporting only >=
3.2", then there is no point.

Cheers,

Thomas Goirand (zigo)

P.S: Please don't CC me, I'm subscribed, and if you didn't know, it's
the rule in Debian to not CC.



Re: Maintenance of new Flask extensions

2016-08-08 Thread Piotr Ożarowski
[Dominik George, 2016-08-08]
> Hi DPMT,
> 
> I would like to package and maintain some Flask extensions. Flask, a web 
> micro-framework, and some extensions for it are already available in Debian 
> and under team maintenance of the DPMT.
> 
> I would initially like to add these two extensions:
> 
>   Flask-Restless
>   Flask-Compress
>   Flask-LDAPConn

great!

> Please tell me if it is ok to ask for team membership on Alioth ☺! My 
> username 
> there is natureshadow-guest.

if you read and accept our policy, I will add you to the team in few
days (if nobody objects)
-- 
Piotr Ożarowski Debian GNU/Linux Developer
www.ozarowski.pl  www.griffith.cc   www.debian.org
GPG Fingerprint: 1D2F A898 58DA AF62 1786 2DF7 AEF6 F1A2 A745 7645



Re: DPMT membership request

2016-08-08 Thread Piotr Ożarowski
[Filip Pytloun, 2016-08-04]
> I would like to join to be able to package some software I am interested
> in (Openstack-related + various python tools that I (co-)authored).

Welcome :)
-- 
Piotr Ożarowski Debian GNU/Linux Developer
www.ozarowski.pl  www.griffith.cc   www.debian.org
GPG Fingerprint: 1D2F A898 58DA AF62 1786 2DF7 AEF6 F1A2 A745 7645



Re: Joining

2016-08-08 Thread Piotr Ożarowski
[Tristan Seligmann, 2016-08-08]
> I think this email slipped through the cracks; could one of the alioth
> admins look at this?

done. Welcome and sorry for forgetting about this one.
-- 
Piotr Ożarowski Debian GNU/Linux Developer
www.ozarowski.pl  www.griffith.cc   www.debian.org
GPG Fingerprint: 1D2F A898 58DA AF62 1786 2DF7 AEF6 F1A2 A745 7645



DPMT membership request

2016-08-08 Thread Felix Krull
Hi,

I'd like to join the DPMT to maintain quark-sphinx-theme (ITP at [1])
which is going to be needed as a build dependency for the next
SpeedCrunch version [2].

I have read the policy [3] and accept it. My Alioth login is fkrull-guest.

Regards,
Felix

[1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=831907
[2] https://tracker.debian.org/pkg/speedcrunch
[3] https://python-modules.alioth.debian.org/policy.html



Maintenance of new Flask extensions

2016-08-08 Thread Dominik George
Hi DPMT,

I would like to package and maintain some Flask extensions. Flask, a web 
micro-framework, and some extensions for it are already available in Debian 
and under team maintenance of the DPMT.

I would initially like to add these two extensions:

  Flask-Restless
  Flask-Compress
  Flask-LDAPConn

Also, I would like to help fix open bugs in existing Flask packages.

I would base my packages off of existing ones in order to enable the team to 
co-maintain the packages.

Apart from these new packages, I maintain a few other packages in Debian, in 
cooperation with several DDs.

If the DPMT is willing to co-maintain the new packages, I would like to keep 
the package repositories and the like in DPMT from the beginning.

Please tell me if it is ok to ask for team membership on Alioth ☺! My username 
there is natureshadow-guest.

Cheers,
Nik

-- 
PGP-Fingerprint: 3C9D 54A4 7575 C026 FB17  FD26 B79A 3C16 A0C4 F296

Dominik George · Mobil: +49-1520-1981389

Teckids e.V. · FrOSCon e.V. · OpenRheinRuhr e.V.
Fellowship of the FSFE · Piratenpartei Deutschland
Opencaching Deutschland e.V. · Debian Contributor

LPIC-3 Linux Enterprise Professional (Security)


signature.asc
Description: This is a digitally signed message part.


Re: Joining

2016-08-08 Thread Tristan Seligmann
Hi all,

I think this email slipped through the cracks; could one of the alioth
admins look at this?

(I have been working with / sponsoring Richard on such packages as
python-trezor)

On Tue, 2 Feb 2016 at 22:30 Richard Ulrich  wrote:

> Hi,
>
> I would like to join the team, in order to maintain my current packages
> within the team.
>
> My alioth login is : ulrichard-guest
>
> I have read the policy and accept it.
>
>
> Rgds
> Richard
>
> --
> Meine Kontaktdetails sind immer aktuell in der NameCoin blockchain mit
> der Kennung: id/ulrichard
> Teile davon sieht man mit folgendem Link:
> https://nameid.org/?name=ulrichard
> Bitte schicken Sie mir wenn möglich PGP/GPG verschlüsselte Nachrichten.
>
>


Re: DPMT membership request

2016-08-08 Thread Filip Pytloun
Hello Zigo,

thank you very much for your feedback!
More inline:

> 1/ debian/rules
> ===
> 1.a. Simplifying dpkg-parsechangelog
> 
> You can replace your PKG = line with:
> 
> PKG = $(shell dpkg-parsechangelog -SSource)
> 
> The same way, you can simplify VER = using dpkg-parsechangelog -SVersion
> 
> Note that I'm not adding a space after the -S, as this would add an
> incompatibility with Ubuntu trusty (and there's no reason why you
> wouldn't care as this is a gratuitous fix for it).

I found this at https://wiki.debian.org/onlyjob/get-orig-source
Didn't know these shortcuts anyway, fixing.

> 
> 1.b. Adding unnecessary parenthesis
> 
> Why are you adding parenthesis to the command:
> PYTHONPATH=. help2man

Yes, that should not be needed, removing.

> 
> ?
> 
> 1.c. Using update-alternatives for /usr/bin
> 
> Instead of doing:
>   rm -rf debian/python-aptly/usr/bin
>   mkdir -p debian/aptly-publisher/usr
>   mv debian/python3-aptly/usr/bin debian/aptly-publisher/usr/
> 
> you can have a look at using pkgos-alternative-bin from
> openstack-pkg-tools. This will generate postinst, prerm and postrm for
> you, so it handles /usr/bin with python2 or python3 alternatives.
> Optionally, you can fix py3 as higher priority in the postinst files if
> you prefer.

I was thinking about using alternatives vs forcing python3 (didn't know
pkgos-alternative-bin anyway or any reference package for this case) but
decided to force Python 3 as it should be Debian's default.

> 
> 2/ debian/control
> =
> 2.a X-Python{3,}-Version headers
> 
> Please remove X-Python-Version: >= 2.6 and X-Python3-Version: >= 3.2
> stuff. Jessie has Python 2.6 and Python 3.4, so these are completely
> useless. It isn't even needed in oldstable!!!

Good, didn't know it's not needed now.

> 
> 2.b Build-Depends-Indep:
> 
> Since both all of the generated binaries are Arch: all, you can put some
> of the Build-Depends into Build-Depends-Indep: like this:
> 
> Build-Depends: debhelper (>= 9),
>dh-python,
>help2man,
>python-all,
>python-setuptools,
>python3-all,
>python3-setuptools
> Build-Depends-Indep: python-requests,
>  python-yaml,
> 
> I was also very much surprised to not see python3-requests and
> python3-yaml in your build-depends. Aren't you running Py3 tests too?

Will fix this.

> 
> 2.c Short and long description
> 
> Your short description for python-aptly and python3-aptly shouldn't be
> that different. Also, upstream short desc is nicer. I'd suggest:
> 
> Package: python-aptly
> Description: REST API client  and tooling - Python 2.7
> [...]
> Package: python3-aptly
> Description: REST API client  and tooling - Python 3.x
> 
> 2.d Long desc for Package: aptly-publisher
> 
> The long desc start by an empty line. This isn't nice. Also, please
> consider longer long descriptions. 2 lines isn't enough, at least 5
> would be nicer. Upstream has a lot more info which you can pickup.

Fixed.

> 
> 3/ Final word
> 
> I hope this helps. Thanks for your contribution to Debian.

Helps a lot, thank you again!

> 
> Cheers,
> 
> Thomas Goirand (zigo)
> 


signature.asc
Description: Digital signature


Re: DPMT membership request

2016-08-08 Thread Thomas Goirand
On 08/04/2016 05:35 PM, Filip Pytloun wrote:
> Hello DPMT,
> 
> I would like to join to be able to package some software I am interested
> in (Openstack-related + various python tools that I (co-)authored).
> 
> As the first package, I am working on packaging of python-aptly:
> https://github.com/fpytloun/debian-python-aptly
> 
> I have read and agree the policy.
> My Alioth login is fpytloun-guest.
> 
> Thank you,
> Filip

Hi Filip,

A few things about your packaging.

1/ debian/rules
===
1.a. Simplifying dpkg-parsechangelog

You can replace your PKG = line with:

PKG = $(shell dpkg-parsechangelog -SSource)

The same way, you can simplify VER = using dpkg-parsechangelog -SVersion

Note that I'm not adding a space after the -S, as this would add an
incompatibility with Ubuntu trusty (and there's no reason why you
wouldn't care as this is a gratuitous fix for it).

1.b. Adding unnecessary parenthesis

Why are you adding parenthesis to the command:
PYTHONPATH=. help2man

?

1.c. Using update-alternatives for /usr/bin

Instead of doing:
rm -rf debian/python-aptly/usr/bin
mkdir -p debian/aptly-publisher/usr
mv debian/python3-aptly/usr/bin debian/aptly-publisher/usr/

you can have a look at using pkgos-alternative-bin from
openstack-pkg-tools. This will generate postinst, prerm and postrm for
you, so it handles /usr/bin with python2 or python3 alternatives.
Optionally, you can fix py3 as higher priority in the postinst files if
you prefer.

2/ debian/control
=
2.a X-Python{3,}-Version headers

Please remove X-Python-Version: >= 2.6 and X-Python3-Version: >= 3.2
stuff. Jessie has Python 2.6 and Python 3.4, so these are completely
useless. It isn't even needed in oldstable!!!

2.b Build-Depends-Indep:

Since both all of the generated binaries are Arch: all, you can put some
of the Build-Depends into Build-Depends-Indep: like this:

Build-Depends: debhelper (>= 9),
   dh-python,
   help2man,
   python-all,
   python-setuptools,
   python3-all,
   python3-setuptools
Build-Depends-Indep: python-requests,
 python-yaml,

I was also very much surprised to not see python3-requests and
python3-yaml in your build-depends. Aren't you running Py3 tests too?

2.c Short and long description

Your short description for python-aptly and python3-aptly shouldn't be
that different. Also, upstream short desc is nicer. I'd suggest:

Package: python-aptly
Description: REST API client  and tooling - Python 2.7
[...]
Package: python3-aptly
Description: REST API client  and tooling - Python 3.x

2.d Long desc for Package: aptly-publisher

The long desc start by an empty line. This isn't nice. Also, please
consider longer long descriptions. 2 lines isn't enough, at least 5
would be nicer. Upstream has a lot more info which you can pickup.

3/ Final word

I hope this helps. Thanks for your contribution to Debian.

Cheers,

Thomas Goirand (zigo)



Re: pep8 renamed to pycodestyle

2016-08-08 Thread Ondrej Novy
Hi,

what do you think about this:
https://anonscm.debian.org/cgit/python-modules/packages/pep8.git/commit/?id=655e6f631fc854c51f48f142e58bdb6b4af8494f

With this change we can make slow transition pep8 -> pycodestyle without
breaking current pep8 users.

BTW: pycodestyle is still in NEW, so don't upload :)

Thanks.

-- 
Best regards
 Ondřej Nový


updating python-tidylib for libtidy5

2016-08-08 Thread Mattia Rizzolo
some weeks ago a transition happened from libtidy-0.99-0 (provided by
src:tidy) to libtidy5 (provided by src:tidy-html5).

The only actual issue arised with src:python-tidylib:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=829178
https://github.com/countergram/pytidylib/issues/9
https://github.com/countergram/pytidylib/issues/13

upstream looks quite disinterested to the issue, so I wonder whether
some of you have some spare tuit to look at this issue.

If you manage something please do upload python-tidylib fixing this
issue, so we care remove src:tidy from the archive.

-- 
regards,
Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540  .''`.
more about me:  https://mapreri.org : :'  :
Launchpad user: https://launchpad.net/~mapreri  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-


signature.asc
Description: PGP signature