Re: python3 for pysrs

2017-07-16 Thread Ben Finney
Sandro Knauß  writes:

> I'm currently porting pysrs to python3 and sofar I got all tests
> running for python2 and python3 *yeah*.

Congratulations!

> But the porting was mostly adding encode()/ decode() to many parts of
> the module. And I'm unsure, if the API is now in a good shape, or if
> it is mostly unusable for users

This is work you're doing in collaboration with the ‘pysrs’ upstream
developers, right? You are aiming to get users to test this, and get it
into a release, before doing any of this in Debian. Is that correct?

I think that porting a work to Python 3 is not appropriate for a Debian
patch. That should be done only in a maintained upstream work; maybe a
fork, but certainly not just a patch on the released upstream work for
Python 2 only.

-- 
 \“Madness is rare in individuals, but in groups, parties, |
  `\nations and ages it is the rule.” —Friedrich Nietzsche |
_o__)  |
Ben Finney



python3 for pysrs

2017-07-16 Thread Sandro Knauß
Hey,

I'm currently porting pysrs to python3 and sofar I got all tests running for 
python2 and python3 *yeah*. But the porting was mostly adding encode()/
decode() to many parts of the module. And I'm unsure, if the API is now in a 
good shape, or if it is mostly unusable for users, because I mixed bytes/
strings to much. Can somebody help here to give a good look from "outside"? 
[0]

I also see these messages:
python-srs: unused substitution variable ${python:Provides}
python-srs: unused substitution variable ${python:Versions} 

so far I understand 
https://www.debian.org/doc/packaging-manuals/python-policy/ch-module_packages.html
 i should ignore these messages.

And at least the testSRS.py is not available in build dir, so these tests are 
not runned. Should I override dh_auto_tests? or PYBUILD_TEST_ARGS_python2/3?  
What is the recommended way?

Best Regards,

sandro

[0] https://anonscm.debian.org/git/python-modules/packages/pysrs.git  

signature.asc
Description: This is a digitally signed message part.