Hi Ana!
Sorry for the delay; I've been away for work for a bit.
I took a look; thanks for the update. Can you move the publicsuffix local
URL to the top of the list? Based on its current position, it will
(essentially) never be used.
I also created the repos under the DMPT heirarchy and granted you explicit
access to them; once you join the DPMT team, you'll inherit the permissions
from there in addition.
https://salsa.debian.org/python-team/modules/python-tldextract
https://salsa.debian.org/python-team/modules/python-lexicon
Other than that, tldextract looks good and is ready for an upload as soon
as that tweak is done. Lexicon is fine as-is; I'll push that up when
tldextract gets uploaded.
Sincerely,
On Mon, Mar 5, 2018 at 12:21 AM, Ana C. Custura wrote:
> Hi Harlan,
>
> Thank you for the feedback!
>
> On Sat, Mar 3, 2018, at 1:48 AM, Harlan Lieberman-Berg wrote:
>
> For the VCSs', you have two options; if you want to join DPMT, you could
> put them under their hierarchy, or you could use the Debian heirarchy and I
> can grant you permissions for the repos. Let me know which one you'd
> prefer to do.
>
> The latter for now please. I will fire an email to DPMT to request joining
> the team, as I'd like to start working with them on the other ITPs.
>
>
> I do have one tweak I'd like to see for python-tldextract; I think we
> should have it Recommend `publicsuffix` and add that to the list of
> PUBLIC_SUFFIX_LIST_URLs. Please test it to make sure it works even without
> that file; reading the code, it looks like it should, but I'd like to
> double check.
>
> Done, new version uploaded on mentors. Have tested the relevant code, it
> works with and without /usr/share/publicsuffix/effective_tld_names.dat.
>
>
> For python-lexicon, it's generally considered good practice to use the
> same license for the work under debian/ as the rest of the package is. If
> the difference was intentional, I'd want to know more about why you feel
> the difference is important.
>
> Ah, I forgot to change it from the dh_make default. Thank you for pointing
> it out, new version on mentors!
>
> Let me know if there's anything else to do.
>
> Regards,
> Ana
>
>
--
Harlan Lieberman-Berg
~hlieberman
