Re: Review of package dunamai
Thank you for for the comprehensive yet friendly review! I've fixed all the things you pointed out in a new python-dunamai packaging repo: https://salsa.debian.org/python-team/packages/python-dunamai Salsa CI is green, lintian stays silent, unit tests pass, autopkgtests pass \o/ I've uploaded the initial package, let's see if it passes NEW. On 8/8/23 05:16, Louis-Philippe Véronneau wrote: 10. Your package doesn't actually run tests during build: "Ran 0 tests in 0.000s". You're missing "python3-pytest" as a build-dependency. With this dependency, all tests (and not only the unit tests) will be ran and they'll fail. I don't think you want to run the integration tests, or at least, this should probably be done in an autopkgtest instead. You can fix this by adding a "d/pybuild.testsuites" file containing "tests/unit" to specify what testfiles to add/keep. This file had no effect for me, all tests were run regardless. I found no mention of it in man or in other packages. (man pybuild for more info) I've used export PYBUILD_TEST_ARGS=tests/unit in d/rules to achieve the desired effect of only running unit tests. Cheers, and thanks for contributing to Debian! My pleasure and thank you for helping me contribute to Debian in higher quality! :) When you're ready for a review of poetry-dynamic-versioning, don't hesitate to ping me. Will do. I've opened ITP bug in the meantime (before dunamai hits sid): https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1043360 There is already a question you might be able to answer. Cheers, Jakub Ružička OpenPGP_signature Description: OpenPGP digital signature
Request to join PythonTeam
Hello PythonTeam! I've recently become DD after many years of Debian usage and I've been packaging python software for various platforms for as long as I remember so I'd like to finally join Debian PythonTeam :) I mostly write packaging automation tools in Python such as [apkg] but I also package various FOSS as needed for different distros (Debian, Fedora, EL, SUSE, Arch, Nix). I do both upstream and downstream packaging - in Debian and Fedora/EPEL. Availability of packages from distro repos is a major factor when considering adoption of software and so I'd like to be able to help with packaging various python things that might be useful to humanity. I'd like to join Debian PythonTeam, I have read and accepted [policy]. My Salsa username is jruzicka, Debian account jru. I'm currently interested in packaging [dunamai] and its sibling [poetry-dynamic-versioning] for dynamic version discovery from VCS. I've created [ITP] bug #1033361 for Dunamai which includes the link to new [Salsa repo] with CI enabled and green including lintian and simple autopkgtest. It's using poetry-core through pybuild/pyproject and it seems to work fine - great job supporting that! Please let me know if you notice any issues with the package. Source package is called just `dunamai`, maybe it should be `python-dunamai`? Resulting package is called `python3-dunamai` but it also contains `dunamai` CLI and users might expect it to get installed on apt install dunamai so maybe Provides: dunamai or something similar? All feedback is appreciated. Cheers, Jakub Ružička [policy]: https://salsa.debian.org/python-team/tools/python-modules/blob/master/policy.rst [apkg]: https://gitlab.nic.cz/packaging/apkg [dunamai]: https://github.com/mtkennerly/dunamai/ [poetry-dynamic-versioning]: https://github.com/mtkennerly/poetry-dynamic-versioning [ITP]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1033361 [Salsa repo]: https://salsa.debian.org/jruzicka/dunamai signature.asc Description: PGP signature
Request to join PythonTeam
Hello PythonTeam! I've recently become DD after many years of Debian usage and I've been packaging python software for various platforms for as long as I remember so I'd like to finally join Debian PythonTeam :) I mostly write packaging automation tools in Python such as [apkg] but I also package various FOSS as needed for different distros (Debian, Fedora, EL, SUSE, Arch, Nix). I do both upstream and downstream packaging - in Debian and Fedora/EPEL. Availability of packages from distro repos is a major factor when considering adoption of software and so I'd like to be able to help with packaging various python things that might be useful to humanity. I'd like to join Debian PythonTeam, I have read and accepted [policy]. My Salsa username is jruzicka, Debian account jru. I'm currently interested in packaging [dunamai] and its sibling [poetry-dynamic-versioning] for dynamic version discovery from VCS. I've created [ITP] bug #1033361 for Dunamai which includes the link to new [Salsa repo] with CI enabled and green including lintian and simple autopkgtest. It's using poetry-core through pybuild/pyproject and it seems to work fine - great job supporting that! Please let me know if you notice any issues with the package. Source package is called just `dunamai`, maybe it should be `python-dunamai`? Resulting package is called `python3-dunamai` but it also contains `dunamai` CLI and users might expect it to get installed on apt install dunamai so maybe Provides: dunamai or something similar? All feedback is appreciated. Cheers, Jakub Ružička [policy]: https://salsa.debian.org/python-team/tools/python-modules/blob/master/policy.rst [apkg]: https://gitlab.nic.cz/packaging/apkg [dunamai]: https://github.com/mtkennerly/dunamai/ [poetry-dynamic-versioning]: https://github.com/mtkennerly/poetry-dynamic-versioning [ITP]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1033361 [Salsa repo]: https://salsa.debian.org/jruzicka/dunamai signature.asc Description: PGP signature
