Re: django-pipeline / slimit
Brian May writes: > Maybe I should have a look at doing the python-slimit and python3-slimit > split again. Looks like I don't have commit access to PAPT, so I can't commit my changes to SVN. How do I get commit access to PAPT? Thanks -- Brian May
Re: django-pipeline / slimit
Raphael Hertzog writes: > Yeah, skip the test on Python 3, tell upstream that slimit is not > supported on Python 3 and that the test should be skipped there. Upstream pipeline seem to think slimit works fine with Python 3: https://github.com/jazzband/django-pipeline/issues/554#issuecomment-200842866 Maybe I should have a look at doing the python-slimit and python3-slimit split again. -- Brian May
Re: django-pipeline / slimit
Raphael Hertzog writes: > Yeah, skip the test on Python 3, tell upstream that slimit is not > supported on Python 3 and that the test should be skipped there. Done. https://github.com/jazzband/django-pipeline/issues/554 > Make sure that slimit is not the default. It wasn't. However Yuglify was the default. Yuglify isn't in Debian. Or if it is I can't find it. IIRC there were licensing issues. So I have changed the defaults to use cssmin and jsmin. -- Brian May
Re: django-pipeline / slimit
On Wed, 23 Mar 2016, Brian May wrote: > Looks like slimit doesn't support Python3 and hasn't had an upstream > release since 2013-03-26. > > Any suggestions where to go from here? > > Maybe hack pipeline to disable the failing test? I think pipeline can be > configured to use jsmin instead of slimit and jsmin is packaged in > python2 and python3 versions. Yeah, skip the test on Python 3, tell upstream that slimit is not supported on Python 3 and that the test should be skipped there. Make sure that slimit is not the default. Cheers, -- Raphaël Hertzog ◈ Debian Developer Support Debian LTS: http://www.freexian.com/services/debian-lts.html Learn to master Debian: http://debian-handbook.info/get/
Re: django-pipeline / slimit
Raphael Hertzog writes: > On Wed, 23 Mar 2016, Brian May wrote: >> I: pybuild base:184: PYTHONPATH=. python3.5 /usr/bin/django-admin test >> --settings=tests.settings > ^ >> File "/«PKGBUILDDIR»/pipeline/compressors/slimit.py", line 12, in >> compress_js >> from slimit import minify >> ImportError: No module named 'slimit' > [...] >> Does this mean we need to change the slimit package into python-slimit >> and python3-slimit packages? > > Looks like so, indeed. Just noticed there is already an bug open on this, filled by me over a year ago. https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=779321 Looks like slimit doesn't support Python3 and hasn't had an upstream release since 2013-03-26. Any suggestions where to go from here? Maybe hack pipeline to disable the failing test? I think pipeline can be configured to use jsmin instead of slimit and jsmin is packaged in python2 and python3 versions. -- Brian May
Re: django-pipeline / slimit
On Wed, 23 Mar 2016, Brian May wrote: > I: pybuild base:184: PYTHONPATH=. python3.5 /usr/bin/django-admin test > --settings=tests.settings ^ > File "/«PKGBUILDDIR»/pipeline/compressors/slimit.py", line 12, in > compress_js > from slimit import minify > ImportError: No module named 'slimit' [...] > Does this mean we need to change the slimit package into python-slimit > and python3-slimit packages? Looks like so, indeed. Cheers, -- Raphaël Hertzog ◈ Debian Developer Support Debian LTS: http://www.freexian.com/services/debian-lts.html Learn to master Debian: http://debian-handbook.info/get/
Re: django-pipeline / slimit
Brian May writes:
> Ok, so now I think I understand, time to test the lastest version of
> pipeline I think. See if that helps.
It fixes the problem. However we get a new problem:
I: pybuild base:184: PYTHONPATH=. python3.5 /usr/bin/django-admin test
--settings=tests.settings
..sssss.Es..s
==
ERROR: test_slimit (tests.tests.test_compressor.CompressorImplementationTest)
--
Traceback (most recent call last):
File "/«PKGBUILDDIR»/tests/tests/test_compressor.py", line 230, in test_slimit
'js', 'pipeline/compressors/slimit.js')
File "/«PKGBUILDDIR»/tests/tests/test_compressor.py", line 215, in
_test_compressor
[_('pipeline/js/first.js'), _('pipeline/js/second.js')])
File "/«PKGBUILDDIR»/pipeline/compressors/__init__.py", line 69, in
compress_js
js = getattr(compressor(verbose=self.verbose), 'compress_js')(js)
File "/«PKGBUILDDIR»/pipeline/compressors/slimit.py", line 12, in compress_js
from slimit import minify
ImportError: No module named 'slimit'
--
Ran 89 tests in 0.839s
FAILED (errors=1, skipped=15)
Does this mean we need to change the slimit package into python-slimit
and python3-slimit packages?
--
Brian May
