Re: Looking for a Sponsor - Papereshaper

2020-12-30 Thread Fabrice BAUZAC
Paul Wise  writes:

> On Wed, Dec 30, 2020 at 4:50 PM Devops PK Carlisle LLC wrote:
>> The git is here: https://github.com/pkcarlislellc/git-papershaper

> IIRC you can use the print function in Python 2 by adding the line
> below.
>
> from future import print_function

Actually it is __future__:

  from __future__ import print_function

Also, it is better to put a copyright notice as a comment at the
beginning of most files, e.g.:

Copyright YEAR, YEAR... NAME 

-- 
Fabrice Bauzac-Stehly
PGP 01EEACF8244E9C14B551C5256ADA5F189BD322B6
old PGP 015AE9B25DCB0511D200A75DE5674DEA514C891D



Re: Looking for a Sponsor - Papereshaper

2020-12-30 Thread Devops PK Carlisle LLC
Excellent. Thank you for reviewing. Looks like I have a list of
adjustments to make.

On 12/30/20 8:02 PM, Paul Wise wrote:
> On Wed, Dec 30, 2020 at 4:50 PM Devops PK Carlisle LLC wrote:
> 
>> The git is here: https://github.com/pkcarlislellc/git-papershaper
> 
> I don't intend to package nor sponsor this, but here is a review:
> 
> Drop git- from the name of the GitHub repository.
> 
> Add a git repository to the SourceForge project also and push to both repos.
> 
> Remove the possibly non-free and or non-redistributable images in the
> git repository. If they are actually redistributable and freely
> licensed, please document the location where they were obtained from,
> their copyright owner and license. If they are non-redistributable
> then you will need to rewrite the history of the git repository to
> exclude them.
> 
> Merge the two scripts into one supporting both versions of Python (or
> just drop the Python 2 one). IIRC you can use the print function in
> Python 2 by adding the line below. After that the remaining changes
> don't look necessary, or can be made conditional with
> sys.version_info.
> 
> from future import print_function
> 
> The first thing in the README.md should be a one-sentence description
> of what the program does.
> 
> Drop the Google Code mention/link from the README.md.
> 
> The README.md mentions that webcamgrab.txt was taken from another
> program, but doesn't mention the copyright/license information for the
> file anywhere. While the SourceForge project for the other program
> says GPLv3, the tarball containing the list of webcams doesn't mention
> any license.
> 
> Change the GPL reference at the start of the README.md to mention
> which versions.
> 
> The list of webcams is liable to get out of date, especially when
> shipped with the script, it might be a good idea to have continuous
> monitoring of the list, plus a way to auto-update it on end-user
> systems.
> 
> Consider switching to the XDG standard for some of the paths:
> 
> https://specifications.freedesktop.org/basedir-spec/basedir-spec-latest.html
> https://wiki.archlinux.org/index.php/XDG_Base_Directory
> https://github.com/srstevenson/xdg
> 
> When I run check-all-the-things in the source tree, a number of the
> checks produce output that is worth reviewing.
> 
> https://github.com/collab-qa/check-all-the-things/
> 
> grep -ri gimp
> codespell
> doc8
> grep -r http:
> proselint
> spellintian
> pycodestyle
> pyflakes
> pylint
> vulture
> 



Re: Looking for a Sponsor - Papereshaper

2020-12-30 Thread Paul Wise
On Wed, Dec 30, 2020 at 4:50 PM Devops PK Carlisle LLC wrote:

> The git is here: https://github.com/pkcarlislellc/git-papershaper

I don't intend to package nor sponsor this, but here is a review:

Drop git- from the name of the GitHub repository.

Add a git repository to the SourceForge project also and push to both repos.

Remove the possibly non-free and or non-redistributable images in the
git repository. If they are actually redistributable and freely
licensed, please document the location where they were obtained from,
their copyright owner and license. If they are non-redistributable
then you will need to rewrite the history of the git repository to
exclude them.

Merge the two scripts into one supporting both versions of Python (or
just drop the Python 2 one). IIRC you can use the print function in
Python 2 by adding the line below. After that the remaining changes
don't look necessary, or can be made conditional with
sys.version_info.

from future import print_function

The first thing in the README.md should be a one-sentence description
of what the program does.

Drop the Google Code mention/link from the README.md.

The README.md mentions that webcamgrab.txt was taken from another
program, but doesn't mention the copyright/license information for the
file anywhere. While the SourceForge project for the other program
says GPLv3, the tarball containing the list of webcams doesn't mention
any license.

Change the GPL reference at the start of the README.md to mention
which versions.

The list of webcams is liable to get out of date, especially when
shipped with the script, it might be a good idea to have continuous
monitoring of the list, plus a way to auto-update it on end-user
systems.

Consider switching to the XDG standard for some of the paths:

https://specifications.freedesktop.org/basedir-spec/basedir-spec-latest.html
https://wiki.archlinux.org/index.php/XDG_Base_Directory
https://github.com/srstevenson/xdg

When I run check-all-the-things in the source tree, a number of the
checks produce output that is worth reviewing.

https://github.com/collab-qa/check-all-the-things/

grep -ri gimp
codespell
doc8
grep -r http:
proselint
spellintian
pycodestyle
pyflakes
pylint
vulture

-- 
bye,
pabs

https://wiki.debian.org/PaulWise



Re: Looking for a Sponsor - Papereshaper

2020-12-30 Thread Emmanuel Arias
Hi,

After read [0] I'm a little confused. Do you want to package gpapershaper
by yourself? or do you want someone to package papershaper?

Because, the subject of this mail is "looking for a sponsor", but when you
look for a sponsor that means that you already have the Debian package
and need a Debian Developer review and upload. Commonly this is the ITP
(intent to package) way*.

If you send a RFP (request for package) you are looking for someone else
(volunteer) to create the Debian package.

* Just to not confuse, you need a sponsor for other tasks, but
I'm talking about this situation, for instance.

[0] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=976174

On Wed, Dec 30, 2020 at 1:50 PM Devops PK Carlisle LLC <
dev...@pkcarlisle.com> wrote:

> I wrote a small Python utility for wallpaper swapping, it has been
> working flawlessly for a couple of years on my Linux boxes, and I am
> looking to include it in Debian.
>
> I have spent the last week or so tweaking docs and comments to be as
> Debian package friendly as I know how, I have a git uploaded, and an RFP
> submitted, and at this point I should probably stop messing with it and
> ask about a sponsor.
>
> The RFP is here: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=976174
>
> The git is here: https://github.com/pkcarlislellc/git-papershaper
>
> Thanks!
>
>


Looking for a Sponsor - Papereshaper

2020-12-30 Thread Devops PK Carlisle LLC
I wrote a small Python utility for wallpaper swapping, it has been
working flawlessly for a couple of years on my Linux boxes, and I am
looking to include it in Debian.

I have spent the last week or so tweaking docs and comments to be as
Debian package friendly as I know how, I have a git uploaded, and an RFP
submitted, and at this point I should probably stop messing with it and
ask about a sponsor.

The RFP is here: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=976174

The git is here: https://github.com/pkcarlislellc/git-papershaper

Thanks!