Re: Removing /usr/bin/nosetests-3.x scripts
On Feb 22, 2013, at 11:51 PM, Stefano Rivera wrote: 1. Status quo: Provide a nosetests-3.X script for the default version at build time. Pros: None Cons: - This potentially breaks unit tests if there are two supported 3.x versions. 2. Drop all nosetsts-3.X scripts. Pros: - Maintainers who were aware of the problems with 1 had to manually call python3.X /usr/bin/nostests3 anyway, so this doesn't cause them any harm. - Don't accidentally end up with dependencies on all python3.Xs Cons: - Maintainers who weren't needed their packages patched. 3. Apply a messy patch to generate scripts based on py3verions -s at build time. Pros: - Neat Cons: - It's ugly as hell - Have to do a sourceful upload for each python3 supported versions change - Will accidentally end up with dependencies on all python3.Xs 4. Use .rtinstall, .rtremove, postinst, and prerm scripts to maintain all the nosetsets-3.X scripts (pytest does this) Pros: - Neat - No accidental dependencies on all python3.Xs Cons: - You are creating and deleting things in /usr/bin in maintainer scripts - this made some people cringe. I wish we would do #4. I suppose it's a little cringe worthy, especially because (as you later point out) you'd probably also want to add versions for the -dbg flavors too. But that bothers me less than not having those scripts available, since I think users will expect them to be there. For example, the tox documentation example suggests calling nosetests (albeit, for Python 2) directly. http://tox.readthedocs.org/en/latest/example/nose.html?highlight=nose Is #4 really that horrible? -Barry signature.asc Description: PGP signature
Re: Removing /usr/bin/nosetests-3.x scripts
On Tue, Feb 26, 2013 at 10:32:56 -0500, Barry Warsaw wrote: On Feb 22, 2013, at 11:51 PM, Stefano Rivera wrote: 1. Status quo: Provide a nosetests-3.X script for the default version at build time. Pros: None Cons: - This potentially breaks unit tests if there are two supported 3.x versions. 2. Drop all nosetsts-3.X scripts. Pros: - Maintainers who were aware of the problems with 1 had to manually call python3.X /usr/bin/nostests3 anyway, so this doesn't cause them any harm. - Don't accidentally end up with dependencies on all python3.Xs Cons: - Maintainers who weren't needed their packages patched. 3. Apply a messy patch to generate scripts based on py3verions -s at build time. Pros: - Neat Cons: - It's ugly as hell - Have to do a sourceful upload for each python3 supported versions change - Will accidentally end up with dependencies on all python3.Xs 4. Use .rtinstall, .rtremove, postinst, and prerm scripts to maintain all the nosetsets-3.X scripts (pytest does this) Pros: - Neat - No accidental dependencies on all python3.Xs Cons: - You are creating and deleting things in /usr/bin in maintainer scripts - this made some people cringe. I wish we would do #4. I suppose it's a little cringe worthy, especially because (as you later point out) you'd probably also want to add versions for the -dbg flavors too. But that bothers me less than not having those scripts available, since I think users will expect them to be there. For example, the tox documentation example suggests calling nosetests (albeit, for Python 2) directly. http://tox.readthedocs.org/en/latest/example/nose.html?highlight=nose nosetests isn't going away, and this page doesn't seem to mention a versioned script. Is #4 really that horrible? IMO, yes. Cheers, Julien -- Julien Cristau julien.cris...@logilab.fr Logilab http://www.logilab.fr/ Informatique scientifique gestion de connaissances -- To UNSUBSCRIBE, email to debian-python-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20130226155240.gc21...@crater1.logilab.fr
Re: Removing /usr/bin/nosetests-3.x scripts
Hi Barry (2013.02.22_15:38:46_+0200) Is there no better way to provide nosetests-X.Y scripts with the proper shebang lines for all supported Python versions? Oh, and one more thing. If you have a C extension, and want to run your tests on the DEBUG builds of python, you need nosetests-X.Y-dbg which isn't provided. SR -- Stefano Rivera http://tumbleweed.org.za/ H: +27 21 461 1230 C: +27 72 419 8559 -- To UNSUBSCRIBE, email to debian-python-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20130223090057.ge29...@bach.rivera.co.za
Re: Removing /usr/bin/nosetests-3.x scripts
On 02/22/2013 07:28 AM, Dmitry Shachnev wrote: Hi, As discussed yesterday on IRC, nose's /usr/bin/nosetests-3.x scripts are broken (provided only for python3 version(s) that was/were default on build time), and instead of writing hacks to fix that we have decided to instead remove those scripts and make packages use python3.x /usr/bin/nosetests3 instead (note: this will only affect experimental for now). After looking at all packages that build-depend on python3-nose, I've identified these packages as needing fix: - beautifulsoup4 (autopkgtests, only SVN trunk is affected) (uploader: Stefano Rivera) - cssutils (debian/rules) (active uploader: Charlie Smotherman) - python-flexmock (debian/rules) (uploader: Stefano Rivera) - python-markdown (debian/rules and autopkgtests) (my package) Thankfully all these packages are team-maintained, so I've pushed fixes to the SVN. hi, did you also check the autopkgtest directories? e.g. pyzmq in svn (not yet uploaded) currently uses nosetests-3.x in the autopkgtests but not in debian/rules. -- To UNSUBSCRIBE, email to debian-python-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/5127a61d.1040...@googlemail.com
Re: Removing /usr/bin/nosetests-3.x scripts
On Feb 22, 2013, at 10:28 AM, Dmitry Shachnev wrote: As discussed yesterday on IRC, nose's /usr/bin/nosetests-3.x scripts are broken (provided only for python3 version(s) that was/were default on build time) Sorry, can you please provide more detail for folks who were not participating in the IRC discussion? Is there no better way to provide nosetests-X.Y scripts with the proper shebang lines for all supported Python versions? Cheers, -Barry signature.asc Description: PGP signature
Re: Removing /usr/bin/nosetests-3.x scripts
Thanks for the heads up! I've checked reverse build-dependencies in sid only, in experimental there are more matching packages, but only pyxdg needs fixing. Surprisingly, many packages are already using the right way. -- Dmitry Shachnev On Fri, Feb 22, 2013 at 3:32 PM, Thomas Kluyver tho...@kluyver.me.uk wrote: On 22 February 2013 06:28, Dmitry Shachnev mity...@gmail.com wrote: After looking at all packages that build-depend on python3-nose, I've identified these packages as needing fix: I happen to recall that python-xdg is also affected, both in debian/rules [1] and autopkgtests [2]. I'm happy to update that, but you might want to double check the script that you were using to scan packages, to make sure that we're not missing other cases. [1] http://anonscm.debian.org/viewvc/python-modules/packages/pyxdg/trunk/debian/rules?revision=22479view=markup [2] http://anonscm.debian.org/viewvc/python-modules/packages/pyxdg/trunk/debian/tests/upstream?revision=23091view=markup Thomas -- To UNSUBSCRIBE, email to debian-python-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/CAKimPHVhz3HMH4rMoOnAn_SVEcEiCYN4oO9xi4ckiCFi=zw...@mail.gmail.com
Re: Removing /usr/bin/nosetests-3.x scripts
On 22 February 2013 06:28, Dmitry Shachnev mity...@gmail.com wrote: After looking at all packages that build-depend on python3-nose, I've identified these packages as needing fix: I happen to recall that python-xdg is also affected, both in debian/rules [1] and autopkgtests [2]. I'm happy to update that, but you might want to double check the script that you were using to scan packages, to make sure that we're not missing other cases. [1] http://anonscm.debian.org/viewvc/python-modules/packages/pyxdg/trunk/debian/rules?revision=22479view=markup [2] http://anonscm.debian.org/viewvc/python-modules/packages/pyxdg/trunk/debian/tests/upstream?revision=23091view=markup Thomas
Re: Removing /usr/bin/nosetests-3.x scripts
Hi Barry (2013.02.22_15:38:46_+0200) As discussed yesterday on IRC, nose's /usr/bin/nosetests-3.x scripts are broken (provided only for python3 version(s) that was/were default on build time) Sorry, can you please provide more detail for folks who were not participating in the IRC discussion? Is there no better way to provide nosetests-X.Y scripts with the proper shebang lines for all supported Python versions? Our options were: 1. Status quo: Provide a nosetests-3.X script for the default version at build time. Pros: None Cons: - This potentially breaks unit tests if there are two supported 3.x versions. 2. Drop all nosetsts-3.X scripts. Pros: - Maintainers who were aware of the problems with 1 had to manually call python3.X /usr/bin/nostests3 anyway, so this doesn't cause them any harm. - Don't accidentally end up with dependencies on all python3.Xs Cons: - Maintainers who weren't needed their packages patched. 3. Apply a messy patch to generate scripts based on py3verions -s at build time. Pros: - Neat Cons: - It's ugly as hell - Have to do a sourceful upload for each python3 supported versions change - Will accidentally end up with dependencies on all python3.Xs 4. Use .rtinstall, .rtremove, postinst, and prerm scripts to maintain all the nosetsets-3.X scripts (pytest does this) Pros: - Neat - No accidental dependencies on all python3.Xs Cons: - You are creating and deleting things in /usr/bin in maintainer scripts - this made some people cringe. 2 seemed better than 1, and was dead easy. Given the fairly low number of packages using python3-nose, fixing them wasn't hard. SR -- Stefano Rivera http://tumbleweed.org.za/ H: +27 21 461 1230 C: +27 72 419 8559 -- To UNSUBSCRIBE, email to debian-python-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/2013015103.gb29...@bach.rivera.co.za
Re: Removing /usr/bin/nosetests-3.x scripts
On Fri, Feb 22, 2013 at 9:08 PM, Julian Taylor jtaylor.deb...@googlemail.com wrote: did you also check the autopkgtest directories? e.g. pyzmq in svn (not yet uploaded) currently uses nosetests-3.x in the autopkgtests but not in debian/rules. Hi Julian, I was checking both debian/rules and debian/tests/*, but only for packages in sid and experimental that build-depend on python3-nose. Now I have done something like grep-dctrl -sTests -FDepends python3-nose ./*/trunk/debian/tests/control grep-dctrl -sSource -FBuild-Depends-Indep python3-nose ./*/trunk/debian/control grep-dctrl -sSource -FBuild-Depends python3-nose ./*/trunk/debian/control in both DPMT and PAPT SVNs, and again pyzmq is the only package that wasn't noticed by my previous checks. Please fix it before uploading. -- Dmitry Shachnev -- To UNSUBSCRIBE, email to debian-python-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/1361601561.17193.2.camel@mandriver-laptop
