Re: When packaging a library, should I prevent its test suite from being packaged

2014-09-10 Thread Matthias Urlichs
Hi, Konstantin Khomoutov: have discovered the tests attempt to connect to a MySQL instance on the localhost, and authenticate there as the user root using no password. I would file an Upstream bug for this. They should use a test user with a test_PACKAGENAME database, and make the mysql

Re: When packaging a library, should I prevent its test suite from being packaged

2014-09-10 Thread Tianon Gravi
On 9 September 2014 09:28, Piotr Ożarowski pi...@debian.org wrote: (I will remove all .../dist-packages/test{,s} by default in next dh_python{2,3} version). Does this mean we'll get a nice warning too, so we know that we need to report the bug upstream? :) ♥, - Tianon -- To UNSUBSCRIBE,

Re: When packaging a library, should I prevent its test suite from being packaged

2014-09-10 Thread Piotr Ożarowski
[Tianon Gravi, 2014-09-10] On 9 September 2014 09:28, Piotr Ożarowski pi...@debian.org wrote: (I will remove all .../dist-packages/test{,s} by default in next dh_python{2,3} version). Does this mean we'll get a nice warning too, so we know that we need to report the bug upstream? :) yes

Re: When packaging a library, should I prevent its test suite from being packaged

2014-09-10 Thread Tianon Gravi
On 10 September 2014 11:11, Piotr Ożarowski pi...@debian.org wrote: yes (and I'm still wondering if failing with an error message that this module name is too generic is a better idea) I'd personally love to see it hard fail (since warnings will be quite often missed), especially if it included

When packaging a library, should I prevent its test suite from being packaged

2014-09-09 Thread Konstantin Khomoutov
I'm packaging a Python3-only library, PyMySQL [1], for internal usage, chiefly using dh $@ --with python3 --buildsystem=pybuild This library includes a test suite, in a subdirectory named tests, within its source tree. This directory gets packaged, installed and byte-compiled (by the

Re: When packaging a library, should I prevent its test suite from being packaged

2014-09-09 Thread Barry Warsaw
On Sep 09, 2014, at 06:53 PM, Konstantin Khomoutov wrote: Having the test suite packaged along with the code looks like having not much sense to me, so should I try to exclude this subdirectory from packaging? Is it considered a bad practice? I'm not sure there's consensus on this, so I will

Re: When packaging a library, should I prevent its test suite from being packaged

2014-09-09 Thread Piotr Ożarowski
[Konstantin Khomoutov, 2014-09-09] This library includes a test suite, in a subdirectory named tests, within its source tree. This directory gets packaged, installed and byte-compiled (by the generated postinst script) during the installation. Having the test suite packaged along with the

Re: When packaging a library, should I prevent its test suite from being packaged

2014-09-09 Thread Tristan Seligmann
On 9 September 2014 16:53, Konstantin Khomoutov flatw...@users.sourceforge.net wrote: Having the test suite packaged along with the code looks like having not much sense to me, so should I try to exclude this subdirectory from packaging? Is it considered a bad practice? I don't have much