Re: direct-changes-in-diff-but-no-patch-system foo.egg-info/SOURCES.txt

2010-01-27 Thread Ben Finney
Adam writes: > We can end this discussion. Upstream (the experts) replied to my bug > report[1]. They are going to delete the entire foo.egg-info directory > (on setup.py clean). setuptools/distribute at the moment doesn't have > any cleanup functionality. setup.py clean currently is from python'

Re: direct-changes-in-diff-but-no-patch-system foo.egg-info/SOURCES.txt

2010-01-27 Thread Adam
Ben Finney wrote: > I wonder, then, why the file is included in the source distribution at > all. Does it serve any function there, if that version is never used but > is only re-built? We can end this discussion. Upstream (the experts) replied to my bug report[1]. They are going to delete the en

Re: direct-changes-in-diff-but-no-patch-system foo.egg-info/SOURCES.txt

2010-01-27 Thread Ben Finney
Adam writes: > Ben Finney wrote: > > […] the ‘SOURCES.txt’ file is distributed as source, so > > automatically deleting that file is too much magic. Rather, the > > build process should not modify the source files at all. > > SOURCES.txt is rebuilt and not modified. You say tomayto, I say tomaht

Re: direct-changes-in-diff-but-no-patch-system foo.egg-info/SOURCES.txt

2010-01-27 Thread Adam
Ben Finney wrote: > Adam writes: > > > > > I think "setup.py clean" (which gets called by dh_auto_clean) really > > should just delete SOURCES.txt. I just filed a bug upstream against > > python-distribute: > > > > http://bitbucket.org/tarek/distribute/issue/122/setuppy-clean-should-delete-sourc

Re: direct-changes-in-diff-but-no-patch-system foo.egg-info/SOURCES.txt

2010-01-27 Thread Tristan Seligmann
On Wed, Jan 27, 2010 at 1:05 PM, Ben Finney wrote: > Adam writes: > >> >> I think "setup.py clean" (which gets called by dh_auto_clean) really >> should just delete SOURCES.txt. I just filed a bug upstream against >> python-distribute: >> >> http://bitbucket.org/tarek/distribute/issue/122/setuppy

Re: direct-changes-in-diff-but-no-patch-system foo.egg-info/SOURCES.txt

2010-01-27 Thread Ben Finney
Adam writes: > > I think "setup.py clean" (which gets called by dh_auto_clean) really > should just delete SOURCES.txt. I just filed a bug upstream against > python-distribute: > > http://bitbucket.org/tarek/distribute/issue/122/setuppy-clean-should-delete-sourcestxt I disagree; the ‘SOURCES.txt

Re: direct-changes-in-diff-but-no-patch-system foo.egg-info/SOURCES.txt

2010-01-27 Thread Adam
Ben Finney wrote: > Adam writes: > > SOURCES.txt gets recreated during build process (by setup.py). So it > > is in the .deb. > [...], is there a more general solution we Debian package > maintainers can implement? [...] > Could ‘dh_auto_clean’ remove the file? Something else? I think "setup.

Re: direct-changes-in-diff-but-no-patch-system foo.egg-info/SOURCES.txt

2010-01-26 Thread Ben Finney
Adam writes: > Ben Finney wrote: > > But [removing the file during the ‘clean’ target of ‘debian/rules’] > > would also result in a change from the original upstream source. No? > > No. dpkg-source just spits a warning when a file is deleted from > original source. This is what I did in (python-)

Re: direct-changes-in-diff-but-no-patch-system foo.egg-info/SOURCES.txt

2010-01-15 Thread Chow Loong Jin
On Friday 15,January,2010 04:39 PM, Floris Bruynooghe wrote: > On Fri, Jan 15, 2010 at 02:16:10PM +1100, Ben Finney wrote: >> Cyril Brulebois writes: >> >>> Ben Finney (15/01/2010): Now, this is a “pedantic”-level tag, but it does seem valid: the SOURCES.txt file is in fact modified fro

Re: direct-changes-in-diff-but-no-patch-system foo.egg-info/SOURCES.txt

2010-01-15 Thread Floris Bruynooghe
On Fri, Jan 15, 2010 at 02:16:10PM +1100, Ben Finney wrote: > Cyril Brulebois writes: > > > Ben Finney (15/01/2010): > > > Now, this is a “pedantic”-level tag, but it does seem valid: the > > > SOURCES.txt file is in fact modified from the original upstream > > > source. > > > > Just rm it in cl

Re: direct-changes-in-diff-but-no-patch-system foo.egg-info/SOURCES.txt

2010-01-15 Thread Adam
Ben Finney wrote: > Cyril Brulebois writes: > > > Ben Finney (15/01/2010): > > > Now, this is a “pedantic”-level tag, but it does seem valid: the > > > SOURCES.txt file is in fact modified from the original upstream > > > source. > > > > Just rm it in clean? > > But that would also result in a

Re: direct-changes-in-diff-but-no-patch-system foo.egg-info/SOURCES.txt

2010-01-14 Thread Ben Finney
Cyril Brulebois writes: > Ben Finney (15/01/2010): > > Now, this is a “pedantic”-level tag, but it does seem valid: the > > SOURCES.txt file is in fact modified from the original upstream > > source. > > Just rm it in clean? But that would also result in a change from the original upstream sour

Re: direct-changes-in-diff-but-no-patch-system foo.egg-info/SOURCES.txt

2010-01-14 Thread Cyril Brulebois
Ben Finney (15/01/2010): > Now, this is a “pedantic”-level tag, but it does seem valid: the > SOURCES.txt file is in fact modified from the original upstream > source. Just rm it in clean? > Can I prevent this from happening, perhaps by an option to the > Setuptools procedure? If not, can I reco

direct-changes-in-diff-but-no-patch-system foo.egg-info/SOURCES.txt

2010-01-14 Thread Ben Finney
Howdy all, I'm getting a Lintian tag reported on some of my Python packages: direct-changes-in-diff-but-no-patch-system foo.egg-info/SOURCES.txt Now, this is a “pedantic”-level tag, but it does seem valid: the SOURCES.txt file is in fact modified from the original upstream source.