Re: Mass-commit fix of lintian ancient-python-version-field

2018-05-13 Thread Joseph Herlant
Hi,


On Fri, May 11, 2018 at 1:10 AM, Ondrej Novy  wrote:
> Are we sure it's completely safe to remove it globally?

Also, it's written in the python policy to do so:
https://wiki.debian.org/Python/Policy
"Another note: if there is a debian/pycompat file, you must launch
dh_python after dh_pysupport, but the recommended way is to remove
that file."

Checked in dh-python2 and 3 and I don't see how this could be an
issue. As Scott said, if that breaks any of the 18 packages, that
would probably be a bug or that the package needs to be updated to use
a supported build system.

Joseph



Re: Mass-commit fix of lintian ancient-python-version-field

2018-05-11 Thread Scott Kitterman
On Friday, May 11, 2018 09:33:20 AM Joseph Herlant wrote:
> Hi,
> 
> On Fri, May 11, 2018, 1:10 AM Ondrej Novy  wrote:
> > no problem, so just remove that file?
> > 
> > 
> > https://github.com/onovy/onovy-mass/commit/2c24adf1ecd8fc934328f69c75b2b2d
> > 9256ee3c9
> > 
> > Are we sure it's completely safe to remove it globally?
> 
> This file has been deprecated for about 10 years if I'm correct. It was
> used in old versions of dh_python and dh_pysupport.
> I will double-check the code of dh_python when I'm back at a computer but
> it was already asked to remove it when we migrated to dh_python2 in 2015,
> see: https://wiki.debian.org/Python/TransitionToDHPython2

If it's removal causes a problem, then we will have found a bug in the tool 
that has the problem.  pyversions will still use it if it's found, but it 
doesn't require it.

Scott K



Re: Mass-commit fix of lintian ancient-python-version-field

2018-05-11 Thread Joseph Herlant
Hi,

On Fri, May 11, 2018, 1:10 AM Ondrej Novy  wrote:

> no problem, so just remove that file?
>
>
> https://github.com/onovy/onovy-mass/commit/2c24adf1ecd8fc934328f69c75b2b2d9256ee3c9
>
> Are we sure it's completely safe to remove it globally?
>

This file has been deprecated for about 10 years if I'm correct. It was
used in old versions of dh_python and dh_pysupport.
I will double-check the code of dh_python when I'm back at a computer but
it was already asked to remove it when we migrated to dh_python2 in 2015,
see: https://wiki.debian.org/Python/TransitionToDHPython2


Re: Mass-commit fix of lintian ancient-python-version-field

2018-05-11 Thread Ondrej Novy
Hi,

2018-05-11 0:19 GMT+02:00 Joseph Herlant :

> ... maybe we could delete the pycompat file
> when exists at the same time (in a separate commit of course) to to
> get rid of debian-pycompat-is-obsolete. It seems there are still 18
> python modules with that file in.
>

no problem, so just remove that file?

https://github.com/onovy/onovy-mass/commit/2c24adf1ecd8fc934328f69c75b2b2d9256ee3c9

Are we sure it's completely safe to remove it globally?

-- 
Best regards
 Ondřej Nový

Email: n...@ondrej.org
PGP: 3D98 3C52 EB85 980C 46A5  6090 3573 1255 9D1E 064B


Re: Mass-commit fix of lintian ancient-python-version-field

2018-05-10 Thread Joseph Herlant
On Thu, May 10, 2018 at 4:29 AM, Ondrej Novy  wrote:
> Removing Python 2 version: <= 2.7 (thus all)
> Removing Python 3 version: <= 3.4 (older than jessie)
>
> Any objections?

Thanks for doing that Ondřej, maybe we could delete the pycompat file
when exists at the same time (in a separate commit of course) to to
get rid of debian-pycompat-is-obsolete. It seems there are still 18
python modules with that file in.
If not, no worries I was planning to check the packages that have this
linitian tag in the next week or so, see what I can do to get rid of
that.

Thanks
Joseph