Re: dh-python does not stop if there is error during the byte-compiling

2019-10-07 Thread Michael Kesper 
Hi Frederic,

On 06.10.19 10:37, PICCA Frederic-Emmanuel wrote:
> Hello, in one of my package (pymca), there is a syntax error like this.
> 
> byte-compiling 
> /builds/science-team/pymca/debian/output/pymca-5.5.2+dfsg/debian/python-pymca5/usr/lib/python2.7/dist-packages/PyMca5/Object3D/Object3DPlugins/ChimeraStack.py
>  to ChimeraStack.pyc
>   File 
> "/usr/lib/python2.7/dist-packages/PyMca5/Object3D/Object3DPlugins/ChimeraStack.py",
>  line 72
> with h5py.File(filename, mode='r') as f
>   ^
> SyntaxError: invalid syntax
> 
> byte-compiling /builds/science-team/pymca
> 
> (missing ':' at the end of the line) but this does not stop the build process.

As far as I understand the sourcecode from glancing at it, that is not intended 
(except for pypy3compile due to its freshness).
So maybe it would be helpful to look at the options with which you called the 
whole process.

Best wishes
Michael



signature.asc
Description: OpenPGP digital signature

Re: dh-python does not stop if there is error during the byte-compiling

2019-10-07 Thread Drew Parsons 

Frederik wrote:


Hello, in one of my package (pymca), there is a syntax error like this.

byte-compiling 
/builds/science-team/pymca/debian/output/pymca-5.5.2+dfsg/debian/python-pymca5/usr/lib/python2.7/dist-packages/PyMca5/Object3D/Object3DPlugins/ChimeraStack.py 
to ChimeraStack.pyc
  File 
"/usr/lib/python2.7/dist-packages/PyMca5/Object3D/Object3DPlugins/ChimeraStack.py", 
line 72

with h5py.File(filename, mode='r') as f
  ^
SyntaxError: invalid syntax

(missing ':' at the end of the line) but this does not stop the build 
process.


Is it normal ?




The error got through both dh_auto_install and pybuild --install.  I'm 
pretty sure dh_auto_install will halt on error (or more correctly 
debian/rules will halt when dh_auto_install returns an error).  I would 
have thought pybuild would also catch the error and pass it on to 
dh_auto_install.  Could it be that upstream setup.py returns 0 when the 
SyntaxError happens or something similar, i.e. ignores the error? The 
problem must be either there or in pybuild.


Drew