Re: review for pytest-fail-slow/0.3.0-1

2022-12-21 Thread Ileana Dumitrescu

Hi,


Some repo issues:
* It appears tags were not pushed, as there's no tags at all in the
   repo - not even for the imported upstream release - although the
   typical gbp workflow would handle that.


That is done now.


* The upstream tarball produced by uscan differs from the
   pristine-tar data. Are you making use of the standard tools for
   importing new releases, e.g. 'gbp import-orig --pristine-tar
   --uscan' or similar?


This was strange but I found the reason. The upstream repo in github had 
two .tar.gz files that were slightly different, so I updated the 
branches to be consistent with uscan. But I am using the standard tools.



Then for the packaging itself (which is in pretty good shape):
* changelog: please leave the release at UNRELEASED, cf. team policy.
* control:
   + the binary pkg for a pytest plugin is commonly named
 python3-pytest-;
   + short description: Pytest plugin to [current description]?
* upstream/metadata missing.
* no autopkgtest? Should be a trivial yet *very* useful addition,
   providing early warning for things like compatibility issues with
   newer pytest releases before packages using the plugin start seeing
   failures.


All are updated as asked, and I created an autopkgtest.

Thank you for the feedback! Is there a check list that you follow when
reviewing these packages? That can help with future uploads.

--
Ileana Dumitrescu

GPG Public Key: FA26 CA78 4BE1 8892 7F22 B99F 6570 EA01 146F 7354


OpenPGP_0x6570EA01146F7354.asc
Description: OpenPGP public key


OpenPGP_signature
Description: OpenPGP digital signature


review for pytest-fail-slow/0.3.0-1

2022-12-14 Thread Jeroen Ploemen
hi Ileana,

I took a look at pytest-fail-slow, up for sponsorship in the Python
team.

Some repo issues:
* It appears tags were not pushed, as there's no tags at all in the
  repo - not even for the imported upstream release - although the
  typical gbp workflow would handle that.

* The upstream tarball produced by uscan differs from the
  pristine-tar data. Are you making use of the standard tools for
  importing new releases, e.g. 'gbp import-orig --pristine-tar
  --uscan' or similar?


Then for the packaging itself (which is in pretty good shape):
* changelog: please leave the release at UNRELEASED, cf. team policy.
* control: 
  + the binary pkg for a pytest plugin is commonly named
python3-pytest-;
  + short description: Pytest plugin to [current description]?
* upstream/metadata missing.
* no autopkgtest? Should be a trivial yet *very* useful addition,
  providing early warning for things like compatibility issues with
  newer pytest releases before packages using the plugin start seeing
  failures.


pgpn3NddLW6w2.pgp
Description: OpenPGP digital signature