Bug#772318: kmix: bashism in /bin/sh script
tags 772318 + upstream patch
forwarded 772318 https://bugs.kde.org/show_bug.cgi?id=341640
thanks
I've raised this upstream on the KDE BTS with a patch. I've also attached a
copy of the patch here.
--
Jim Scadden
Description: Allow kmixremote to function correctly when using dash as /bin/sh
Author: Jim Scadden j...@silentasylum.co.uk
Bug-Debian: http://bugs.debian.org/772318
Bug: https://bugs.kde.org/show_bug.cgi?id=341640
Forwarded: https://bugs.kde.org/show_bug.cgi?id=341640
Last-Update: 2014-12-07
--- a/apps/kmixremote
+++ b/apps/kmixremote
@@ -7,7 +7,7 @@
# Mute
#
-function usage
+usage()
{
echo Usage:
echo List mixers# $0 list
@@ -15,19 +15,19 @@
echo Get Volume # $0 get [--master | mixer control]
echo Set Volume # $0 set [--master | mixer control] 0..100
echo Mute/Unmute# $0 mute [--master | mixer control] true|false
- echo
+ echo
}
-function exit_with_error
+exit_with_error()
{
echo Error: $1
- echo
+ echo
usage
exit 1
}
# Prints the mixer DBUS ID's on the console. leaving out the /Mixers/ prefix
-function listMixers
+listMixers()
{
qdbus org.kde.kmix /Mixers org.freedesktop.DBus.Properties.Get org.kde.KMix.MixSet mixers | cut -f3 -d/
errorCode=$?
@@ -37,7 +37,7 @@
}
# Prints the mixer control DBUS ID's of the given mixer on the console. leaving out the /Mixers/ prefix
-function listControls
+listControls()
{
qdbus org.kde.kmix $1 org.freedesktop.DBus.Properties.Get org.kde.KMix.Mixer controls | cut -f4 -d/
errorCode=$?
@@ -55,10 +55,11 @@
# Read args
while true; do
arg=$1
- shift
if test -z $arg; then
break
- elif test x--master = x$arg; then
+ fi
+ shift
+ if test x--master = x$arg; then
mixer=`qdbus org.kde.kmix /Mixers org.kde.KMix.MixSet.currentMasterMixer`
control=`qdbus org.kde.kmix /Mixers org.kde.KMix.MixSet.currentMasterControl`
elif test x--help = x$arg -o x-h = x$arg; then
Bug#745556: Closing dialog for allowing invalid SSL certificate causes default to be accepted
This has been fixed upstream in 4.14.3 http://commits.kde.org/kdelibs/38a89ca0195dedee30240647b86c7b6df6788723 -- To UNSUBSCRIBE, email to debian-qt-kde-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/20141126180817.ga6...@darkside.tsa.lan
Bug#756492: system-config-printer-kde: Authentication Dialog cannot receive focus
forwarded 756492 https://bugs.kde.org/show_bug.cgi?id=328014 tags 756492 + upstream thanks -- Jim Scadden -- To UNSUBSCRIBE, email to debian-qt-kde-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/201411171652.20687.j...@silentasylum.co.uk
Bug#749577: Dolphin: unable tio create files on cifs mount - dsik full
tags 749577 + upstream forwarded 749577 https://bugs.kde.org/show_bug.cgi?id=334776 thanks On Wed, May 28, 2014 at 11:38:34AM +0200, rollopack wrote: Package: libkio5 Version: 4:4.13.1-1 Severity: important Dear Maintainer, The version 4.13.1-1 of the package introduce the KDE bug 334776 wich cause dolphin to report the error disk full error on file create. Coping and old version of libkio.so.5 (libkio.so.5.13.0 from ubuntu) resolve the bug Pending 4.13.2+ as per upstream bug: Git commit 9a8426ae2ed35ac900b89a623618fc158d24ee6a by Tomáš Trnka. Committed on 25/05/2014 at 14:12. Pushed by ttrnka into branch 'KDE/4.13'. Revert Avoid unnecessary automounting in KDiskFreeSpaceInfo::freeSpaceInfo This reverts commit 6246e99b43f3d1a9e15d563fbb5e173ed50ba5e5. It breaks KIO on CIFS mounts as the check for automounts copied over from frameworks/kfileitem.cpp isDirectoryMounted() apparently matches CIFS as well (and for some weird reason KIO checks for available space before trying to copy files). We'll probably have to return to v1 of the abovementioned commit, i.e. checking for autofs explicitly. However, more testing is apparently necessary to avoid further nasty surprises. REVIEW: 117044 FIXED-IN: 4.13.2 -- Jim Scadden -- To UNSUBSCRIBE, email to debian-qt-kde-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/20140623085710.ga3...@jessie.tsa.lan
Bug#745556: Closing dialog for allowing invalid SSL certificate causes default to be accepted
On Mon, Jun 09, 2014 at 11:43:46AM +0100, Jim Scadden wrote: Attached is a proposed patch which I have forwarded upstream which modifies the behaviour of the dialog box in question so that closing it will return the user back to the previous dialog After testing my patch for a while I do not believe that it is the best approach. With the patch applied the default option of 'Current Session only' is located on the left and the 'Forever' option is in the middle. Since the 'Continue' button on the previous dialog is in the middle this means that a user who neglects to fully read the 2nd dialog box and just clicks will have chosen to accept the certificate forever. Additionally the same logic for invalid SSL certificates is used in other parts of KDE, so any change would further require changes across multiple packages to keep the UI consistent across the DE. Rémi, please could you advise if you would still like the behaviour to be modified? If so, given that the user has already stated on the first dialog box that they wish to connect to the server, and closing the 2nd dialog causes the certificate to only be accepted for the current session, would you be happy for this bug to be tagged as 'wishlist' since this is something could potentially require a substantial change upstream? -- Jim Scadden -- To UNSUBSCRIBE, email to debian-qt-kde-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/20140623123814.gb3...@jessie.tsa.lan
Bug#525599: kdelibs5-data: Unknown media type in type 'all/all'
tag 525599 + upstream patch forwarded 525599 https://bugs.kde.org/show_bug.cgi?id=303627 thanks On Sat, 25 Apr 2009 22:44:13 +0200, Vincent Smeets wrote: During an update with aptitude, I get the following error messages: Setting up kdelibs5-data (4:4.1.0-3) ... Unknown media type in type 'all/all' Unknown media type in type 'all/allfiles' Unknown media type in type 'uri/mms' Unknown media type in type 'uri/mmst' Unknown media type in type 'uri/mmsu' Unknown media type in type 'uri/pnm' Unknown media type in type 'uri/rtspt' Unknown media type in type 'uri/rtspu' Unknown media type in type 'fonts/package' Unknown media type in type 'interface/x-winamp-skin' This is due to fake mime types listed in /usr/share/mime/packages/kde.xml It looks like Gentoo have been using a patch for this for some time: http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/kde-base/kdelibs/files/kdelibs-4.7.96-mimetypes.patch There's also an upstream bug open for this : https://bugs.kde.org/show_bug.cgi?id=303627 I've attached a copy of the Gentoo patch (updated against the copy of kde.xml in kde4libs-4.13.1 -- Jim Scadden --- a/mimetypes/kde.xml +++ b/mimetypes/kde.xml @@ -174,34 +174,6 @@ glob pattern=*.abc/ /mime-type - !-- all/ fake mime types -- - mime-type type=all/all -commentall files and folders/comment - /mime-type - mime-type type=all/allfiles -commentall files/comment - /mime-type - - !-- uri/ fake mime types -- - mime-type type=uri/mms -commentmms: URIs/comment - /mime-type - mime-type type=uri/mmst -commentmmst: URIs/comment - /mime-type - mime-type type=uri/mmsu -commentmmsu: URIs/comment - /mime-type - mime-type type=uri/pnm -commentpnm: URIs/comment - /mime-type - mime-type type=uri/rtspt -commentrtspt: URIs/comment - /mime-type - mime-type type=uri/rtspu -commentrtspu: URIs/comment - /mime-type - mime-type type=application/vnd.kde.fontspackage sub-class-of type=application/zip/ commentfonts package/comment
Bug#641747: Closed?
On Thu, Jun 05, 2014 at 01:54:22PM -0700, Soren Stoutner wrote: This bug is no longer an issue for me (and hasn't been so for a long time). Any reason we shouldn't close it? If you can confirm that the bug is no longer present then I see no reason not to close it. From looking at the bug report it appears that this was a problem with the package browser-plugin-libreoffice rather than konqueror, so if the problem returns then a new bug can always be raised against that package. -- Jim Scadden -- To UNSUBSCRIBE, email to debian-qt-kde-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/20140609084246.gb12...@jessie.tsa.lan
Bug#737396: kscreensaver: locked screen allows any password if a third session (vt9) is also active
On Thu, Jun 05, 2014 at 10:52:54AM +0200, Lajos Mester wrote: I tried to log in a diffrerent order, and came out, that it wasn't the number of the VT-s, but allways the same user who got logged in without a valid password. I have no idea why this happened. And I'm unable to reproduce it any more: I changed the password of that user, and it seems to be OK. Now only with a (valid) password is the login in possible. I would like to know, what could got corrupted, or hijacked. Could you please give me advice? Thanks Try looking at the contents of /var/log/auth* as any PAM errors should be logged there. Alternatively you may want to ask on https://lists.debian.org/debian-user/ As this does not look to be a problem with KDE please could you also close the bugs you have raised in Debian and KDE. http://www.debian.org/Bugs/Developer#closing https://bugs.kde.org/show_bug.cgi?id=330526 -- Jim Scadden -- To UNSUBSCRIBE, email to debian-qt-kde-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/20140609084158.ga12...@jessie.tsa.lan
Bug#745556: kmail accepts invalid SMTP TLS certificate against user action
clone 745556 -1 reassign 745556 libkio5 severity 745556 important retitle 745556 Closing dialog for allowing invalid SSL certificate causes default to be accepted reassign -1 kdepim-runtime retitle -1 Cannot reject invalid SSL certificate for IMAP server as dialog keeps appearing thanks -- Jim Scadden -- To UNSUBSCRIBE, email to debian-qt-kde-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/20140609103226.ga1...@jessie.tsa.lan
Bug#745556: Closing dialog for allowing invalid SSL certificate causes default to be accepted
forwarded 745556 https://bugs.kde.org/show_bug.cgi?id=335375
thanks
Closing the dialog for choosing how long to accept an invalid
certificate for (which gives the options to accept Forever, or for
Current Session Only) causes the default option of Current Session Only
to be accepted
Steps to Reproduce:
1. Attempt to connect to server with invalid SSL certificate in KMail or
similar
2. On 1st dialog that appears (giving details on why the certificate is
invalid), click on Continue
3. Close 2nd dialog rather than selecting one of the 2 available options
The length of time the certificate has been accepted for can be verified
by examining the entry for the certificate in
${HOME}/.kde/share/config/ksslcertificatemanager
Attached is a proposed patch which I have forwarded upstream which
modifies the behaviour of the dialog box in question so that closing it
will return the user back to the previous dialog
--
Jim Scadden
Index: kde4libs-4.13.1/kio/kssl/sslui.cpp
===
--- kde4libs-4.13.1.orig/kio/kssl/sslui.cpp
+++ kde4libs-4.13.1/kio/kssl/sslui.cpp
@@ -75,66 +75,76 @@ bool KIO::SslUi::askIgnoreSslErrors(cons
}
message = message.trimmed();
-int msgResult;
+bool returnToInitialDialog = false;
do {
-msgResult = KMessageBox::warningYesNoCancel(0, message, i18n(Server Authentication),
-KGuiItem(i18n(Details), help-about),
-KGuiItem(i18n(Continue), arrow-right));
-if (msgResult == KMessageBox::Yes) {
-//Details was chosen - show the certificate and error details
-
-QListQListKSslError::Error meh;// parallel list to cert list :/
-
-foreach (const QSslCertificate cert, ud-certificateChain) {
-QListKSslError::Error errors;
-foreach(const KSslError error, ud-sslErrors) {
-if (error.certificate() == cert) {
-// we keep only the error code enum here
-errors.append(error.error());
+int msgResult;
+do {
+msgResult = KMessageBox::warningYesNoCancel(0, message, i18n(Server Authentication),
+KGuiItem(i18n(Details), help-about),
+KGuiItem(i18n(Continue), arrow-right));
+if (msgResult == KMessageBox::Yes) {
+//Details was chosen - show the certificate and error details
+
+
+QListQListKSslError::Error meh;// parallel list to cert list :/
+
+foreach (const QSslCertificate cert, ud-certificateChain) {
+QListKSslError::Error errors;
+foreach(const KSslError error, ud-sslErrors) {
+if (error.certificate() == cert) {
+// we keep only the error code enum here
+errors.append(error.error());
+}
}
+meh.append(errors);
}
-meh.append(errors);
+
+
+KSslInfoDialog *dialog = new KSslInfoDialog();
+dialog-setSslInfo(ud-certificateChain, ud-ip, ud-host, ud-sslProtocol,
+ ud-cipher, ud-usedBits, ud-bits, meh);
+dialog-exec();
+} else if (msgResult == KMessageBox::Cancel) {
+return false;
}
+//fall through on KMessageBox::No
+} while (msgResult == KMessageBox::Yes);
-KSslInfoDialog *dialog = new KSslInfoDialog();
-dialog-setSslInfo(ud-certificateChain, ud-ip, ud-host, ud-sslProtocol,
- ud-cipher, ud-usedBits, ud-bits, meh);
-dialog-exec();
-} else if (msgResult == KMessageBox::Cancel) {
-return false;
-}
-//fall through on KMessageBox::No
-} while (msgResult == KMessageBox::Yes);
+if (storedRules StoreRules) {
+//Save the user's choice to ignore the SSL errors.
+msgResult = KMessageBox::warningYesNoCancel(0,
+i18n(Would you like to accept this
+certificate forever without
+being prompted?),
+i18n(Server Authentication),
+KGuiItem(i18n(Current Session only), chronometer),
+KGuiItem(i18n(Forever), flag-green));
+QDateTime ruleExpiry = QDateTime::currentDateTime();
+if (msgResult == KMessageBox::Cancel) {
+// return to previous dialog
+returnToInitialDialog = true;
+} else {
+if (msgResult
Bug#750995: Cannot reject invalid SSL certificate for IMAP server as dialog keeps appearing
On Tue, Apr 22, 2014 at 10:33:28PM +0300, Rémi Denis-Courmont wrote: The cancel button has no effects other than to bring the same dialog almost instantly back in an infinite loop. I can confirm this behaviour. The cause is that kdepim-runtime treats the SSL cancellation the same as a bad password error and so will re-establish the connection to the IMAP server which causes the same dialog to reappear. There is also another dialog behind which has the option to cancel the connection or change the connection settings however the SSL dialog prevents this dialog from being clickable. This has the side effect that if you eventually give up and accept the certificate, there are numerous bad password dialogs which you have to close. -- Jim Scadden -- To UNSUBSCRIBE, email to debian-qt-kde-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/20140609105132.ga3...@jessie.tsa.lan
Bug#750995: Cannot reject invalid SSL certificate for IMAP server as dialog keeps appearing
forwarded 750995 https://bugs.kde.org/show_bug.cgi?id=335994
tags 750995 + upstream patch
thanks
Bug forwarded to KDE BTS https://bugs.kde.org/show_bug.cgi?id=335994
with patches which provide a workaround
--
Jim Scadden
--- a/kimap/loginjob.cpp
+++ b/kimap/loginjob.cpp
@@ -535,7 +535,7 @@
authState = LoginJobPrivate::Capability;
tags sessionInternal()-sendCommand( CAPABILITY );
} else {
-q-setError( LoginJob::UserDefinedError );
+q-setError( LoginJob::ERR_SSL_FAILED );
q-setErrorText( i18n( Login failed, TLS negotiation failed. ) );
encryptionMode = LoginJob::Unencrypted;
q-emitResult();
@@ -588,7 +588,6 @@
setErrorText( i18n( Connection to server lost. ) );
emitResult();
}
-
}
void LoginJobPrivate::saveServerGreeting(const Message response)
--- a/kimap/loginjob.h
+++ b/kimap/loginjob.h
@@ -60,7 +60,8 @@
};
enum ErrorCode {
- ERR_COULD_NOT_CONNECT = KJob::UserDefinedError + 23 // same as in kio
+ ERR_COULD_NOT_CONNECT = KJob::UserDefinedError + 23, // same as in kio
+ ERR_SSL_FAILED = KJob::UserDefinedError + 128, // outside of values used by kio
};
explicit LoginJob( Session *session );
--- a/resources/imap/sessionpool.cpp
+++ b/resources/imap/sessionpool.cpp
@@ -378,6 +378,11 @@
i18n( Could not connect to the IMAP-server.\n%1,
job-errorString() ) );
}
+} else if ( job-error() == KIMAP::LoginJob::ERR_SSL_FAILED ) {
+ cancelSessionCreation( login-session(),
+ EncryptionError,
+ i18n( Could not connect to the IMAP-server %1.\n%2,
+ m_account-server(), job-errorString() ) );
} else {
// Connection worked, but login failed - ask for a different password or ssl settings.
m_pendingInitialSession = login-session();
Bug#750995: does this bug affect wheezy too?
found 750995 4:4.12.4-2 thanks On Mon, Jun 09, 2014 at 07:56:01PM +0800, Rémi Denis-Courmont wrote: Le 2014-06-09 19:14, Holger Levsen a écrit : does this bug (Cannot reject invalid SSL certificate for IMAP server as dialog keeps appearing) affect wheezy too? Or is that jessie only? TBH, I don't know; I don't have a Wheezy install handy. I have just set up wheezy on a VM and cancelling the connection works as expected. This bug only appears to affect jessie. -- Jim Scadden -- To UNSUBSCRIBE, email to debian-qt-kde-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/20140609155257.gd3...@jessie.tsa.lan
Bug#737396: kscreensaver: locked screen allows any password if a third session (vt9) is also active
On Fri, May 30, 2014 at 09:03:01PM +0200, Lajos Mester wrote: This looks like the authentication is actually passing. Could you try installing pamtester (which is availale for jessie/sid) and run the following command and provide the results: pamtester -v login username authenticate for the user logged on the first VT: pamtester: invoking pam_start(login, the login, ...) pamtester: performing operation - authenticate Password: pamtester: Authentication failure -- with or without a password, even with the correct one. Other users get: pamtester: successfully authenticated What are the corresponding messages in /var/log/auth.log ? -- Jim Scadden -- To UNSUBSCRIBE, email to debian-qt-kde-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/20140603090605.ga11...@jim-debian.shopto.lan
Bug#749769: writing to mounted smb shares fails and no display of free space
reassign 749769 libkio5 4:4.13.1-1 forwarded 749769 https://bugs.kde.org/show_bug.cgi?id=334776 tags 749769 + upstream thanks From upstream bug: Git commit 9a8426ae2ed35ac900b89a623618fc158d24ee6a by Tomáš Trnka. Committed on 25/05/2014 at 14:12. Pushed by ttrnka into branch 'KDE/4.13'. Revert Avoid unnecessary automounting in KDiskFreeSpaceInfo::freeSpaceInfo This reverts commit 6246e99b43f3d1a9e15d563fbb5e173ed50ba5e5. It breaks KIO on CIFS mounts as the check for automounts copied over from frameworks/kfileitem.cpp isDirectoryMounted() apparently matches CIFS as well (and for some weird reason KIO checks for available space before trying to copy files). We'll probably have to return to v1 of the abovementioned commit, i.e. checking for autofs explicitly. However, more testing is apparently necessary to avoid further nasty surprises. REVIEW: 117044 FIXED-IN: 4.13.2 M +0 -10 kio/kfile/kdiskfreespaceinfo.cpp http://commits.kde.org/kdelibs/9a8426ae2ed35ac900b89a623618fc158d24ee6a -- Jim Scadden -- To UNSUBSCRIBE, email to debian-qt-kde-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/20140531094810.ga4...@wheezy.tsa.lan
Bug#737396: kscreensaver: locked screen allows any password if a third session (vt9) is also active
On Tue, May 27, 2014 at 06:50:01PM +0200, Lajos Mester wrote: * What authentication type is PAM using (e.g. shadow, ldap, krb5) ? How do I know it? Unless you have changed it, the default should be shadow. Documentation for PAM is available at http://www.linux-pam.org/ * What is the result of the following command on the different VTs with an invalid password: /usr/lib/kde4/libexec/kcheckpass; echo $? Trying to log in on the standard terminals. Even there, the user who is logged in on the first K-VT, get's logged in without a pass. For this user the command above gives 0, for the others authentication failure 1. This looks like the authentication is actually passing. Could you try installing pamtester (which is availale for jessie/sid) and run the following command and provide the results: pamtester -v login username authenticate -- Jim Scadden -- To UNSUBSCRIBE, email to debian-qt-kde-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/20140529204729.ga4...@wheezy.tsa.lan
Bug#745556: kmail accepts invalid SMTP TLS certificate against user action
On Tue, Apr 22, 2014 at 10:33:28PM +0300, Rémi Denis-Courmont wrote: The continue button yields another dialog letting the user choose how long to accept the certificate, either forever, or only for the current session. If the dialog is closed without answer, Kmail assumes forever. At that point, the mail feeder will happily send user credentials over to the untrusted server. This is a problem with kio. Closing the dialog causes the default option to be selected. I have raised this in KDE BTS along with a proposed patch: https://bugs.kde.org/show_bug.cgi?id=335375 -- Jim Scadden -- To UNSUBSCRIBE, email to debian-qt-kde-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/20140526154549.gb4...@wheezy.tsa.lan
Bug#737396: kscreensaver: locked screen allows any password if a third session (vt9) is also active
tags 737396 + moreinfo stop Hi Lajos, I have been unable to reproduce this bug with the current versions of kscreensaver in wheezy (4:4.8.4-5) and jessie (4:4.12.4-1). Please could you advise the following to help reproduce the problem: * Are all of VT sessions logged in as different users? * Are there any errors in /var/log/auth.log ? * Are there any errors in ~/.xsession-errors ? * What authentication type is PAM using (e.g. shadow, ldap, krb5) ? * What is the result of the following command on the different VTs with an invalid password: /usr/lib/kde4/libexec/kcheckpass; echo $? Thanks -- Jim Scadden -- To UNSUBSCRIBE, email to debian-qt-kde-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/20140525073218.ga4...@wheezy.tsa.lan
Bug#631671: Running a kommander script fails
tags 631671 + upstream patch forwarded 631671 http://bugs.kde.org/show_bug.cgi?id=335327 thanks Patch forwarded upstream -- Jim Scadden -- To UNSUBSCRIBE, email to debian-qt-kde-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/20140525101604.gb4...@wheezy.tsa.lan
Bug#565978: kommander does not recognize --stdin option
tags 565978 + patch
thanks
Patch created and forwarded upstream
Also requires the use of patch(es) in bug #631671 for kommander to run
--
Jim Scadden
Index: kdewebdev-4.12.3/kommander/executor/instance.cpp
===
--- kdewebdev-4.12.3.orig/kommander/executor/instance.cpp
+++ kdewebdev-4.12.3/kommander/executor/instance.cpp
@@ -102,7 +102,7 @@ bool Instance::build(const KUrl fname)
m_instance = 0;
m_textInstance = 0;
- if (!fname.isValid() || !isFileValid(fname))
+ if (fname.isValid() !isFileValid(fname))
return false; // Check if file is correct
// create the main instance, must inherit QDialog
Index: kdewebdev-4.12.3/kommander/executor/main.cpp
===
--- kdewebdev-4.12.3.orig/kommander/executor/main.cpp
+++ kdewebdev-4.12.3/kommander/executor/main.cpp
@@ -80,7 +80,7 @@ int main(int argc, char *argv[])
KApplication app;
QObject::connect(app, SIGNAL(lastWindowClosed()), app, SLOT(quit()));
- if (!args-count())
+ if (!args-isSet(stdin) !args-count())
{
KMessageBox::sorry(0, i18n(Error: no dialog given. Use --stdin option to read dialog from standard input.\n));
return -1;
Bug#631671: Running a kommander script fails
On Sunday 18 May 2014 at 10:13:57, ewe2 wrote:
I tried to build this with the patch on the 4.12.3-2 Debian source and
dh_install failed with:
dh_install
cp: cannot stat ‘debian/tmp/usr/lib/libcommanderwidgets.so’: No such file
or directory
dh_install: cp -a debian/tmp/usr/lib/libcommanderwidgets.so
debian/kommander//usr/lib/ returned exit code 1libcommanderwidgets.so
/usr/share/pkg-kde-tools/qt-kde-team/2/dhmk.mk:97: recipe for target
'pre_install_dh_install' failed
make[1]: *** [pre_install_dh_install] Error 2
make[1]: Leaving directory '/pub/deb/kdewebdev-4.12.3'
/usr/share/pkg-kde-tools/qt-kde-team/2/dhmk.mk:110: recipe for target
'debian/dhmk_install' failed
make: *** [debian/dhmk_install] Error 2
Did you apply the patch manually? The error shows dh_install was looking for
libcommanderwidgets.so but the patch added libkommanderwidgets.so (with a k)
to debian/kommander.install , so perhaps this was a typo?
On Sun, May 18, 2014 at 6:15 PM, Maximiliano Curia m...@debian.org wrote:
Oh, it's a missing plugin. kde4 plugins should be installed in under the
/usr/lib/kde4/ tree, and avoid poluting /usr/lib
The debian package contains .so.4.2.0 and .so.4 but not .so
The .4 and .4.2.0 files could probably be not-installed.
The attached patch resolves the problem by including
libkommanderwidgets.so back in to the package.
Could you update the patch to install the plugins in /usr/lib/kde4/ ?
You're correct. I have modified the CMakeList.txt files so that it is built as
a
plugin with only a .so and installed to /usr/lib/kde4/ . There was also a
runtime warning that plugins should not have a 'lib' prefix so I have also
fixed
this.
I have attached a new patch for the upstream source and an updated patch for
debian/not-installed and debian/kommander.install
I have built packages using the patches on wheezy jessie and also used
pbuilder to build against sid.
Please let me know if any further modifications are necessary. If everything is
ok then I would be happy to submit the upstream patch to the KDE BTS.
Thanks
--
Jim Scadden
--- a/debian/kommander.install
+++ b/debian/kommander.install
@@ -1,6 +1,5 @@
usr/bin/kommander
usr/lib/libkommandercore.so.4
usr/lib/libkommandercore.so.4.2.0
-usr/lib/libkommanderwidgets.so.4
-usr/lib/libkommanderwidgets.so.4.2.0
+usr/lib/kde4/kommanderwidgets.so
usr/share/applnk/.hidden/kommander.desktop
--- a/debian/not-installed
+++ b/debian/not-installed
@@ -5,6 +5,5 @@
./usr/include/specials.h
./usr/lib/libklinkstatuscommon.so
./usr/lib/libkommandercore.so
-./usr/lib/libkommanderwidgets.so
./usr/share/dbus-1/interfaces/org.kde.kdewebdev.klinkstatus.SearchManager.xml
./usr/share/dbus-1/interfaces/org.kde.kfilereplace.xml
--- a/kommander/widgets/CMakeLists.txt
+++ b/kommander/widgets/CMakeLists.txt
@@ -13,7 +13,7 @@
### next target ###
-SET(kommanderwidgets_LIB_SRCS
+SET(kommanderwidgets_PART_SRCS
aboutdialog.cpp
fontdialog.cpp
buttongroup.cpp
@@ -50,7 +50,7 @@
wizard.cpp
)
-KDE4_ADD_LIBRARY(kommanderwidgets SHARED ${kommanderwidgets_LIB_SRCS})
+kde4_add_plugin(kommanderwidgets ${kommanderwidgets_PART_SRCS})
### next target ###
@@ -98,9 +98,7 @@
${KDE4_KIO_LIBS}
)
-SET_TARGET_PROPERTIES(kommanderwidgets PROPERTIES VERSION 4.2.0 SOVERSION 4 )
-INSTALL(TARGETS kommanderwidgets ${INSTALL_TARGETS_DEFAULT_ARGS})
-
+install(TARGETS kommanderwidgets DESTINATION ${PLUGIN_INSTALL_DIR})
### install files ###
--- a/kommander/executor/CMakeLists.txt
+++ b/kommander/executor/CMakeLists.txt
@@ -24,7 +24,6 @@
TARGET_LINK_LIBRARIES(
kommander
kommandercore
- kommanderwidgets
${KDE4_KDEUI_LIBS}
)
--- a/kommander/lib/kommanderfactory.cpp
+++ b/kommander/lib/kommanderfactory.cpp
@@ -410,7 +410,7 @@
KConfig config ( kommanderrc );
KConfigGroup cfg ( config, plugins );
QStringList plugins;
-plugins libkommanderwidgets;
+plugins kommanderwidgets;
plugins += cfg.readEntry ( plugins, QStringList() );
kDebug() Plugins: plugins;
QStringList::Iterator it;
Bug#631671: Running a kommander script fails
I can confirmed that this bug is still present in the current versions for wheezy (4:4.8.4-1) and jessie (4:4.12.3-2) I am unable to run any of the example .kmdr files provided in the source package or any .kmdr files from kde-look.org $ kommander kommander/examples/tutorial/calc.kmdr kommander(10045)/kdecore (KLibrary) findLibraryInternal: plugins should not have a 'lib' prefix: libkommanderwidgets.so kommander(10045) KommanderFactory::loadPlugins: KommanderFactory::loadPlugins - Can't load Kommander plugin library libkommanderwidgets An strace shows that kommander is trying to load libkommanderwidgets.so : access(/home/jim/.kde/lib/kde4/libkommanderwidgets.so, R_OK) = -1 ENOENT (No such file or directory) access(/usr/lib/kde4/libkommanderwidgets.so, R_OK) = -1 ENOENT (No such file or directory) access(/home/jim/.kde/lib/libkommanderwidgets.so, R_OK) = -1 ENOENT (No such file or directory) access(/usr/lib/libkommanderwidgets.so, R_OK) = -1 ENOENT (No such fileor directory) The debian package contains .so.4.2.0 and .so.4 but not .so The attached patch resolves the problem by including libkommanderwidgets.so back in to the package. -- Jim Scadden --- a/debian/kommander.install +++ b/debian/kommander.install @@ -1,6 +1,7 @@ usr/bin/kommander usr/lib/libkommandercore.so.4 usr/lib/libkommandercore.so.4.2.0 +usr/lib/libkommanderwidgets.so usr/lib/libkommanderwidgets.so.4 usr/lib/libkommanderwidgets.so.4.2.0 usr/share/applnk/.hidden/kommander.desktop --- a/debian/not-installed +++ b/debian/not-installed @@ -5,6 +5,5 @@ ./usr/include/specials.h ./usr/lib/libklinkstatuscommon.so ./usr/lib/libkommandercore.so -./usr/lib/libkommanderwidgets.so ./usr/share/dbus-1/interfaces/org.kde.kdewebdev.klinkstatus.SearchManager.xml ./usr/share/dbus-1/interfaces/org.kde.kfilereplace.xml
Bug#651548: kdm: Non usable system
You reported a bug some time ago in kdm Please could you confirm if this bug is still present or if it was caused by a bug in the nVidia drivers as described in https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=651155 -- Jim Scadden -- To UNSUBSCRIBE, email to debian-qt-kde-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/20140517155952.ga3...@wheezy.tsa.lan
Bug#530386: kmail: crash when i click in the listview of messages exceeding size
tags 530386 + moreinfo thanks Hi I have not been able to reproduce this bug with the latest version of KMail in stable 4.4.11.1+l10n-3+b1 Given the age of this bug report please could you confirm if you are still experiencing this issue or let me know if the bug can now be closed. Thanks -- Jim Scadden -- To UNSUBSCRIBE, email to debian-qt-kde-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/201405142200.24480.j...@silentasylum.co.uk
Query: Old tickets tagged as 'wontfix'
Hi In response to the recent call for help I thought I would offer my assistance by going through some of the old bugs in BTS. I am new to this so I have read through what documentation I have found, however documentation can never cover everything. I have noticed that there are some old wishlist bugs where were reported upstream, who resolved their bug as wontfix. The Debian bug was subsequently marked as wontfix but never closed. Is there a reason why these bugs should still be open, or can they be closed? As an example: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=101379 https://bugs.kde.org/show_bug.cgi?id=32192 Thanks -- Jim Scadden -- To UNSUBSCRIBE, email to debian-qt-kde-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/201405111304.13173@silentasylum.co.uk
