Bug#892594: plasma-discover: Invalid Kaddressbook_themes backend

2018-05-02 Thread Maximiliano Curia

¡Hola Matthias!

El 2018-03-11 a las 10:01 +0100, luca escribió:

Package: plasma-discover
Version: 5.12.2-1
Severity: normal



on start discover return this error:



org.kde.knewstuff.core: Could not find category "KAddressbook Theme"
invalid kns backend! "/etc/xdg/kaddressbook_themes.knsrc" because: "All
categories are missing"
Discarding invalid backend "kaddressbook_themes.knsrc"
qrc:/qml/DiscoverDrawer.qml:145: TypeError: Cannot read property 'name' of null
kns error "/etc/xdg/kaddressbook_themes.knsrc" "Invalid Kaddressbook_themes
backend, contact your distributor."
qml: message: kaddressbook_themes.knsrc: Invalid Kaddressbook_themes backend,
contact your distributor.


Matthias is the expert regarding plasma-discover, but it seems to me that it 
could skip the backend if it's invalid. Something like this:


diff --git a/libdiscover/Category/CategoryModel.cpp 
b/libdiscover/Category/CategoryModel.cpp
index 2e6835b5..b9876938 100644
--- a/libdiscover/Category/CategoryModel.cpp
+++ b/libdiscover/Category/CategoryModel.cpp
@@ -49,6 +49,9 @@ void CategoryModel::populateCategories()
QVector ret;
CategoriesReader cr;
Q_FOREACH (const auto backend, backends) {
+if (!backend->isValid())  {
+continue;
+}
const QVector cats = cr.loadCategoriesFile(backend);

if(ret.isEmpty()) {

I guess this kind of errors could happend by a network hiccup.

Happy hacking,
--
A computer scientist is someone who, when told to "Go to Hell," 
sees the "go to," rather than the destination, as harmful.

Saludos /\/\ /\ >< `/


signature.asc
Description: PGP signature


Bug#892594: plasma-discover: Invalid Kaddressbook_themes backend

2018-03-11 Thread luca
Package: plasma-discover
Version: 5.12.2-1
Severity: normal

Dear Maintainer,

on start discover return this error:

org.kde.knewstuff.core: Could not find category "KAddressbook Theme"
invalid kns backend! "/etc/xdg/kaddressbook_themes.knsrc" because: "All
categories are missing"
Discarding invalid backend "kaddressbook_themes.knsrc"
qrc:/qml/DiscoverDrawer.qml:145: TypeError: Cannot read property 'name' of null
kns error "/etc/xdg/kaddressbook_themes.knsrc" "Invalid Kaddressbook_themes
backend, contact your distributor."
qml: message: kaddressbook_themes.knsrc: Invalid Kaddressbook_themes backend,
contact your distributor.




-- System Information:
Debian Release: buster/sid
  APT prefers testing-debug
  APT policy: (500, 'testing-debug'), (500, 'testing')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.14.0-3-amd64 (SMP w/4 CPU cores)
Locale: LANG=it_IT.UTF-8, LC_CTYPE=it_IT.UTF-8 (charmap=UTF-8), LANGUAGE= 
(charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages plasma-discover depends on:
ii  appstream 0.11.8-3
ii  kio   5.42.0-3
ii  libappstreamqt2   0.11.8-3
ii  libc6 2.27-1
ii  libkf5attica5 5.42.0-2
ii  libkf5configcore5 5.42.0-2
ii  libkf5configwidgets5  5.42.0-2
ii  libkf5coreaddons5 5.42.0-2
ii  libkf5crash5  5.42.0-2
ii  libkf5dbusaddons5 5.42.0-2
ii  libkf5declarative55.42.0-2
ii  libkf5i18n5   5.42.0-3
ii  libkf5itemmodels5 5.42.0-2
ii  libkf5kiocore55.42.0-3
ii  libkf5kiowidgets5 5.42.0-3
ii  libkf5newstuffcore5   5.42.0-2
ii  libkf5notifications5  5.42.0-2
ii  libkf5service-bin 5.42.0-2
ii  libkf5service55.42.0-2
ii  libkf5widgetsaddons5  5.42.1-2
ii  libkf5xmlgui5 5.42.0-2
ii  libpackagekitqt5-11.0.1-1
ii  libqt5core5a  5.9.2+dfsg-12
ii  libqt5dbus5   5.9.2+dfsg-12
ii  libqt5gui55.9.2+dfsg-12
ii  libqt5network55.9.2+dfsg-12
ii  libqt5qml55.9.2-3
ii  libqt5quick5  5.9.2-3
ii  libqt5widgets55.9.2+dfsg-12
ii  libqt5xml55.9.2+dfsg-12
ii  libstdc++68-20180218-1
ii  packagekit1.1.7-1
ii  plasma-discover-common5.12.2-1
ii  qml-module-org-kde-kirigami2  5.42.0-3

Versions of packages plasma-discover recommends:
ii  software-properties-kde  0.96.20.2-1

Versions of packages plasma-discover suggests:
pn  plasma-discover-backend-flatpak  

-- no debconf information