Bug#862961: jessie-pu: package libembperl-perl/2.5.0-4+deb8u1

[Adam D. Barratt]

Control: tags -1 + pending

On Tue, 2017-08-08 at 17:49 -0400, gregor herrmann wrote:
> On Tue, 08 Aug 2017 15:44:48 -0400, Adam D. Barratt wrote:
> 
> > > > I'm attaching the full new debdiff, and I'm looping in Axel for a sanity
> > > > check.
> > > I won't be tagging this bug report with +confirmed right away, since we're
> > > awaiting for some more feedback, but the proposed changes look good to me.
> > Me too. Based on the subsequent responses, please go ahead.
> 
> Thank you! Uploaded.

Flagged for acceptance into o-p-u; thanks.

Regards,

Adam

Processed: Re: Bug#862961: jessie-pu: package libembperl-perl/2.5.0-4+deb8u1

[Debian Bug Tracking System]

Processing control commands:

> tags -1 + pending
Bug #862961 [release.debian.org] jessie-pu: package 
libembperl-perl/2.5.0-4+deb8u1
Added tag(s) pending.

-- 
862961: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=862961
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

Bug#862961: jessie-pu: package libembperl-perl/2.5.0-4+deb8u1

[gregor herrmann]

On Tue, 08 Aug 2017 15:44:48 -0400, Adam D. Barratt wrote:

> > > I'm attaching the full new debdiff, and I'm looping in Axel for a sanity
> > > check.
> > I won't be tagging this bug report with +confirmed right away, since we're
> > awaiting for some more feedback, but the proposed changes look good to me.
> Me too. Based on the subsequent responses, please go ahead.

Thank you! Uploaded.

Cheers,
gregor

-- 
 .''`.  https://info.comodo.priv.at/ - Debian Developer https://www.debian.org
 : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D  85FA BB3A 6801 8649 AA06
 `. `'  Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
   `-   


signature.asc
Description: Digital Signature

Bug#862961: jessie-pu: package libembperl-perl/2.5.0-4+deb8u1

[Adam D. Barratt]

Control: tags -1 -moreinfo +confirmed

On Fri, 2017-06-30 at 05:07 +0200, Cyril Brulebois wrote:
> Hi,
> 
> gregor herrmann  (2017-06-28):
> > On Wed, 28 Jun 2017 00:51:33 +0200, Cyril Brulebois wrote:
> > > I haven't matched this to code changes at first glance. For the sake
> > > of clarity: this relates to the Depends → Recommends update, because
> > > code was added to “apache2_invoke enmode perl” where needed?
> > 
> > Thanks for asking; this made me look at the changes again, and made me
> > realize that I made a mistake (I took only one of Axel's commits between
> > 2.5.0-4 and 2.5.0-5 but there were actually three). Sorry for that.
> >  
> > > (The second sentence makes it look like this /was/ the case already, while
> > > this seems to /become/ the case with this particular upload AFAIUI.)
> > 
> > The problem in #810655, as I understand it, is that d/control has
> > libapache2-mod-perl2 in Recommends (which is correct as embperl doesn't
> > require it) but that embperl's /etc/apache2/mods-available/zembperl.load
> > unconditionally tried to load mod_perl.
> 
> 
> > Axel has in a later commit removed the changes in libembperl-perl.postinst
> > again, after verifying that embperl installs without mod_perl, with mod_perl
> > installed and activated and with mod_perl installed but disabled.
> 
> Tests are good. :)
> 
> > So the only remaining code change is actually:
> > 
> > #v+
> > --- a/debian/zembperl.load.in
> > +++ b/debian/zembperl.load.in
> > @@ -1,6 +1,6 @@
> >  # The sucky "zembperl" name is so we load after perl
> > 
> > -# Depends: perl
> > +# Recommends: perl
> > 
> >  
> >LoadModule embperl_module @ARCHLIB@/auto/Embperl/Embperl.so
> > #v-
> > 
> > 
> > I've now tentatively changed d/changelog to say
> > 
> > #v+
> >   * Change hard dependency on mod_perl in zembperl.load to Recommends.
> > mod_perl is not required, and is enabled by default anyway if it is
> > installed.
> > This change matches the package dependencies and fixes an installation
> > failure when libapache2-mod-perl2 is not installed.
> > (Closes: #810655)
> > #v-
> > 
> > 
> > Does this make sense?
> 
> I think the situation is clearer with your explanations above, and the
> changes+changelog look in sync and reasonable.
> 
> > I'm attaching the full new debdiff, and I'm looping in Axel for a sanity
> > check.
> 
> I won't be tagging this bug report with +confirmed right away, since we're
> awaiting for some more feedback, but the proposed changes look good to me.

Me too. Based on the subsequent responses, please go ahead.

Regards,

Adam

Processed: Re: Bug#862961: jessie-pu: package libembperl-perl/2.5.0-4+deb8u1

[Debian Bug Tracking System]

Processing control commands:

> tags -1 -moreinfo +confirmed
Bug #862961 [release.debian.org] jessie-pu: package 
libembperl-perl/2.5.0-4+deb8u1
Removed tag(s) moreinfo.
Bug #862961 [release.debian.org] jessie-pu: package 
libembperl-perl/2.5.0-4+deb8u1
Added tag(s) confirmed.

-- 
862961: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=862961
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

Bug#862961: jessie-pu: package libembperl-perl/2.5.0-4+deb8u1

[gregor herrmann]

On Thu, 13 Jul 2017 13:05:31 +0200, Axel Beckert wrote:

> Cyril Brulebois wrote:
> > gregor herrmann  (2017-06-28):

> > > #v+
> > > --- a/debian/zembperl.load.in
> > > +++ b/debian/zembperl.load.in
> > > @@ -1,6 +1,6 @@
> > >  # The sucky "zembperl" name is so we load after perl
> > > 
> > > -# Depends: perl
> > > +# Recommends: perl
> > > 
> > >  
> > >LoadModule embperl_module @ARCHLIB@/auto/Embperl/Embperl.so
> > > #v-
> > > 
> > > 
> > > I've now tentatively changed d/changelog to say
> > > 
> > > #v+
> > >   * Change hard dependency on mod_perl in zembperl.load to Recommends.
> > > mod_perl is not required, and is enabled by default anyway if it is
> > > installed.
> > > This change matches the package dependencies and fixes an installation
> > > failure when libapache2-mod-perl2 is not installed.
> > > (Closes: #810655)
> > > #v-
> > > 
> > > 
> > > Does this make sense?
> > 
> > I think the situation is clearer with your explanations above, and the
> > changes+changelog look in sync and reasonable.
> 
> *nod* Looks fine to me, too.

Thanks Axel for checking and confirming!
 

Cheers,
gregor

-- 
 .''`.  https://info.comodo.priv.at/ - Debian Developer https://www.debian.org
 : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D  85FA BB3A 6801 8649 AA06
 `. `'  Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
   `-   NP: Frank Zappa: Theme from RUN HOME SLOW


signature.asc
Description: Digital Signature

Bug#862961: jessie-pu: package libembperl-perl/2.5.0-4+deb8u1

[Axel Beckert]

Hi,

Cyril Brulebois wrote:
> gregor herrmann  (2017-06-28):
> > So the only remaining code change is actually:
> > 
> > #v+
> > --- a/debian/zembperl.load.in
> > +++ b/debian/zembperl.load.in
> > @@ -1,6 +1,6 @@
> >  # The sucky "zembperl" name is so we load after perl
> > 
> > -# Depends: perl
> > +# Recommends: perl
> > 
> >  
> >LoadModule embperl_module @ARCHLIB@/auto/Embperl/Embperl.so
> > #v-
> > 
> > 
> > I've now tentatively changed d/changelog to say
> > 
> > #v+
> >   * Change hard dependency on mod_perl in zembperl.load to Recommends.
> > mod_perl is not required, and is enabled by default anyway if it is
> > installed.
> > This change matches the package dependencies and fixes an installation
> > failure when libapache2-mod-perl2 is not installed.
> > (Closes: #810655)
> > #v-
> > 
> > 
> > Does this make sense?
> 
> I think the situation is clearer with your explanations above, and the
> changes+changelog look in sync and reasonable.

*nod* Looks fine to me, too.

> > I'm attaching the full new debdiff, and I'm looping in Axel for a sanity
> > check.
> 
> I won't be tagging this bug report with +confirmed right away, since we're
> awaiting for some more feedback, but the proposed changes look good to me.

No objections from my side. I only vaguely remember the case back
then, but I do remember that there were issues if mod_perl wasn't
installed despite Embperl can be used without, e.g. as CGI.

Regards, Axel
-- 
 ,''`.  |  Axel Beckert , http://people.debian.org/~abe/
: :' :  |  Debian Developer, ftp.ch.debian.org Admin
`. `'   |  4096R: 2517 B724 C5F6 CA99 5329  6E61 2FF9 CD59 6126 16B5
  `-|  1024D: F067 EA27 26B9 C3FC 1486  202E C09E 1D89 9593 0EDE


signature.asc
Description: Digital signature

Bug#862961: jessie-pu: package libembperl-perl/2.5.0-4+deb8u1

[Cyril Brulebois]

Hi,

gregor herrmann  (2017-06-28):
> On Wed, 28 Jun 2017 00:51:33 +0200, Cyril Brulebois wrote:
> > I haven't matched this to code changes at first glance. For the sake
> > of clarity: this relates to the Depends → Recommends update, because
> > code was added to “apache2_invoke enmode perl” where needed?
> 
> Thanks for asking; this made me look at the changes again, and made me
> realize that I made a mistake (I took only one of Axel's commits between
> 2.5.0-4 and 2.5.0-5 but there were actually three). Sorry for that.
>  
> > (The second sentence makes it look like this /was/ the case already, while
> > this seems to /become/ the case with this particular upload AFAIUI.)
> 
> The problem in #810655, as I understand it, is that d/control has
> libapache2-mod-perl2 in Recommends (which is correct as embperl doesn't
> require it) but that embperl's /etc/apache2/mods-available/zembperl.load
> unconditionally tried to load mod_perl.


> Axel has in a later commit removed the changes in libembperl-perl.postinst
> again, after verifying that embperl installs without mod_perl, with mod_perl
> installed and activated and with mod_perl installed but disabled.

Tests are good. :)

> So the only remaining code change is actually:
> 
> #v+
> --- a/debian/zembperl.load.in
> +++ b/debian/zembperl.load.in
> @@ -1,6 +1,6 @@
>  # The sucky "zembperl" name is so we load after perl
> 
> -# Depends: perl
> +# Recommends: perl
> 
>  
>LoadModule embperl_module @ARCHLIB@/auto/Embperl/Embperl.so
> #v-
> 
> 
> I've now tentatively changed d/changelog to say
> 
> #v+
>   * Change hard dependency on mod_perl in zembperl.load to Recommends.
> mod_perl is not required, and is enabled by default anyway if it is
> installed.
> This change matches the package dependencies and fixes an installation
> failure when libapache2-mod-perl2 is not installed.
> (Closes: #810655)
> #v-
> 
> 
> Does this make sense?

I think the situation is clearer with your explanations above, and the
changes+changelog look in sync and reasonable.

> I'm attaching the full new debdiff, and I'm looping in Axel for a sanity
> check.

I won't be tagging this bug report with +confirmed right away, since we're
awaiting for some more feedback, but the proposed changes look good to me.


KiBi.


signature.asc
Description: Digital signature

Bug#862961: jessie-pu: package libembperl-perl/2.5.0-4+deb8u1

[gregor herrmann]

On Wed, 28 Jun 2017 00:51:33 +0200, Cyril Brulebois wrote:

> > I've prepared an update for libembperl-perl in jessie to fix #810655
> > there as well. The changes are just the targetted fix taken from -5
> > without changes. Full debdiff attached.
> 
> > diff --git a/debian/changelog b/debian/changelog
> > index b59bf9e..e296d69 100644
> > --- a/debian/changelog
> > +++ b/debian/changelog
> > @@ -1,3 +1,11 @@
> > +libembperl-perl (2.5.0-4+deb8u1) UNRELEASED; urgency=medium
> > +
> > +  [ Axel Beckert ]
> > +  * Drop hard a2enmod dependency on mod_perl in zembperl.load. mod_perl is
> > +enabled by default anyways if installed. (Closes: #810655)
> > +
> > + -- gregor herrmann   Fri, 19 May 2017 13:09:03 +0200
> > +
> 
> I haven't matched this to code changes at first glance. For the sake of
> clarity: this relates to the Depends → Recommends update, because code
> was added to “apache2_invoke enmode perl” where needed?

Thanks for asking; this made me look at the changes again, and made
me realize that I made a mistake (I took only one of Axel's commits
between 2.5.0-4 and 2.5.0-5 but there were actually three). Sorry for
that.
 
> (The second sentence makes it look like this /was/ the case already,
> while this seems to /become/ the case with this particular upload
> AFAIUI.)

The problem in #810655, as I understand it, is that d/control has
libapache2-mod-perl2 in Recommends (which is correct as embperl
doesn't require it) but that embperl's
/etc/apache2/mods-available/zembperl.load unconditionally tried to
load mod_perl.
 

Axel has in a later commit removed the changes in libembperl-perl.postinst
again, after verifying that embperl installs without mod_perl, with
mod_perl installed and activated and with mod_perl installed but
disabled.


So the only remaining code change is actually:

#v+
--- a/debian/zembperl.load.in
+++ b/debian/zembperl.load.in
@@ -1,6 +1,6 @@
 # The sucky "zembperl" name is so we load after perl

-# Depends: perl
+# Recommends: perl

 
   LoadModule embperl_module @ARCHLIB@/auto/Embperl/Embperl.so
#v-


I've now tentatively changed d/changelog to say

#v+
  * Change hard dependency on mod_perl in zembperl.load to Recommends.
mod_perl is not required, and is enabled by default anyway if it is
installed.
This change matches the package dependencies and fixes an installation
failure when libapache2-mod-perl2 is not installed.
(Closes: #810655)
#v-


Does this make sense?


I'm attaching the full new debdiff, and I'm looping in Axel for a
sanity check.


Cheers,
gregor


-- 
 .''`.  https://info.comodo.priv.at/ - Debian Developer https://www.debian.org
 : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D  85FA BB3A 6801 8649 AA06
 `. `'  Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
   `-   NP: Tom Waits: Sins Of My Father
diff --git a/debian/changelog b/debian/changelog
index b59bf9e..b2e9d48 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,15 @@
+libembperl-perl (2.5.0-4+deb8u1) UNRELEASED; urgency=medium
+
+  [ Axel Beckert ]
+  * Change hard dependency on mod_perl in zembperl.load to Recommends.
+mod_perl is not required, and is enabled by default anyway if it is
+installed.
+This change matches the package dependencies and fixes an installation
+failure when libapache2-mod-perl2 is not installed.
+(Closes: #810655)
+
+ -- gregor herrmann   Fri, 19 May 2017 13:09:03 +0200
+
 libembperl-perl (2.5.0-4) unstable; urgency=low
 
   [ Salvatore Bonaccorso ]
diff --git a/debian/zembperl.load.in b/debian/zembperl.load.in
index ce9542b..91bb120 100644
--- a/debian/zembperl.load.in
+++ b/debian/zembperl.load.in
@@ -1,6 +1,6 @@
 # The sucky "zembperl" name is so we load after perl
 
-# Depends: perl
+# Recommends: perl
 
 
   LoadModule embperl_module @ARCHLIB@/auto/Embperl/Embperl.so


signature.asc
Description: Digital Signature

Processed: Re: Bug#862961: jessie-pu: package libembperl-perl/2.5.0-4+deb8u1

[Debian Bug Tracking System]

Processing control commands:

> tag -1 moreinfo
Bug #862961 [release.debian.org] jessie-pu: package 
libembperl-perl/2.5.0-4+deb8u1
Added tag(s) moreinfo.

-- 
862961: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=862961
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

Bug#862961: jessie-pu: package libembperl-perl/2.5.0-4+deb8u1

[Cyril Brulebois]

Control: tag -1 moreinfo

Hi,

gregor herrmann  (2017-05-19):
> Package: release.debian.org
> Severity: normal
> Tags: jessie
> User: release.debian@packages.debian.org
> Usertags: pu
> 
> I've prepared an update for libembperl-perl in jessie to fix #810655
> there as well. The changes are just the targetted fix taken from -5
> without changes. Full debdiff attached.

> diff --git a/debian/changelog b/debian/changelog
> index b59bf9e..e296d69 100644
> --- a/debian/changelog
> +++ b/debian/changelog
> @@ -1,3 +1,11 @@
> +libembperl-perl (2.5.0-4+deb8u1) UNRELEASED; urgency=medium
> +
> +  [ Axel Beckert ]
> +  * Drop hard a2enmod dependency on mod_perl in zembperl.load. mod_perl is
> +enabled by default anyways if installed. (Closes: #810655)
> +
> + -- gregor herrmann   Fri, 19 May 2017 13:09:03 +0200
> +

I haven't matched this to code changes at first glance. For the sake of
clarity: this relates to the Depends → Recommends update, because code
was added to “apache2_invoke enmode perl” where needed?

(The second sentence makes it look like this /was/ the case already,
while this seems to /become/ the case with this particular upload
AFAIUI.)

Confirmation (and possibly reworded changelog if you agree) welcome.


KiBi.


signature.asc
Description: Digital signature

Bug#862961: jessie-pu: package libembperl-perl/2.5.0-4+deb8u1

[gregor herrmann]

Package: release.debian.org
Severity: normal
Tags: jessie
User: release.debian@packages.debian.org
Usertags: pu

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512

I've prepared an update for libembperl-perl in jessie to fix #810655
there as well. The changes are just the targetted fix taken from -5
without changes. Full debdiff attached.


Cheers,
gregor

-BEGIN PGP SIGNATURE-

iQKTBAEBCgB9FiEE0eExbpOnYKgQTYX6uzpoAYZJqgYFAlke0/FfFIAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEQx
RTEzMTZFOTNBNzYwQTgxMDREODVGQUJCM0E2ODAxODY0OUFBMDYACgkQuzpoAYZJ
qgbSgw//acSQN47Vj8siqhUaKCJILhRkL7fsfLMKKrH1qLNrdtsKFj9o/z+YGjuJ
f+ZU0yN3l3SckcQzgFBqlXIStqIoKV2JevIjA93wpV2VEZUOuzfPmXdDgcSd0pcx
g6uIAfXarxYgVKV2fRVQbyMGz1E3+lQk2sbOwCd+VHoED0NiCNFpmmZ5cSB6cEAf
KuurqpwSqOjRXWSLm6T9O0gNNLOT2yUxKH4vCZ+s4XktIktP1fXvVx8sllUGS9Zs
pX2LGMxHL3CgyVxhpF8yTK8GEqqziHVSBIkpYwY7t+dI1PX4qeAol9rL0X3mlISV
HVOxmk3xLx4hPTc6Gon7z5+d8b287+75b4JWR5GhgmmzQo2GnJWR/pE2cNH/6zpb
fW/xK6xWke22ngihrrjXzQEttCAlGa8QtenWjqcKs21Xf/29Qns/o3yptsEdCYwX
K92QzmOvtFNVheRVC5GiOrqyrEw6strcweCWvhrieudjVqrKSOXbpVveFu8RWn5j
xossC0bqeMKgIuj98J7SEcGCAkoNkX6R5w5KyQ/MxC5DYcY+Zl5xiJrXFXyf0WCX
E5FAyA2B5VT6ZJPdwEl9BfMJdd61weZQXAeddN8rgcmdLDEL4+734yiCe5MaaQ9H
fNpP3gYo3L7PCcTNlX1et6hFBXbQgeHKYenOxbJ/ct1m9wMzd+w=
=1qY+
-END PGP SIGNATURE-
diff --git a/debian/changelog b/debian/changelog
index b59bf9e..e296d69 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,11 @@
+libembperl-perl (2.5.0-4+deb8u1) UNRELEASED; urgency=medium
+
+  [ Axel Beckert ]
+  * Drop hard a2enmod dependency on mod_perl in zembperl.load. mod_perl is
+enabled by default anyways if installed. (Closes: #810655)
+
+ -- gregor herrmann   Fri, 19 May 2017 13:09:03 +0200
+
 libembperl-perl (2.5.0-4) unstable; urgency=low
 
   [ Salvatore Bonaccorso ]
diff --git a/debian/libembperl-perl.postinst b/debian/libembperl-perl.postinst
index 3223cfd..9ce3aee 100644
--- a/debian/libembperl-perl.postinst
+++ b/debian/libembperl-perl.postinst
@@ -11,11 +11,17 @@ if [ "$1" = "configure" ]; then
 # mod_embperl is not thread-safe, requires the prefork MPM
 if [ $(a2query -M) != 'prefork' ] ; then
 if apache2_switch_mpm prefork ; then
+if [ -e /etc/apache2/mods-available/perl.load ]; then
+apache2_invoke enmod perl
+fi
 apache2_invoke enmod zembperl
 else
 apache2_msg err "Could not switch to prefork, not enabling 
mod_embperl (you must use cgi or offline mode to use Embperl)"
 fi
 else
+if [ -e /etc/apache2/mods-available/perl.load ]; then
+apache2_invoke enmod perl
+fi
 apache2_invoke enmod zembperl
 fi
 fi
diff --git a/debian/zembperl.load.in b/debian/zembperl.load.in
index ce9542b..91bb120 100644
--- a/debian/zembperl.load.in
+++ b/debian/zembperl.load.in
@@ -1,6 +1,6 @@
 # The sucky "zembperl" name is so we load after perl
 
-# Depends: perl
+# Recommends: perl
 
 
   LoadModule embperl_module @ARCHLIB@/auto/Embperl/Embperl.so