Bug#890470: stretch-pu: package systemd/232-25+deb9u1

[Cyril Brulebois]

Hi,

Adam D. Barratt  (2018-02-25):
> [CC += KiBi as requested]

[ta]

> On Fri, 2018-02-23 at 19:54 +0100, Michael Biebl wrote:
> > Am 23.02.2018 um 19:19 schrieb Adam D. Barratt:
> > > Thanks. Please feel free to upload.
> > 
> > Uploaded.
> > 
> 
> Flagged for acceptance into p-u.

Thanks; for the record, stretch with s-p-u enabled looks good to me on
the d-i side.


Cheers,
-- 
Cyril Brulebois (k...@debian.org)
D-I release manager -- Release team member -- Freelance Consultant


signature.asc
Description: PGP signature

Bug#890470: stretch-pu: package systemd/232-25+deb9u1

[Adam D. Barratt]

Control: tags -1 + pending

[CC += KiBi as requested]

On Fri, 2018-02-23 at 19:54 +0100, Michael Biebl wrote:
> Am 23.02.2018 um 19:19 schrieb Adam D. Barratt:
> > Thanks. Please feel free to upload.
> 
> Uploaded.
> 

Flagged for acceptance into p-u.

Regards,

Adam

Processed: Re: Bug#890470: stretch-pu: package systemd/232-25+deb9u1

[Debian Bug Tracking System]

Processing control commands:

> tags -1 + pending
Bug #890470 [release.debian.org] stretch-pu: package systemd/232-25+deb9u2
Added tag(s) pending.

-- 
890470: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=890470
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

Bug#890470: stretch-pu: package systemd/232-25+deb9u1

[Michael Biebl]

Am 23.02.2018 um 19:19 schrieb Adam D. Barratt:
> Thanks. Please feel free to upload.

Uploaded.

Regards,
Michael

-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?



signature.asc
Description: OpenPGP digital signature

Processed: Re: Bug#890470: stretch-pu: package systemd/232-25+deb9u1

[Debian Bug Tracking System]

Processing control commands:

> tags -1 -moreinfo +confirmed
Bug #890470 [release.debian.org] stretch-pu: package systemd/232-25+deb9u2
Removed tag(s) moreinfo.
Bug #890470 [release.debian.org] stretch-pu: package systemd/232-25+deb9u2
Added tag(s) confirmed.

-- 
890470: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=890470
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

Bug#890470: stretch-pu: package systemd/232-25+deb9u1

[Adam D. Barratt]

Control: tags -1 -moreinfo +confirmed

On Fri, 2018-02-23 at 19:09 +0100, Michael Biebl wrote:
> Hi Adam
> 
> Am 23.02.2018 um 18:41 schrieb Adam D. Barratt:
> > Control: tags -1 + moreinfo
> > 
> > On Thu, 2018-02-15 at 01:19 +0100, Michael Biebl wrote:
> > > I'd like to make a stable upload for systemd fixing a couple of
> > > issues.
> > > 
> > > An annotated changelog follows.
> > > Full debdiff is attached.
> > 
> > In fact, it wasn't.
> 
> Indeed, sorry for that.
> 
> > The individual patches look OK, but I'd like to see the full
> > debdiff
> > before confirming, please.
> 
> Attached, this time for real...
> 

Thanks. Please feel free to upload.

Regards,

Adam

Bug#890470: stretch-pu: package systemd/232-25+deb9u1

[Michael Biebl]

Hi Adam

Am 23.02.2018 um 18:41 schrieb Adam D. Barratt:
> Control: tags -1 + moreinfo
> 
> On Thu, 2018-02-15 at 01:19 +0100, Michael Biebl wrote:
>> I'd like to make a stable upload for systemd fixing a couple of
>> issues.
>>
>> An annotated changelog follows.
>> Full debdiff is attached.
> 
> In fact, it wasn't.

Indeed, sorry for that.

> The individual patches look OK, but I'd like to see the full debdiff
> before confirming, please.

Attached, this time for real...

Regards,
Michael

-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?
diff --git a/debian/changelog b/debian/changelog
index fe1e79f..e7b7ff1 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,19 @@
+systemd (232-25+deb9u2) stretch; urgency=medium
+
+  * networkd: Handle MTU field in IPv6 RA (Closes: #878162)
+  * shared: Add a linker script so that all functions are tagged @SD_SHARED
+instead of @Base.
+This helps prevent symbol collisions with other programs and libraries.
+In particular, because PAM modules are loaded into the process that is
+creating the session, and systemd creates PAM sessions, the potential
+for collisions is high. (Closes: #873708)
+  * resolved: Fix loop on packets with pseudo dns types.
+CVE-2017-15908 (Closes: #880026)
+  * machinectl: Don't output "No machines." with --no-legend option
+(Closes: #880158)
+
+ -- Michael Biebl   Sun, 03 Dec 2017 15:03:50 +0100
+
 systemd (232-25+deb9u1) stretch; urgency=medium
 
   [ Dimitri John Ledkov ]
diff --git 
a/debian/patches/machinectl-don-t-output-No-machines.-with-no-legend-optio.patch
 
b/debian/patches/machinectl-don-t-output-No-machines.-with-no-legend-optio.patch
new file mode 100644
index 000..b8bdf66
--- /dev/null
+++ 
b/debian/patches/machinectl-don-t-output-No-machines.-with-no-legend-optio.patch
@@ -0,0 +1,65 @@
+From: =?utf-8?q?Viktar_Va=C5=AD=C4=8Dkievi=C4=8D?= 
+Date: Sun, 6 Nov 2016 17:19:57 +0300
+Subject: machinectl: don't output "No machines." with --no-legend option
+ (#4593)
+
+(cherry picked from commit f9b1947f9b9bcdf2b28953a40b1c537038c2a958)
+---
+ src/machine/machinectl.c | 30 ++
+ 1 file changed, 18 insertions(+), 12 deletions(-)
+
+diff --git a/src/machine/machinectl.c b/src/machine/machinectl.c
+index c2ab202..5b2e18c 100644
+--- a/src/machine/machinectl.c
 b/src/machine/machinectl.c
+@@ -325,10 +325,12 @@ static int list_machines(int argc, char *argv[], void 
*userdata) {
+ printf("-\n");
+ }
+ 
+-if (arg_legend && n_machines > 0)
+-printf("\n%zu machines listed.\n", n_machines);
+-else
+-printf("No machines.\n");
++if (arg_legend) {
++if (n_machines > 0)
++printf("\n%zu machines listed.\n", n_machines);
++else
++printf("No machines.\n");
++}
+ 
+ out:
+ clean_machine_info(machines, n_machines);
+@@ -458,10 +460,12 @@ static int list_images(int argc, char *argv[], void 
*userdata) {
+(int) max_mtime, strna(format_timestamp(mtime_buf, 
sizeof(mtime_buf), images[j].mtime)));
+ }
+ 
+-if (arg_legend && n_images > 0)
+-printf("\n%zu images listed.\n", n_images);
+-else
+-printf("No images.\n");
++if (arg_legend) {
++if (n_images > 0)
++printf("\n%zu images listed.\n", n_images);
++else
++printf("No images.\n");
++}
+ 
+ return 0;
+ }
+@@ -2484,10 +2488,12 @@ static int list_transfers(int argc, char *argv[], void 
*userdata) {
+(int) max_local, transfers[j].local,
+(int) max_remote, transfers[j].remote);
+ 
+-if (arg_legend && n_transfers > 0)
+-printf("\n%zu transfers listed.\n", n_transfers);
+-else
+-printf("No transfers.\n");
++if (arg_legend) {
++if (n_transfers > 0)
++printf("\n%zu transfers listed.\n", n_transfers);
++else
++printf("No transfers.\n");
++}
+ 
+ return 0;
+ }
diff --git a/debian/patches/networkd-handle-MTU-field-in-IPv6-RA-4719.patch 
b/debian/patches/networkd-handle-MTU-field-in-IPv6-RA-4719.patch
new file mode 100644
index 000..f8fc7f1
--- /dev/null
+++ b/debian/patches/networkd-handle-MTU-field-in-IPv6-RA-4719.patch
@@ -0,0 +1,131 @@
+From: Susant Sahani 
+Date: Thu, 24 Nov 2016 03:02:19 +0530
+Subject: networkd: handle MTU field in IPv6 RA (#4719)
+
+This patch handles the custom MTU field in IPv6 RA.
+
+fixes RFE #4464
+
+(cherry picked from commit d6fceaf1f7ff765bdc3b135f3d3676ec689da312)
+---
+ src/libsystemd/sd-netlink/netlink-types.c | 27 

Bug#890470: stretch-pu: package systemd/232-25+deb9u1

[Adam D. Barratt]

Control: tags -1 + moreinfo

On Thu, 2018-02-15 at 01:19 +0100, Michael Biebl wrote:
> I'd like to make a stable upload for systemd fixing a couple of
> issues.
> 
> An annotated changelog follows.
> Full debdiff is attached.

In fact, it wasn't.

The individual patches look OK, but I'd like to see the full debdiff
before confirming, please.

Regards,

Adam

Processed: Re: Bug#890470: stretch-pu: package systemd/232-25+deb9u1

[Debian Bug Tracking System]

Processing control commands:

> tags -1 + moreinfo
Bug #890470 [release.debian.org] stretch-pu: package systemd/232-25+deb9u2
Added tag(s) moreinfo.

-- 
890470: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=890470
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

Bug#890470: stretch-pu: package systemd/232-25+deb9u1

[Cyril Brulebois]

Hi Michael,

Michael Biebl  (2018-02-15):
> systemd (232-25+deb9u2) stretch; urgency=medium
> 
>   * networkd: Handle MTU field in IPv6 RA (Closes: #878162)
> 
> https://salsa.debian.org/systemd-team/systemd/commit/9f134218fa5ed60a4d7b0a2282d86ab56f52a3e9
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=878162
> 
> It's a cherry-pick of an upstream commit which is already in
> unstable/testing.
> 
> This change was requested by Julien Cristau who already confirmed that
> it fixes the issue for stretch.

I'm not Julien. :)

> The changes don't affect the installer. That said I've CCed
> debian-boot for their ack.

Thanks; that looks fine to me on the d-i side, but I'd be happy to get a
ping when the package gets accepted into s-p-u, so that I have a chance
of triggering a few tests before it's point release time.


Cheers,
-- 
Cyril Brulebois (k...@debian.org)
D-I release manager -- Release team member -- Freelance Consultant


signature.asc
Description: PGP signature

Bug#890470: stretch-pu: package systemd/232-25+deb9u1

[Michael Biebl]

Package: release.debian.org
Severity: normal
Tags: stretch
User: release.debian@packages.debian.org
Usertags: pu

Hi,

I'd like to make a stable upload for systemd fixing a couple of issues.

An annotated changelog follows.
Full debdiff is attached.

systemd (232-25+deb9u2) stretch; urgency=medium

  * networkd: Handle MTU field in IPv6 RA (Closes: #878162)

https://salsa.debian.org/systemd-team/systemd/commit/9f134218fa5ed60a4d7b0a2282d86ab56f52a3e9
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=878162

It's a cherry-pick of an upstream commit which is already in
unstable/testing.
This change was requested by Julien Cristau who already confirmed that it
fixes the issue for stretch.

  * shared: Add a linker script so that all functions are tagged @SD_SHARED
instead of @Base.
This helps prevent symbol collisions with other programs and libraries.
In particular, because PAM modules are loaded into the process that is
creating the session, and systemd creates PAM sessions, the potential
for collisions is high. (Closes: #873708)

https://salsa.debian.org/systemd-team/systemd/commit/bd33312f7fcf660f568bf2bac288b5ceec6981ab
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=873708

It's a backport of an upstream commit which is already in
unstable/testing.

I'd consider this the most important fix, as we have seen segfaults in
systemd when e.g. libpam-heimdal was used.

  * resolved: Fix loop on packets with pseudo dns types.
CVE-2017-15908 (Closes: #880026)

https://salsa.debian.org/systemd-team/systemd/commit/5a469751160af8334ca4748ee00ee9b7e1a3efe3
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=880026

It's a cherry-pick of an upstream commit which is already in
unstable/testing.
The security team suggested to fix this via a stable upload, as the
issue was not considered severe enough for a security upload (resolved
is not enabled by default in Debian)

  * machinectl: Don't output "No machines." with --no-legend option
(Closes: #880158)

https://salsa.debian.org/systemd-team/systemd/commit/9c22320c9d012bb515fb91752795fa4a6649dc5f
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=880158

It's a cherry-pick of an upstream commit which is already in
unstable/testing.

The fix is trivial and has very low regression potential, so I decided
to include this patch as well. I'm fine with dropping it though, if you
have concerns.


The changes don't affect the installer. That said I've CCed debian-boot
for their ack.

Please let me know if I can proceed with the upload.

Regards,
Michael

-- System Information:
Debian Release: buster/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (200, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.15.0-rc8-amd64 (SMP w/4 CPU cores)
Locale: LANG=de_DE.utf8, LC_CTYPE=de_DE.utf8 (charmap=UTF-8), 
LANGUAGE=de_DE.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)