Package: release.debian.org
User: release.debian....@packages.debian.org
Usertags: unblock
Severity: normal
Please unblock package clamtk
A change introduced in libgtk3-perl (0.038) uncovered a bug in clamtk
leaving it almost unuseable. clamtk is frontend for the clamav binary
and due to the bug I see no results from the buttons "scan file" and
"scan directory". It renders the tool unusable imho.
I uploaded the fixed version to experimental almost two weeks ago asking
one of persons in the bug report to verify the change. This did not
happen and today I verified it myself (I'm not a regular user of the
tool so I also upgraded the severity of the initial bug report once
I figured out that it is the main function that is no longer working).
The change is based on a diff vs the current upstream version which has
the bug also fixed.
The whole change is low risk from my point of view. It is not useable
now, it is with change.
Please find attached the diff against testing.
unblock clamtk/6.03-3
Sebastian
diff -Nru clamtk-6.03/debian/changelog clamtk-6.03/debian/changelog
--- clamtk-6.03/debian/changelog 2020-04-29 07:22:23.000000000 +0200
+++ clamtk-6.03/debian/changelog 2021-03-20 09:37:26.000000000 +0100
@@ -1,3 +1,15 @@
+clamtk (6.03-3) unstable; urgency=medium
+
+ * Upload to unstable.
+
+ -- Sebastian Andrzej Siewior <sebast...@breakpoint.cc> Sat, 20 Mar 2021 09:37:26 +0100
+
+clamtk (6.03-2) experimental; urgency=medium
+
+ * Remove no-separator from window decoration (Closes: #981384).
+
+ -- Sebastian Andrzej Siewior <sebast...@breakpoint.cc> Sun, 07 Mar 2021 23:38:23 +0100
+
clamtk (6.03-1) unstable; urgency=medium
* New upstream release
diff -Nru clamtk-6.03/debian/patches/Remove-no-separator.patch clamtk-6.03/debian/patches/Remove-no-separator.patch
--- clamtk-6.03/debian/patches/Remove-no-separator.patch 1970-01-01 01:00:00.000000000 +0100
+++ clamtk-6.03/debian/patches/Remove-no-separator.patch 2021-03-07 23:37:29.000000000 +0100
@@ -0,0 +1,62 @@
+From: Sebastian Andrzej Siewior <sebast...@breakpoint.cc>
+Date: Sun, 7 Mar 2021 23:31:29 +0100
+Subject: [PATCH] Remove no-separator
+
+The `no-separator' parameter which is passed to Gtk3::Dialog->new is
+invalid. This has been exposed by perl's GTK3 binding in version 0.038.
+Remove the `no-separator' as it has been in upstream repository for
+clamtk.
+
+BTS: #981384
+
+Signed-off-by: Sebastian Andrzej Siewior <sebast...@breakpoint.cc>
+---
+ lib/Analysis.pm | 3 +--
+ lib/History.pm | 2 +-
+ lib/Scan.pm | 3 +--
+ 3 files changed, 3 insertions(+), 5 deletions(-)
+
+diff --git a/lib/Analysis.pm b/lib/Analysis.pm
+index f44a981269d56..2c50e6d0d4956 100644
+--- a/lib/Analysis.pm
++++ b/lib/Analysis.pm
+@@ -48,8 +48,7 @@ sub show_window {
+ ( undef, $from_scan, $parent ) = @_;
+ $window = Gtk3::Dialog->new(
+ undef, $parent,
+- [ qw| modal destroy-with-parent no-separator
+- use-header-bar |
++ [ qw| modal destroy-with-parent use-header-bar |
+ ],
+ );
+ $window->signal_connect(
+diff --git a/lib/History.pm b/lib/History.pm
+index 623cd52a91c1b..aeaf7d8fdf619 100644
+--- a/lib/History.pm
++++ b/lib/History.pm
+@@ -148,7 +148,7 @@ sub view_history {
+
+ my $win = Gtk3::Dialog->new(
+ sprintf( _( 'Viewing %s' ), $basename ),
+- undef, [ qw| modal destroy-with-parent no-separator | ],
++ undef, [ qw| modal destroy-with-parent | ],
+ );
+ $win->signal_connect( destroy => sub { $win->destroy; 1 } );
+ $win->set_default_size( 800, 350 );
+diff --git a/lib/Scan.pm b/lib/Scan.pm
+index 794ce3ceee8b9..79d03c80a0be3 100644
+--- a/lib/Scan.pm
++++ b/lib/Scan.pm
+@@ -90,8 +90,7 @@ sub filter {
+ # Begin popup scanning
+ $window = Gtk3::Dialog->new(
+ undef, undef,
+- [ qw| modal destroy-with-parent no-separator
+- use-header-bar |
++ [ qw| modal destroy-with-parent use-header-bar |
+ ],
+ );
+ $window->set_deletable( FALSE );
+--
+2.30.1
+
diff -Nru clamtk-6.03/debian/patches/series clamtk-6.03/debian/patches/series
--- clamtk-6.03/debian/patches/series 2020-04-29 07:22:23.000000000 +0200
+++ clamtk-6.03/debian/patches/series 2021-03-07 23:37:40.000000000 +0100
@@ -1 +1,2 @@
py3-clamtk-gnome.patch
+Remove-no-separator.patch
