Bug#1032450: unblock (pre-approval): gtk+3.0/3.24.37-2

2023-03-08 Thread Simon McVittie 
On Wed, 08 Mar 2023 at 13:13:08 +0100, Sebastian Ramacher wrote:
> On 2023-03-07 01:12:58 +, Simon McVittie wrote:
> > gtk+3.0_3.24.37 is in experimental at the moment, and we'd like to
> > include it in bookworm if possible.
> 
> Are there any other stable releases planned for the 3.24.x series during
> the freeze?

We won't know until/unless they happen. GTK 3 is in maintenance mode and
has no fixed schedule: releases happen whenever upstream gets round to
making them.

As a result of regressions like the startup-notification thing that's
fixed in 3.24.37, the primary maintainer upstream has said that he's going
to be increasingly strict about what backports he'll allow into 3.x in
future, although it remains to be seen how that policy will turn out.

(I'd personally prefer it if new features like the file transfer portal
were done as a 3.25.x prerelease followed by a 3.26.x stable release,
the same way GTK 3 historically worked and GTK 4 still does, but upstream
has historically considered that to be too much release-management work
for the major versions that are in maintenance mode, so I think we're
unlikely to get that.)

smcv

Bug#1032450: unblock (pre-approval): gtk+3.0/3.24.37-2

2023-03-08 Thread Sebastian Ramacher 
Control: tags -1 confirmed

On 2023-03-07 01:12:58 +, Simon McVittie wrote:
> Package: release.debian.org
> Severity: normal
> User: release.debian@packages.debian.org
> Usertags: unblock
> X-Debbugs-Cc: gtk+...@packages.debian.org
> Control: affects -1 + src:gtk+3.0
> 
> gtk+3.0_3.24.37 is in experimental at the moment, and we'd like to
> include it in bookworm if possible.
> 
> [ Reason ]
> Resync with upstream release. What we have in bookworm at the moment
> is GTK 3.24.36 and something like half of 3.24.37; rebasing on 3.24.37
> seems a better basis for a stable release.

Agreed. Please go ahead.

Are there any other stable releases planned for the 3.24.x series during
the freeze?

Cheers

> 
> We could apply selected changes from 3.24.37 as patches, but at some
> point we're just reconstructing 3.24.37 with extra steps.
> 
> [ Impact ]
> Updating to the version in experimental will give us:
> - support for transparent drag-and-drop of files between sandboxed
>   Flatpak GTK 3/GTK 4 apps (hopefully also Qt in future), and
>   non-sandboxed GTK 3 apps from Debian
> - the upstream fix for an annoying regression where spurious startup
>   notifications appear in the GNOME top bar and newly-launched GTK 3 apps
>   don't reliably appear in Alt+Tab, replacing our previous
>   upstream-rejected workaround which didn't completely solve this
> - various smaller bug fixes, some of which resolve potential crashes
> 
> Also, the patches added in 3.24.36-3 and 3.24.36-4 are now part of the
> upstream source, giving users a better picture of what version we're
> actually providing.
> 
> [ Tests ]
> Installed in a GNOME desktop for manual testing with
> no obvious regressions, and I can no longer reproduce
> https://gitlab.gnome.org/GNOME/gtk/-/issues/5386.
> 
> I was also able to drag-and-drop a file from Nautilus onto the
> org.gtk.Demo4 Flatpak app from 
> (specifically the Clipboard window), where it appears as an
> xdg-document-portal filename when dropped on the bottom half of the demo.
> 
> autopkgtest reports one apparent regression for gnome-photos, but I think
> it might be spurious (the test getting stuck). I'll try to investigate it
> if it turns out to be reproducible.
> 
> [ Risks ]
> I wouldn't normally be adding the file transfer portal (drag-and-drop
> to/from sandboxes) at this stage in the release cycle, but it's a good
> feature to have if we want users to be able to run more sandboxed apps
> over the next 2 years, and surprisingly little code. It does have one
> potential interop issue (using a non-standard MIME type) which I've
> reported upstream. I hope fixing that should be a simple change
> (< 10 lines).
> 
> Similarly I wouldn't normally be adding the changes in gdk/broadway/ at
> this stage in the release cycle, but hardly anyone uses the GTK broadway
> backend (it's a mechanism for displaying apps via a web browser) and
> patching them out seems like it would be more disruptive than helpful.
> 
> [ Checklist ]
>   [x] all changes are documented in the d/changelog
>   [x] I reviewed all changes and I approve them
>   [x] attach debdiff against the package in testing
> 
> The attached diff is between the patched trees, excluding the actual
> patches and some Windows- and macOS-specific changes to avoid noise.
> I normally upload using dgit, so the contents of git and the debdiff
> will match exactly.

> diff --git a/NEWS b/NEWS
> index fdd44e6e77..c4191123a9 100644
> --- a/NEWS
> +++ b/NEWS
> @@ -1,3 +1,25 @@
> +Overview of Changes in GTK+ 3.24.37, 02-03-2023
> +===
> +
> +* Support the file transfer portal for copy-paste and DND
> +
> +* Treat XKB_MODE_NAME_LODO as super key
> +
> +* Refactor startup notification handling to be in sync with GTK 4
> +
> +* GL: Synchronie when calling MakeCurrent
> +
> +* CSS: Fix a problem with stopping animations
> +
> +* Wayland: Drop the legacy text input module
> +
> +* Windows: Set the default file extension in the native file chooser
> +
> +* Translation updates:
> + Abkhazian
> + Turkish
> +
> +
>  Overview of Changes in GTK+ 3.24.36, 12-22-2022
>  ===
>  
> diff --git a/debian/changelog b/debian/changelog
> index c7c69ef1c0..d115481e26 100644
> --- a/debian/changelog
> +++ b/debian/changelog
> @@ -1,3 +1,43 @@
> +gtk+3.0 (3.24.37-2) UNRELEASED; urgency=medium
> +
> +  * d/copyright: Remove gtk-text-input.xml.
> +This file is no longer present in the source package.
> +  * Remove Lintian overrides for lintian/lintian!452, no longer necessary
> +
> + -- Simon McVittie   Tue, 07 Mar 2023 00:07:09 +
> +
> +gtk+3.0 (3.24.37-1) experimental; urgency=medium
> +
> +  * New upstream release
> +- Add support for xdg-desktop-portal file transfer API, allowing
> +  copy/paste and drag-and-drop of files where one of the apps involved
> +  is sandboxed by Flatpak, Snap or similar (GNOME/gtk!5554)
> +- Fix a

Processed: Re: Bug#1032450: unblock (pre-approval): gtk+3.0/3.24.37-2

2023-03-08 Thread Debian Bug Tracking System 
Processing control commands:

> tags -1 confirmed
Bug #1032450 [release.debian.org] unblock (pre-approval): gtk+3.0/3.24.37-2
Added tag(s) confirmed.

-- 
1032450: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1032450
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

Bug#1032450: unblock (pre-approval): gtk+3.0/3.24.37-2

2023-03-06 Thread Simon McVittie 
Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock
X-Debbugs-Cc: gtk+...@packages.debian.org
Control: affects -1 + src:gtk+3.0

gtk+3.0_3.24.37 is in experimental at the moment, and we'd like to
include it in bookworm if possible.

[ Reason ]
Resync with upstream release. What we have in bookworm at the moment
is GTK 3.24.36 and something like half of 3.24.37; rebasing on 3.24.37
seems a better basis for a stable release.

We could apply selected changes from 3.24.37 as patches, but at some
point we're just reconstructing 3.24.37 with extra steps.

[ Impact ]
Updating to the version in experimental will give us:
- support for transparent drag-and-drop of files between sandboxed
  Flatpak GTK 3/GTK 4 apps (hopefully also Qt in future), and
  non-sandboxed GTK 3 apps from Debian
- the upstream fix for an annoying regression where spurious startup
  notifications appear in the GNOME top bar and newly-launched GTK 3 apps
  don't reliably appear in Alt+Tab, replacing our previous
  upstream-rejected workaround which didn't completely solve this
- various smaller bug fixes, some of which resolve potential crashes

Also, the patches added in 3.24.36-3 and 3.24.36-4 are now part of the
upstream source, giving users a better picture of what version we're
actually providing.

[ Tests ]
Installed in a GNOME desktop for manual testing with
no obvious regressions, and I can no longer reproduce
https://gitlab.gnome.org/GNOME/gtk/-/issues/5386.

I was also able to drag-and-drop a file from Nautilus onto the
org.gtk.Demo4 Flatpak app from 
(specifically the Clipboard window), where it appears as an
xdg-document-portal filename when dropped on the bottom half of the demo.

autopkgtest reports one apparent regression for gnome-photos, but I think
it might be spurious (the test getting stuck). I'll try to investigate it
if it turns out to be reproducible.

[ Risks ]
I wouldn't normally be adding the file transfer portal (drag-and-drop
to/from sandboxes) at this stage in the release cycle, but it's a good
feature to have if we want users to be able to run more sandboxed apps
over the next 2 years, and surprisingly little code. It does have one
potential interop issue (using a non-standard MIME type) which I've
reported upstream. I hope fixing that should be a simple change
(< 10 lines).

Similarly I wouldn't normally be adding the changes in gdk/broadway/ at
this stage in the release cycle, but hardly anyone uses the GTK broadway
backend (it's a mechanism for displaying apps via a web browser) and
patching them out seems like it would be more disruptive than helpful.

[ Checklist ]
  [x] all changes are documented in the d/changelog
  [x] I reviewed all changes and I approve them
  [x] attach debdiff against the package in testing

The attached diff is between the patched trees, excluding the actual
patches and some Windows- and macOS-specific changes to avoid noise.
I normally upload using dgit, so the contents of git and the debdiff
will match exactly.
diff --git a/NEWS b/NEWS
index fdd44e6e77..c4191123a9 100644
--- a/NEWS
+++ b/NEWS
@@ -1,3 +1,25 @@
+Overview of Changes in GTK+ 3.24.37, 02-03-2023
+===
+
+* Support the file transfer portal for copy-paste and DND
+
+* Treat XKB_MODE_NAME_LODO as super key
+
+* Refactor startup notification handling to be in sync with GTK 4
+
+* GL: Synchronie when calling MakeCurrent
+
+* CSS: Fix a problem with stopping animations
+
+* Wayland: Drop the legacy text input module
+
+* Windows: Set the default file extension in the native file chooser
+
+* Translation updates:
+ Abkhazian
+ Turkish
+
+
 Overview of Changes in GTK+ 3.24.36, 12-22-2022
 ===
 
diff --git a/debian/changelog b/debian/changelog
index c7c69ef1c0..d115481e26 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,43 @@
+gtk+3.0 (3.24.37-2) UNRELEASED; urgency=medium
+
+  * d/copyright: Remove gtk-text-input.xml.
+This file is no longer present in the source package.
+  * Remove Lintian overrides for lintian/lintian!452, no longer necessary
+
+ -- Simon McVittie   Tue, 07 Mar 2023 00:07:09 +
+
+gtk+3.0 (3.24.37-1) experimental; urgency=medium
+
+  * New upstream release
+- Add support for xdg-desktop-portal file transfer API, allowing
+  copy/paste and drag-and-drop of files where one of the apps involved
+  is sandboxed by Flatpak, Snap or similar (GNOME/gtk!5554)
+- Fix a regression for startup notifications (GNOME/gtk!5581)
+- Fix potential invalid pointer dereference when checking whether a
+  list store iterator is valid
+- Simple input method: Silence a warning from newer GLib by correctly
+  returning a value from a task
+- Search engine: Reduce severity of the warning when Tracker
+  initialization failed, avoiding crashes when run with
+  G_DEBUG=fatal-criticals and