Package: release.debian.org Severity: normal User: release.debian....@packages.debian.org Usertags: unblock X-Debbugs-Cc: linph...@packages.debian.org Control: affects -1 + src:linphone
Please unblock package linphone [ Reason ] Two important bugs have been resolved * Disable behind-the-scenes download of the AppImage (Closes: #1031771). * Update documentation to highlight limitations in linphonec CLI utility and to properly explain how to create an initial ~/.linphonerc file (Closes: #1032051). [ Impact ] linphone will attempt to self-update by downloading a newer AppImage version, which is upstream's preferred way of distributing linphone The second change is documentary only and will update README.Debian and the manpage to explain about the configuration migration logic in linphone (CLI) vs. linphone-desktop. [ Tests ] No automatic tests, patches have been prepared by Dennis who has been maintaining linphone with an excellent quality in mind. Version has been in unstable for two weeks now [ Risks ] Patch has been tested and could easily be backed out if necessary [ Checklist ] [x] all changes are documented in the d/changelog [x] I reviewed all changes and I approve them [x] attach debdiff against the package in testing [ Other info ] - unblock linphone/5.1.65-4
diff -Nru linphone-5.1.65/debian/changelog linphone-5.1.65/debian/changelog --- linphone-5.1.65/debian/changelog 2023-01-21 09:21:53.000000000 +0100 +++ linphone-5.1.65/debian/changelog 2023-03-02 20:10:59.000000000 +0100 @@ -1,3 +1,12 @@ +linphone (5.1.65-4) unstable; urgency=medium + + * Disable behind-the-scenes download of the AppImage (Closes: #1031771). + * Update documentation to highlight limitations in linphonec CLI utility + and to properly explain how to create an initial ~/.linphonerc file + (Closes: #1032051). + + -- Dennis Filder <d.fil...@web.de> Thu, 02 Mar 2023 20:10:59 +0100 + linphone (5.1.65-3) unstable; urgency=medium * Port wrappers/cpp/genwrapper.py to Python 3.11 (Closes: #1029253). diff -Nru linphone-5.1.65/debian/linphone-cli.README.Debian linphone-5.1.65/debian/linphone-cli.README.Debian --- linphone-5.1.65/debian/linphone-cli.README.Debian 1970-01-01 01:00:00.000000000 +0100 +++ linphone-5.1.65/debian/linphone-cli.README.Debian 2023-03-02 20:10:59.000000000 +0100 @@ -0,0 +1,24 @@ +Debian-specific information +=========================== + +linphonec by default erroneously still solely expects ~/.linphonerc to +be present and is unaware of ~/.config/linphone/linphonerc. To make +linphonec use ~/.config/linphone/linphonerc invoke it with the -c +parameter: + + linphone -c $HOME/.config/linphone/linphonerc + +Alternatively, you can create a suitable symbolic link by running: + + ln -v -s $HOME/.config/linphone/linphonerc $HOME/.linphonerc + +This cannot be done automatically because it might interfere with +configuration migration logic. + +Also take note of the fact that the Qt-based graphical linphone +application houses all migration logic for configuration files, chat +logs etc. If you have any existing such files you should run the +graphical linphone application to ensure it is properly migrated after +every upgrade. + + -- Dennis Filder <d.fil...@web.de>, Thu, 2 Mar 2023 19:40:11 +0100 diff -Nru linphone-5.1.65/debian/patches/disable_appimage_download.patch linphone-5.1.65/debian/patches/disable_appimage_download.patch --- linphone-5.1.65/debian/patches/disable_appimage_download.patch 1970-01-01 01:00:00.000000000 +0100 +++ linphone-5.1.65/debian/patches/disable_appimage_download.patch 2023-03-02 20:10:59.000000000 +0100 @@ -0,0 +1,27 @@ +Description: Disable behind-the-scenes AppImage download + The error message is unfortunately only printed to the log, not stderr. +Author: Dennis Filder <d.fil...@web.de> +Last-Update: 2023-03-02 +Bug-Debian: https://bugs.debian.org/1031771 +Forwarded: not-needed +--- a/coreapi/update_check.c ++++ b/coreapi/update_check.c +@@ -114,6 +114,11 @@ + return; + } + ++ if (!getenv("LINPHONE_DO_APPIMAGE_DOWNLOAD")) { ++ bctbx_error("AppImage download disabled. To enable it restart the program with the variable LINPHONE_DO_APPIMAGE_DOWNLOAD set to \"y\" in the environment."); ++ return; ++ } ++ + if (version_check_url_root != NULL) { + belle_http_request_listener_callbacks_t belle_request_listener = { 0 }; + belle_http_request_t *request; +@@ -154,4 +159,4 @@ + request = belle_http_request_create("GET", uri, belle_sip_header_create("User-Agent", linphone_core_get_user_agent(lc)), NULL); + belle_http_provider_send_request(lc->http_provider, request, update->http_listener); + } +-} +\ No newline at end of file ++} diff -Nru linphone-5.1.65/debian/patches/fix_linphonec_manpage.patch linphone-5.1.65/debian/patches/fix_linphonec_manpage.patch --- linphone-5.1.65/debian/patches/fix_linphonec_manpage.patch 1970-01-01 01:00:00.000000000 +0100 +++ linphone-5.1.65/debian/patches/fix_linphonec_manpage.patch 2023-03-02 20:10:59.000000000 +0100 @@ -0,0 +1,29 @@ +Description: Document peculiarities in linphonec better +Author: Dennis Filder <d.fil...@web.de> +Last-Update: 2023-03-02 +Bug-Debian: https://bugs.debian.org/1032051 +Forwarded: not-needed +--- a/share/C/linphonec.1 ++++ b/share/C/linphonec.1 +@@ -30,9 +30,6 @@ + answer : to accept an incoming call. + .TP + help : to display interactive help. +-.TP +- +- + + .SH "OPTIONS" + .LP +@@ -59,6 +56,11 @@ + .SH "EXAMPLES" + .LP + ++.SH "BUGS" ++.LP ++Unlike linphonec the Qt-based graphical linphone application does not use ~/.linphonerc by default anymore, but uses ~/.config/linphone/linphonerc instead, and it is also the application that houses all migration logic for configuration files, chat logs etc. If you have any existing configuration and/or chat logs you should run the graphical linphone application to migrate it after every upgrade. Neither will linphonec create a pristine configuration file for you if none exists yet -- it defers to the GUI linphone application for this. ++.br ++ + .SH "AUTHORS" + .LP + Florian Winterstein <fwin at gmx.de> diff -Nru linphone-5.1.65/debian/patches/series linphone-5.1.65/debian/patches/series --- linphone-5.1.65/debian/patches/series 2023-01-21 09:21:53.000000000 +0100 +++ linphone-5.1.65/debian/patches/series 2023-03-02 20:10:59.000000000 +0100 @@ -11,3 +11,5 @@ fix-nowebcam-image-path.patch delete-build-path-capture.patch fix-python3-removals.patch +disable_appimage_download.patch +fix_linphonec_manpage.patch
