Bug#912784: stretch-pu: package davix/0.6.4-1.1+deb9u1
[I realise this has sat in "moreinfo limbo" for a long while now, sorry] On Mon, 2019-07-08 at 12:49 +0200, Mattias Ellert wrote: > mån 2019-07-08 klockan 12:04 +0200 skrev Julien Cristau: > > On Mon, Jul 8, 2019 at 11:54:18 +0200, Mattias Ellert wrote: > > > > > > Sorry for not getting back to you again sooner. > > > > > > > > The bug fix sounds OK. What's the d/rules change about? It's > > > > not > > > > mentioned in the changelog. > > > > > > > > + rm -rf debian/tmp/usr/share/doc/davix/html/.doctrees > > > > > > > > Regards, > > > > > > > > Adam > > > > > > Sorry for the delay. This is due to lintian. > > > > > > $ lintian-info -t package-contains-python-doctree-file > > > W: package-contains-python-doctree-file > > > N: > > > N: This package appears to contain a pickled cache of > > > reStructuredText > > > N: (*.rst) documentation in a .doctree file. > > > N: > > > N: These are not needed to display the documentation correctly > > > and as > > > N: they can contain absolute build paths can affect the > > > reproducibility > > > N: of the package. > > > N: > > > N: Either prevent the installation of the .doctree file (or > > > parent > > > N: doctrees directory if there is one) or pass the -d option to > > > N: sphinx-build(1) to create the caches elsewhere. > > > > > That doesn't sound needed nor indeed appropriate for a stable > > update. > > > > Cheers, > > Julien > > Please elaborate. > Should I interpret your comment as a rejection unless that line is > removed, or was this an invitation for me to argue in favour of it. I would assume some combination. > I can't see how removing some unwanted files from the documentation > package could be inappropriate. The base question for changes to a package in (old)stable is whether they fix an issue which affects users of the package (where users can include buildds, the security team and others who have to build them package). Does including this fix do so? Regards, Adam
Bug#912784: stretch-pu: package davix/0.6.4-1.1+deb9u1
mån 2019-07-08 klockan 12:04 +0200 skrev Julien Cristau: > On Mon, Jul 8, 2019 at 11:54:18 +0200, Mattias Ellert wrote: > > > > Sorry for not getting back to you again sooner. > > > > > > The bug fix sounds OK. What's the d/rules change about? It's not > > > mentioned in the changelog. > > > > > > + rm -rf debian/tmp/usr/share/doc/davix/html/.doctrees > > > > > > Regards, > > > > > > Adam > > > > Sorry for the delay. This is due to lintian. > > > > $ lintian-info -t package-contains-python-doctree-file > > W: package-contains-python-doctree-file > > N: > > N: This package appears to contain a pickled cache of > > reStructuredText > > N: (*.rst) documentation in a .doctree file. > > N: > > N: These are not needed to display the documentation correctly > > and as > > N: they can contain absolute build paths can affect the > > reproducibility > > N: of the package. > > N: > > N: Either prevent the installation of the .doctree file (or > > parent > > N: doctrees directory if there is one) or pass the -d option to > > N: sphinx-build(1) to create the caches elsewhere. > > > That doesn't sound needed nor indeed appropriate for a stable update. > > Cheers, > Julien Please elaborate. Should I interpret your comment as a rejection unless that line is removed, or was this an invitation for me to argue in favour of it. I can't see how removing some unwanted files from the documentation package could be inappropriate. Mattias smime.p7s Description: S/MIME cryptographic signature
Bug#912784: stretch-pu: package davix/0.6.4-1.1+deb9u1
On Mon, Jul 8, 2019 at 11:54:18 +0200, Mattias Ellert wrote: > > Sorry for not getting back to you again sooner. > > > > The bug fix sounds OK. What's the d/rules change about? It's not > > mentioned in the changelog. > > > > + rm -rf debian/tmp/usr/share/doc/davix/html/.doctrees > > > > Regards, > > > > Adam > > Sorry for the delay. This is due to lintian. > > $ lintian-info -t package-contains-python-doctree-file > W: package-contains-python-doctree-file > N: > N: This package appears to contain a pickled cache of reStructuredText > N: (*.rst) documentation in a .doctree file. > N: > N: These are not needed to display the documentation correctly and as > N: they can contain absolute build paths can affect the reproducibility > N: of the package. > N: > N: Either prevent the installation of the .doctree file (or parent > N: doctrees directory if there is one) or pass the -d option to > N: sphinx-build(1) to create the caches elsewhere. > That doesn't sound needed nor indeed appropriate for a stable update. Cheers, Julien
Bug#912784: stretch-pu: package davix/0.6.4-1.1+deb9u1
lör 2019-04-20 klockan 11:27 +0100 skrev Adam D. Barratt: > On Tue, 2019-01-08 at 09:50 +0100, Mattias Ellert wrote: > > Davix implements (among other things) a client to a gridsite > > > service > > (a > > SOAP web service based file server protocol). It queries the server > > for > > what version it is running in order to know which credential > > delegation > > method to use. > > > > The old code used the "getVersion" call to get the version, which > > returns the software version of the server. However, there exists > > several different implementations of the server, so the version of > > the > > server software is not indicative on what credential delegation > > method > > it implements. > > > > What determines which delegation method to use is the interface > > version implemented by the server, not the version number of the > > server software. By using the getInterfaceVersion call instead the > > davix client will use the correct delegation method. > > > > https://its.cern.ch/jira/browse/DMC-1047 > > > > Sorry for not getting back to you again sooner. > > The bug fix sounds OK. What's the d/rules change about? It's not > mentioned in the changelog. > > + rm -rf debian/tmp/usr/share/doc/davix/html/.doctrees > > Regards, > > Adam Sorry for the delay. This is due to lintian. $ lintian-info -t package-contains-python-doctree-file W: package-contains-python-doctree-file N: N: This package appears to contain a pickled cache of reStructuredText N: (*.rst) documentation in a .doctree file. N: N: These are not needed to display the documentation correctly and as N: they can contain absolute build paths can affect the reproducibility N: of the package. N: N: Either prevent the installation of the .doctree file (or parent N: doctrees directory if there is one) or pass the -d option to N: sphinx-build(1) to create the caches elsewhere. Mattias smime.p7s Description: S/MIME cryptographic signature
Bug#912784: stretch-pu: package davix/0.6.4-1.1+deb9u1
On Tue, 2019-01-08 at 09:50 +0100, Mattias Ellert wrote: > Davix implements (among other things) a client to a gridsite > > service > (a > SOAP web service based file server protocol). It queries the server > for > what version it is running in order to know which credential > delegation > method to use. > > The old code used the "getVersion" call to get the version, which > returns the software version of the server. However, there exists > several different implementations of the server, so the version of > the > server software is not indicative on what credential delegation > method > it implements. > > What determines which delegation method to use is the interface > version implemented by the server, not the version number of the > server software. By using the getInterfaceVersion call instead the > davix client will use the correct delegation method. > > https://its.cern.ch/jira/browse/DMC-1047 > Sorry for not getting back to you again sooner. The bug fix sounds OK. What's the d/rules change about? It's not mentioned in the changelog. + rm -rf debian/tmp/usr/share/doc/davix/html/.doctrees Regards, Adam
Bug#912784: stretch-pu: package davix/0.6.4-1.1+deb9u1
mån 2018-12-03 klockan 08:17 +0100 skrev Julien Cristau: > Control: tag -1 moreinfo > > On Sat, Nov 03, 2018 at 10:31:32PM +0100, Mattias Ellert wrote: > > Package: release.debian.org > > Severity: normal > > Tags: stretch > > User: release.debian@packages.debian.org > > Usertags: pu > > > > This is a proposed update to the davix package in Debian 9 (stretch). I > > have created it in response to a request that was sent to me via e-mail > > (included below). > > > > The proposed update backports the specific bugfix mentioned in the > > request rather than updating to a newer version. This bugfix was part > > of the 0.6.8 update. The version in unstable and testing is currently > > 0.7.1. > > > Can you describe the effect of this bug? > > Cheers, > Julien Davix implements (among other things) a client to a gridsite service (a SOAP web service based file server protocol). It queries the server for what version it is running in order to know which credential delegation method to use. The old code used the "getVersion" call to get the version, which returns the software version of the server. However, there exists several different implementations of the server, so the version of the server software is not indicative on what credential delegation method it implements. What determines which delegation method to use is the interface version implemented by the server, not the version number of the server software. By using the getInterfaceVersion call instead the davix client will use the correct delegation method. https://its.cern.ch/jira/browse/DMC-1047 Mattias smime.p7s Description: S/MIME cryptographic signature
Bug#912784: stretch-pu: package davix/0.6.4-1.1+deb9u1
Control: tag -1 moreinfo On Sat, Nov 03, 2018 at 10:31:32PM +0100, Mattias Ellert wrote: > Package: release.debian.org > Severity: normal > Tags: stretch > User: release.debian@packages.debian.org > Usertags: pu > > This is a proposed update to the davix package in Debian 9 (stretch). I > have created it in response to a request that was sent to me via e-mail > (included below). > > The proposed update backports the specific bugfix mentioned in the > request rather than updating to a newer version. This bugfix was part > of the 0.6.8 update. The version in unstable and testing is currently > 0.7.1. > Can you describe the effect of this bug? Cheers, Julien
Processed: Re: Bug#912784: stretch-pu: package davix/0.6.4-1.1+deb9u1
Processing control commands: > tag -1 moreinfo Bug #912784 [release.debian.org] stretch-pu: package davix/0.6.4-1.1+deb9u1 Added tag(s) moreinfo. -- 912784: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=912784 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
Bug#912784: stretch-pu: package davix/0.6.4-1.1+deb9u1
Package: release.debian.org
Severity: normal
Tags: stretch
User: release.debian@packages.debian.org
Usertags: pu
This is a proposed update to the davix package in Debian 9 (stretch). I
have created it in response to a request that was sent to me via e-mail
(included below).
The proposed update backports the specific bugfix mentioned in the
request rather than updating to a newer version. This bugfix was part
of the 0.6.8 update. The version in unstable and testing is currently
0.7.1.
Mattias
Vidarebefordrat meddelande
Från: Paul Millar
Till: mattias.ell...@physics.uu.se
Ämne: davix version in Debian stretch
Datum: Tue, 16 Oct 2018 15:06:11 +0200
Hi Mattias,
I was wondering whether it was possible to get the davix version
currently in buster (0.6.8) into stretch?
davix v0.6.8 contains this fix:
https://its.cern.ch/jira/browse/DMC-1047
which is pretty important for us.
Of course, if you got the latest version (v0.6.9) into stretch, buster
and sid, that would be even better. That version has further fixes that
would be helpful.
Cheers,
Paul.
diff -Nru davix-0.6.4/debian/changelog davix-0.6.4/debian/changelog
--- davix-0.6.4/debian/changelog 2016-12-15 21:40:12.0 +0100
+++ davix-0.6.4/debian/changelog 2018-11-03 18:37:23.0 +0100
@@ -1,3 +1,10 @@
+davix (0.6.4-1.1+deb9u1) stretch; urgency=medium
+
+ * Use getInterfaceVersion to retrieve the delegation version implemented
+ * https://its.cern.ch/jira/browse/DMC-1047
+
+ -- Mattias Ellert Sat, 03 Nov 2018 18:37:23 +0100
+
davix (0.6.4-1.1) unstable; urgency=medium
* Non-maintainer upload.
diff -Nru davix-0.6.4/debian/patches/0001-DMC-1047-use-getInterfaceVersion-to-retrieve-the-del.patch davix-0.6.4/debian/patches/0001-DMC-1047-use-getInterfaceVersion-to-retrieve-the-del.patch
--- davix-0.6.4/debian/patches/0001-DMC-1047-use-getInterfaceVersion-to-retrieve-the-del.patch 1970-01-01 01:00:00.0 +0100
+++ davix-0.6.4/debian/patches/0001-DMC-1047-use-getInterfaceVersion-to-retrieve-the-del.patch 2018-11-03 15:38:46.0 +0100
@@ -0,0 +1,33 @@
+From 436bb62eb7df614e3c68bdcbb60c56b406feb8f8 Mon Sep 17 00:00:00 2001
+From: Andrea Manzi
+Date: Mon, 28 May 2018 16:13:29 +0200
+Subject: [PATCH] DMC-1047: use getInterfaceVersion to retrieve the delegation
+ version implemented
+
+---
+ src/modules/copy/delegation/delegation.cpp | 6 +++---
+ 1 file changed, 3 insertions(+), 3 deletions(-)
+
+diff --git a/src/modules/copy/delegation/delegation.cpp b/src/modules/copy/delegation/delegation.cpp
+index 203268d..55f242b 100644
+--- a/src/modules/copy/delegation/delegation.cpp
b/src/modules/copy/delegation/delegation.cpp
+@@ -204,12 +204,12 @@ static int get_delegation_version(const std::string& ucred, const std::string& p
+
+ if (soap_ssl_client_context(soap_v, SOAP_SSL_DEFAULT, ucred.c_str(), passwd.c_str(),
+ ucred.c_str(), capath.c_str(), NULL) == 0) {
+-delegation2::tns2__getVersionResponse response;
+-delegation2::soap_call_tns2__getVersion(soap_v, dlg_endpoint.c_str(),
++delegation2::tns2__getInterfaceVersionResponse response;
++delegation2::soap_call_tns2__getInterfaceVersion(soap_v, dlg_endpoint.c_str(),
+ "http://www.gridsite.org/namespaces/delegation-2;, response);
+
+ if (soap_v->error == 0) {
+-version = atoi(response.getVersionReturn);
++version = atoi(response.getInterfaceVersionReturn);
+ }
+ else {
+ // Assume version 1 (does not implement the version method)
+--
+2.19.1
+
diff -Nru davix-0.6.4/debian/patches/series davix-0.6.4/debian/patches/series
--- davix-0.6.4/debian/patches/series 2016-12-15 21:36:45.0 +0100
+++ davix-0.6.4/debian/patches/series 2018-11-03 18:35:30.0 +0100
@@ -1,3 +1,10 @@
davix-linking.patch
+
+# Add support for openssl-1.1.0
+# https://its.cern.ch/jira/browse/DMC-888
0001-DMC-888-16-Add-support-for-openssl-1.1.0.patch
0002-DMC-888-16-Fix-SL5-build.patch
+
+# Use getInterfaceVersion to retrieve the delegation version implemented
+# https://its.cern.ch/jira/browse/DMC-1047
+0001-DMC-1047-use-getInterfaceVersion-to-retrieve-the-del.patch
diff -Nru davix-0.6.4/debian/rules davix-0.6.4/debian/rules
--- davix-0.6.4/debian/rules 2016-12-15 21:40:12.0 +0100
+++ davix-0.6.4/debian/rules 2018-11-03 18:37:23.0 +0100
@@ -32,6 +32,7 @@
override_dh_install:
rm debian/tmp/usr/share/doc/davix/LICENSE
rm -rf debian/tmp/usr/include/gtest debian/tmp/usr/lib/libgtest.a debian/tmp/usr/lib/libgtest_main.a
+ rm -rf debian/tmp/usr/share/doc/davix/html/.doctrees
dh_install --fail-missing
override_dh_strip:
signature.asc
Description: This is a digitally signed message part
