Re: [Pkg-utopia-maintainers] Bug#872977: libblockdev FTBFS on s390x: fatal error: s390utils/vtoc.h: No such file or directory

2017-08-23 Thread Aaron M. Ucko
Michael Biebl  writes:

> You mean aside from the actual #include? I'm not sure tbh.

Right; I strongly suspect it should be safe to remove the #include
directive from all three files, or at least s390.api and s390.h.

> The copy in parted seems to be an outdated version of s390-tools' vtoc.h.
>
> Wouldn't it be better if we had a single package providing that header
> which packages then can include?

Certainly, and I didn't mean to suggest otherwise.  My point was just
that I doubt libblockdev really needs *any* version of that header.

Thanks!

-- 
Aaron M. Ucko, KB1CJC (amu at alum.mit.edu, ucko at debian.org)
http://www.mit.edu/~amu/ | http://stuff.mit.edu/cgi/finger/?a...@monk.mit.edu



Re: [Pkg-utopia-maintainers] Bug#872977: libblockdev FTBFS on s390x: fatal error: s390utils/vtoc.h: No such file or directory

2017-08-23 Thread Michael Biebl
Hi Aaron

Am 23.08.2017 um 18:57 schrieb Aaron M. Ucko:
> Michael Biebl  writes:
> 
>> Afaics, this header is supposed to be provided by s390-tools/libvtoc
> 
> Is it actually needed here at all?  

You mean aside from the actual #include? I'm not sure tbh.

A quick look at the three files
> including it (lib/plugin_apis/s390.api and plugins/s390.[ch]) appears to
> indicate otherwise, though I haven't actually logged into a porterbox to
> test.  If a vtoc.h is needed, will parted's suffice?

The copy in parted seems to be an outdated version of s390-tools' vtoc.h.

Wouldn't it be better if we had a single package providing that header
which packages then can include?
-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?



signature.asc
Description: OpenPGP digital signature