Re: MRs on salsa and letting janitor automate things

2022-11-27 Thread Nilesh Patra
On Mon, Nov 28, 2022 at 05:45:02PM +1100, Stuart Prescott wrote: > On 28/11/2022 10:55, Dima Kogan wrote: > > Hi. I've been manually checking the merge requests, and have been > > accepting most of them. There is one thing the janitor does that I don't > > agree with, and I'd be against any

Re: MRs on salsa and letting janitor automate things

2022-11-27 Thread Stuart Prescott
Hi Dima On 28/11/2022 10:55, Dima Kogan wrote: Hi. I've been manually checking the merge requests, and have been accepting most of them. There is one thing the janitor does that I don't agree with, and I'd be against any automated merging of those patches. This is adding Build-Depends:

Re: MRs on salsa and letting janitor automate things

2022-11-27 Thread Nilesh Patra
On Sun, Nov 27, 2022 at 03:55:05PM -0800, Dima Kogan wrote: > Hi. I've been manually checking the merge requests, and have been > accepting most of them. There is one thing the janitor does that I don't > agree with, and I'd be against any automated merging of those patches. > This is adding

Re: MRs on salsa and letting janitor automate things

2022-11-27 Thread Dima Kogan
Hi. I've been manually checking the merge requests, and have been accepting most of them. There is one thing the janitor does that I don't agree with, and I'd be against any automated merging of those patches. This is adding Build-Depends: debhelper-compat (=WHATEVER). Such dependencies break

Re: MRs on salsa and letting janitor automate things

2022-11-27 Thread Stuart Prescott
Hi David On 27/11/2022 23:29, David Bremner wrote: Personally I often find it hard to prioritize understanding the MRs from the janitor, and I'm not comfortable with having a bot commit to a repo that I am responsible for. Perhaps I'm just old fashioned. I'm an uploader only for a tiny fraction

Re: MRs on salsa and letting janitor automate things

2022-11-27 Thread Stuart Prescott
On 27/11/2022 19:30, Julien Puydt wrote: Perhaps people didn't get notified they had MRs ? Entirely possible, hence the suggestions in my message were that we should: a) automate what can be automated so that attention is not needed b) check our individual salsa notification settings for

Re: MRs on salsa and letting janitor automate things

2022-11-27 Thread David Bremner
Stuart Prescott writes: > Hi folks > > tl;dr: there lots of untriaged MRs on salsa; let's permit Janitor to > automatically commit its updates > > > There are lots of MRs on salsa for science-team packages that are open. > Many of these have been open for months and many have no comments, >

Re: MRs on salsa and letting janitor automate things

2022-11-27 Thread PICCA Frederic-Emmanuel
Hello, I have the same concern than Anton. if it is easy to black list a bunch of package, it would be great. Most of my packages could benefit from this automatic commit, I am also ok with automatic upgrade of my packages if it works :)) Everything that let me use my time on real packaging

Re: MRs on salsa and letting janitor automate things

2022-11-27 Thread Anton Gladky
Hello Stuart, thanks for the information! I am personally OK with the idea of committing directly to the Science packages, not sure about the opinions of other team members. But if it improves the overall package quality - I am totally for this. Otherwise, I did not find an opportunity to

Re: MRs on salsa and letting janitor automate things

2022-11-27 Thread Julien Puydt
Hi, Le dim. 27 nov. 2022, 06:02, Stuart Prescott a écrit : > > tl;dr: there lots of untriaged MRs on salsa; let's permit Janitor to > automatically commit its updates Perhaps people didn't get notified they had MRs ? I know for a fact I found out and reacted about a MR months after the fact