OneTBB migration to testing stalled

[Nilesh Patra]

Hi Mo,

It seems that the migration of oneTBB to testing is stalled (since 16 days) due
to FTBFS on ppc64el with some linker errors[1]
I am not sure what is up there, could you please take a look?

[1]: 
https://buildd.debian.org/status/fetch.php?pkg=onetbb=ppc64el=2021.5.0-13=1662266636=0

-- 
Best,
Nilesh


signature.asc
Description: PGP signature

Re: ITA: glm -- C++ library for OpenGL GLSL type-based mathematics

[Andreas Tille]

Am Sat, Sep 03, 2022 at 09:47:27PM +0200 schrieb Anton Gladky:
> Hi Andrea,
> 
> thanks for taking care of this package! Really appreciate it.
> 
> Please, follow an advices given by Pierre and we will upload
> the package, giving you permissions to upload it in the future.
> 
> It could also be good if you add salsa-CI to be sure that the package

Short notes from vacations:  By using

   routine-update -f

you get salsa-CI for free inside the package.

> is building aod passing all tests. It is also an additional tests for you,
> 
> > I'm a DM, so I can't directly take ownership of the package nor push to
> > Salsa.

Please do not "take ownership" but add yourself to "Uploaders".  The
team should be the owner (=Maintainer).  Pushing to Salsa should be
easy once somebody adds you to the team.  Please also subscribe this
mailing list.

Kind regards

  Andreas.

> > Could somebody please look at my changes, give me write access
> > to the repo and possibly sponsor the first upload? You can find my
> > changes here:
> > 
> >
> > I've already asked this on IRC, and joostvb, while approving my changes
> > in general, said that it would've been better to ask this on the
> > mailing list.
> >
> > Thanks in advance :)
> >
> > --
> > OpenPGP key: 66DE F152 8299 0C21 99EF  A801 A8A1 28A8 AB1C EE49
> >
> >
> >

-- 
http://fam-tille.de

Re: ITA: glm -- C++ library for OpenGL GLSL type-based mathematics

[Pierre Gruet]

Hello again Andrea,

Le 03/09/2022 à 22:35, Andrea Pappacoda a écrit :

Thanks Pierre and Anton for your feedback!


You are very welcome! Thanks also for responding to the various points.


Il giorno sab 3 set 2022 alle 21:32:09 +02:00:00, Pierre Gruet 
[...]

- The long description of libglm-dev in debian/control is not
gender-neutral.


Gender-neutral language is not my area of expertise (in my native 
language even tables have a gender...), what should I change "when a 
programmer knows GLSL, he knows GLM as well" to? "they know GLM"?


Honestly it is also not something I am very familiar with. I can advise 
you to see Section 6.6.2.6 in the Debian Developers' Reference; yes, 
``they know GLM'' is what one shall use here.




Thanks again for your feedback! I submitted the pull request on the 
Salsa repo a while ago, and I didn't know much about packaging back 
then. I'm going to fix everything you reported (and possibly more) as 
soon as possible :)




Wonderful :) Please let us know when you are done.

Best regards,

--
Pierre


OpenPGP_signature
Description: OpenPGP digital signature

Re: ITA: glm -- C++ library for OpenGL GLSL type-based mathematics

[Andrea Pappacoda]

Thanks Pierre and Anton for your feedback!

Il giorno sab 3 set 2022 alle 21:32:09 +02:00:00, Pierre Gruet 
 ha scritto:
As I said above, the overall quality is very good. I have some 
comments

and remarks:
- You could raise the Standards version to the current one;
- The glmConfig.cmake and glmConfig-version.cmake should be patched, 
as
(given where you now install them) they are setting GLM_INCLUDE_DIRS 
to

be ``/usr/share'', while we want ``/usr/include'';


Didn't notice this, thanks for spotting the issue! I'd actually prefer 
to replace the current .cmake files with automatically generated ones, 
like done in the latest snapshot of the upstream repo, as they should 
be more complete/accurate.



- A follow-up notice in debian/tests/glm-tests: the tests refer to
``${glm_INCLUDE_DIRS}'' which is empty. ``${GLM_INCLUDE_DIRS}'' is 
more

appropriate.


I didn't even take a look at d/tests :/

I'll fix it too.


- You could solve the (only!) Lintian note, caught by
lintian -i -I ,
by calling iconv from debian/rules by overriding a relevant dh_ step;


Thanks, I'll look into this too.


- To stick to the Debian-science policy, you should set the Section of
the source package to ``science'' or ``math'';


Oh thanks, I didn't know there was a Debian-science policy - I'm 
reading it right now. I'll probably change the section to math, as GLM 
stands for OpenGL Mathematics


- There is no ``Files: debian/*'' stanza in debian/copyright, adding 
one

would be nice;


I'll add it soon.


- The long description of libglm-dev in debian/control is not
gender-neutral.


Gender-neutral language is not my area of expertise (in my native 
language even tables have a gender...), what should I change "when a 
programmer knows GLSL, he knows GLM as well" to? "they know GLM"?


Thanks again for your feedback! I submitted the pull request on the 
Salsa repo a while ago, and I didn't know much about packaging back 
then. I'm going to fix everything you reported (and possibly more) as 
soon as possible :)


--
OpenPGP key: 66DE F152 8299 0C21 99EF  A801 A8A1 28A8 AB1C EE49

Re: ITA: glm -- C++ library for OpenGL GLSL type-based mathematics

[Anton Gladky]

Hi Andrea,

thanks for taking care of this package! Really appreciate it.

Please, follow an advices given by Pierre and we will upload
the package, giving you permissions to upload it in the future.

It could also be good if you add salsa-CI to be sure that the package
is building aod passing all tests. It is also an additional tests for you,

Best regards

Anton


Am Fr., 2. Sept. 2022 um 22:13 Uhr schrieb Andrea Pappacoda <
and...@pappacoda.it>:

> Hi everyone!
>
> I've been wanting to adopt the glm package, maintained by the Science
> Team, since last September.
>
> I'm a DM, so I can't directly take ownership of the package nor push to
> Salsa. Could somebody please look at my changes, give me write access
> to the repo and possibly sponsor the first upload? You can find my
> changes here:
> 
>
> I've already asked this on IRC, and joostvb, while approving my changes
> in general, said that it would've been better to ask this on the
> mailing list.
>
> Thanks in advance :)
>
> --
> OpenPGP key: 66DE F152 8299 0C21 99EF  A801 A8A1 28A8 AB1C EE49
>
>
>

Re: ITA: glm -- C++ library for OpenGL GLSL type-based mathematics

[Pierre Gruet]

Hi Andrea, hi team,

First: I have reviewed the changes and I am globally satisfied with the 
packaging (some comments below), I would happily sponsor the upload with 
a few changes.


Could someone please give access to the repo to Andrea, and/or also 
allow me (pgt) to process such requests by raising my level to Owner?

Thanks a lot in any case.

Le 02/09/2022 à 22:06, Andrea Pappacoda a écrit :

Hi everyone!

I've been wanting to adopt the glm package, maintained by the Science 
Team, since last September.




It is great someone cares about this package, thanks!

I'm a DM, so I can't directly take ownership of the package nor push to 
Salsa. Could somebody please look at my changes, give me write access to 
the repo and possibly sponsor the first upload? You can find my changes 
here: 


I've already asked this on IRC, and joostvb, while approving my changes 
in general, said that it would've been better to ask this on the mailing 
list.


As I said above, the overall quality is very good. I have some comments 
and remarks:

- You could raise the Standards version to the current one;
- The glmConfig.cmake and glmConfig-version.cmake should be patched, as 
(given where you now install them) they are setting GLM_INCLUDE_DIRS to 
be ``/usr/share'', while we want ``/usr/include'';
- A follow-up notice in debian/tests/glm-tests: the tests refer to 
``${glm_INCLUDE_DIRS}'' which is empty. ``${GLM_INCLUDE_DIRS}'' is more 
appropriate.

- You could solve the (only!) Lintian note, caught by
lintian -i -I ,
by calling iconv from debian/rules by overriding a relevant dh_ step;
- To stick to the Debian-science policy, you should set the Section of 
the source package to ``science'' or ``math'';
- There is no ``Files: debian/*'' stanza in debian/copyright, adding one 
would be nice;
- The long description of libglm-dev in debian/control is not 
gender-neutral.





Thanks in advance :)



Thanks again for working on this package!

Best,

--
Pierre


OpenPGP_signature
Description: OpenPGP digital signature