Re: MRs on salsa and letting janitor automate things

2022-12-02 Thread Jochen Sprickerhof
Hi Dima, * Dima Kogan [2022-12-02 13:53]: The reason is that a package that has Build-Depends: debhelper-compat (=13) will fail to build on any older distro. I maintain some tools where I provide packages for a number of distros, and adding such a Build-Depends would mean I need to do extra

Re: MRs on salsa and letting janitor automate things

2022-12-02 Thread Dima Kogan
Hi. Andreas Tille writes: > IMHO its sensible to follow the latest toolset version sooner or > later. There are several sensible features and if your packages are > vanilla and simple there is no good reason to stick to any specific > debhelper compat version. The reason is that a package that

Re: MRs on salsa and letting janitor automate things

2022-12-01 Thread Andreas Tille
Hi Jelmer, Am Thu, Dec 01, 2022 at 04:04:13PM + schrieb Jelmer Vernooij: > One of the things you don't get when running these scripts manually rather > than > waiting or the janitor is that it verifies the package still builds, passes > autotests and generates binary diffs before

Re: MRs on salsa and letting janitor automate things

2022-12-01 Thread Jelmer Vernooij
(re-sending from my personal address, since I don't have debian.org set up correctly here) On Thu, Dec 01, 2022 at 04:35:02PM +0100, Andreas Tille wrote: > Hi again, > > Am Thu, Dec 01, 2022 at 01:55:43PM +0100 schrieb PICCA Frederic-Emmanuel: > > > As I tried to explain, routine-update does

Re: MRs on salsa and letting janitor automate things

2022-12-01 Thread Jelmer Vernooij
On Thu, Dec 01, 2022 at 04:35:02PM +0100, Andreas Tille wrote: > Hi again, > > Am Thu, Dec 01, 2022 at 01:55:43PM +0100 schrieb PICCA Frederic-Emmanuel: > > > As I tried to explain, routine-update does all what Janitor is doing > > > (please let me know if not than I'd include the actual Janitor

Re: MRs on salsa and letting janitor automate things

2022-12-01 Thread Andreas Tille
Hi again, Am Thu, Dec 01, 2022 at 01:55:43PM +0100 schrieb PICCA Frederic-Emmanuel: > > As I tried to explain, routine-update does all what Janitor is doing > > (please let me know if not than I'd include the actual Janitor code) > > plus other things Janitor can't do. I'm fine with whatever the

Re: MRs on salsa and letting janitor automate things

2022-12-01 Thread PICCA Frederic-Emmanuel
> As I tried to explain, routine-update does all what Janitor is doing > (please let me know if not than I'd include the actual Janitor code) > plus other things Janitor can't do. I'm fine with whatever the team > might prefer and I can cope with Janitor changes, but its not my > preference. It

Re: MRs on salsa and letting janitor automate things

2022-12-01 Thread Andreas Tille
Hi Stuart, Am Wed, Nov 30, 2022 at 10:58:06AM +1100 schrieb Stuart Prescott: > > While there is a substantial overlap in the feature sets, one is not a > subset of the other. > > - routine-update does some great things like normalising packaging. That's > something Janitor can't do because

Re: MRs on salsa and letting janitor automate things

2022-12-01 Thread Andreas Tille
Hi Dima, Am Tue, Nov 29, 2022 at 06:56:02PM -0800 schrieb Dima Kogan: > Hi Nilesh and Stuart. That email on debian-devel describes my use case > well. My packages are vanilla-enough that there's little value in doing > anything more than Build-Depends: debhelper (>=11) and sticking "11" in >

Re: MRs on salsa and letting janitor automate things

2022-11-29 Thread Dima Kogan
Hi Nilesh and Stuart. That email on debian-devel describes my use case well. My packages are vanilla-enough that there's little value in doing anything more than Build-Depends: debhelper (>=11) and sticking "11" in debian/compat or something like that. Let me know if this has some major downsides

Re: MRs on salsa and letting janitor automate things

2022-11-29 Thread Stuart Prescott
Hi Andreas I admit I share the old fashioned view and we asket Jelmer to not run Janitor on Debian Med and R-pkg-team. The rationale is that we are running routine-update on all our packages. Routine-update is running all scripts that are called by Janitor and thus you have the same

Re: MRs on salsa and letting janitor automate things

2022-11-29 Thread Andreas Tille
Moin, Am Tue, Nov 29, 2022 at 06:38:00PM +0100 schrieb Christian T. Steigies: > > I admit I share the old fashioned view and we asket Jelmer to not > > run Janitor on Debian Med and R-pkg-team. The rationale is that > > we are running > > > > routine-update > > This sounds cool, but I have

Re: MRs on salsa and letting janitor automate things

2022-11-29 Thread Christian T. Steigies
Moin, On Tue, Nov 29, 2022 at 10:58:19AM +0100, Andreas Tille wrote: > Hi, > > I admit I share the old fashioned view and we asket Jelmer to not > run Janitor on Debian Med and R-pkg-team. The rationale is that > we are running > > routine-update This sounds cool, but I have not heard of

Re: MRs on salsa and letting janitor automate things

2022-11-29 Thread Andreas Tille
Hi, Am Sun, Nov 27, 2022 at 08:29:58AM -0400 schrieb David Bremner: > > Personally I often find it hard to prioritize understanding the MRs from > the janitor, and I'm not comfortable with having a bot commit to a repo > that I am responsible for. Perhaps I'm just old fashioned. I'm an >

Re: MRs on salsa and letting janitor automate things

2022-11-29 Thread Andreas Tille
Am Mon, Nov 28, 2022 at 09:58:33AM + schrieb Jelmer Vernooij: > debhelper-c that > carries debhelper 13. If you're looking to avoid anything that's not available > in e.g. oldstable or ubuntu lts rather than specifically excluding > "debhelper-compat (= X)", the janitor also has a setting for

Re: MRs on salsa and letting janitor automate things

2022-11-28 Thread Gard Spreemann
Stuart Prescott writes: > On 27/11/2022 19:30, Julien Puydt wrote: >> Perhaps people didn't get notified they had MRs ? > > Entirely possible, hence the suggestions in my message were that we should: > > a) automate what can be automated so that attention is not needed > > b) check our

Re: MRs on salsa and letting janitor automate things

2022-11-28 Thread Stuart Prescott
On 28/11/2022 18:22, Nilesh Patra wrote: On Mon, Nov 28, 2022 at 05:45:02PM +1100, Stuart Prescott wrote: On 28/11/2022 10:55, Dima Kogan wrote: Hi. I've been manually checking the merge requests, and have been accepting most of them. There is one thing the janitor does that I don't agree

Re: MRs on salsa and letting janitor automate things

2022-11-28 Thread Jelmer Vernooij
On Mon, Nov 28, 2022 at 08:42:59AM +0530, Nilesh Patra wrote: > On Sun, Nov 27, 2022 at 03:55:05PM -0800, Dima Kogan wrote: > > Hi. I've been manually checking the merge requests, and have been > > accepting most of them. There is one thing the janitor does that I don't > > agree with, and I'd be

Re: MRs on salsa and letting janitor automate things

2022-11-27 Thread Nilesh Patra
On Mon, Nov 28, 2022 at 05:45:02PM +1100, Stuart Prescott wrote: > On 28/11/2022 10:55, Dima Kogan wrote: > > Hi. I've been manually checking the merge requests, and have been > > accepting most of them. There is one thing the janitor does that I don't > > agree with, and I'd be against any

Re: MRs on salsa and letting janitor automate things

2022-11-27 Thread Stuart Prescott
Hi Dima On 28/11/2022 10:55, Dima Kogan wrote: Hi. I've been manually checking the merge requests, and have been accepting most of them. There is one thing the janitor does that I don't agree with, and I'd be against any automated merging of those patches. This is adding Build-Depends:

Re: MRs on salsa and letting janitor automate things

2022-11-27 Thread Nilesh Patra
On Sun, Nov 27, 2022 at 03:55:05PM -0800, Dima Kogan wrote: > Hi. I've been manually checking the merge requests, and have been > accepting most of them. There is one thing the janitor does that I don't > agree with, and I'd be against any automated merging of those patches. > This is adding

Re: MRs on salsa and letting janitor automate things

2022-11-27 Thread Dima Kogan
Hi. I've been manually checking the merge requests, and have been accepting most of them. There is one thing the janitor does that I don't agree with, and I'd be against any automated merging of those patches. This is adding Build-Depends: debhelper-compat (=WHATEVER). Such dependencies break

Re: MRs on salsa and letting janitor automate things

2022-11-27 Thread Stuart Prescott
Hi David On 27/11/2022 23:29, David Bremner wrote: Personally I often find it hard to prioritize understanding the MRs from the janitor, and I'm not comfortable with having a bot commit to a repo that I am responsible for. Perhaps I'm just old fashioned. I'm an uploader only for a tiny fraction

Re: MRs on salsa and letting janitor automate things

2022-11-27 Thread Stuart Prescott
On 27/11/2022 19:30, Julien Puydt wrote: Perhaps people didn't get notified they had MRs ? Entirely possible, hence the suggestions in my message were that we should: a) automate what can be automated so that attention is not needed b) check our individual salsa notification settings for

Re: MRs on salsa and letting janitor automate things

2022-11-27 Thread David Bremner
Stuart Prescott writes: > Hi folks > > tl;dr: there lots of untriaged MRs on salsa; let's permit Janitor to > automatically commit its updates > > > There are lots of MRs on salsa for science-team packages that are open. > Many of these have been open for months and many have no comments, >

Re: MRs on salsa and letting janitor automate things

2022-11-27 Thread PICCA Frederic-Emmanuel
Hello, I have the same concern than Anton. if it is easy to black list a bunch of package, it would be great. Most of my packages could benefit from this automatic commit, I am also ok with automatic upgrade of my packages if it works :)) Everything that let me use my time on real packaging

Re: MRs on salsa and letting janitor automate things

2022-11-27 Thread Anton Gladky
Hello Stuart, thanks for the information! I am personally OK with the idea of committing directly to the Science packages, not sure about the opinions of other team members. But if it improves the overall package quality - I am totally for this. Otherwise, I did not find an opportunity to

Re: MRs on salsa and letting janitor automate things

2022-11-27 Thread Julien Puydt
Hi, Le dim. 27 nov. 2022, 06:02, Stuart Prescott a écrit : > > tl;dr: there lots of untriaged MRs on salsa; let's permit Janitor to > automatically commit its updates Perhaps people didn't get notified they had MRs ? I know for a fact I found out and reacted about a MR months after the fact

MRs on salsa and letting janitor automate things

2022-11-26 Thread Stuart Prescott
Hi folks tl;dr: there lots of untriaged MRs on salsa; let's permit Janitor to automatically commit its updates There are lots of MRs on salsa for science-team packages that are open. Many of these have been open for months and many have no comments, triage or feedback visible on salsa.