Re: Sponsoring before freeze

2021-02-08 Thread Thomas Schiex
Thanks Drew.

Following a quick exchange with Anton Gladky, it looked that the current
ctest tests (already executed at package compilation upon "make test")
are sufficient given that toulbar2 is not (debian distributed as) a library.

It may become so in the future however, and then we will look into dolfin.

Thomas


Le 08/02/2021 à 15:28, Drew Parsons a écrit :
>
> dolfin uses ctest with autopkgtest (test-dolfin-cpp)
>
> Likewise dolfinx (test-dolfinx-cpp) uses cmake to prepare tests (and
> demos), and launches them with "make test". But that test rule
> executes ctest.
>
> Drew 



Re: Sponsoring before freeze

2021-02-08 Thread Drew Parsons

On 2021-01-21 21:10, Anton Gladky wrote:

Hi Thomas,

there is one of examples [1].

...
[1] 
https://salsa.debian.org/science-team/vtk9/-/tree/master/debian/tests


Am Di., 19. Jan. 2021 um 23:02 Uhr schrieb Thomas Schiex

...


Also, if someone has an example of a package that uses autopkgtest in 
a

cmake with ctest context in mind,  this could help.



dolfin uses ctest with autopkgtest (test-dolfin-cpp)

Likewise dolfinx (test-dolfinx-cpp) uses cmake to prepare tests (and 
demos), and launches them with "make test". But that test rule executes 
ctest.


Drew



Re: Sponsoring before freeze

2021-01-21 Thread Anton Gladky
Hi Thomas,

there is one of examples [1].  But as far as I see, this package is
not a library.
It is not necessary to build it in autopkgtest.

The sense of autopkgtest is to test the package functionality. So you can
for example run some tests to check, whether they are working. Cmake builds
are relevant for libs to be sure that they are providing proper headers and
shared objects.

Regards

[1] https://salsa.debian.org/science-team/vtk9/-/tree/master/debian/tests

Anton

Am Di., 19. Jan. 2021 um 23:02 Uhr schrieb Thomas Schiex
:
>
> Dear Anton,
>
> I pushed the new upstream version of toulbar2.
>
> I'm now wondering what autopkgtest would be useful for. When you build
> the package, the dh_auto_test target does launch our ctest target. So
> the tests are run anyway for all builds. What does autopkgtest would
> bring then?
>
> Also, if someone has an example of a package that uses autopkgtest in a
> cmake with ctest context in mind,  this could help.
>
> Kind regards
>
> Thomas
>
> Le 18/01/2021 à 22:24, Anton Gladky a écrit :
> > Hi Thomas,
> >
> > uploaded! Thanks for your contribution.
> >
> > Please consider adding autopkgtest for the next upload. If you
> > prepare them before freeze, please let me know and I will upload it.
> >
> > Regards
> >
> > Anton



Re: Sponsoring before freeze

2021-01-19 Thread Thomas Schiex
Dear Anton,

I pushed the new upstream version of toulbar2.

I'm now wondering what autopkgtest would be useful for. When you build
the package, the dh_auto_test target does launch our ctest target. So
the tests are run anyway for all builds. What does autopkgtest would
bring then?

Also, if someone has an example of a package that uses autopkgtest in a
cmake with ctest context in mind,  this could help.

Kind regards

Thomas

Le 18/01/2021 à 22:24, Anton Gladky a écrit :
> Hi Thomas,
>
> uploaded! Thanks for your contribution.
>
> Please consider adding autopkgtest for the next upload. If you
> prepare them before freeze, please let me know and I will upload it.
>
> Regards
>
> Anton



Re: Sponsoring before freeze

2021-01-19 Thread Thomas Schiex
Dear Anton,

Thanks a lot for the final commits (just looked into them).

I will be looking into autopkgtest. I understand it provides something
similar to "travis/ci" which we use on our upstream repo.

There is a new upstream version of toulbar2 that popped up in the mean
time. I will try to allocate time to push it to salsa before the freeze.

Kind regards

Thomas

Le 18/01/2021 à 22:24, Anton Gladky a écrit :
> Hi Thomas,
>
> uploaded! Thanks for your contribution.
>
> Please consider adding autopkgtest for the next upload. If you
> prepare them before freeze, please let me know and I will upload it.
>
> Regards
>
> Anton



Re: Sponsoring before freeze

2021-01-18 Thread Anton Gladky
Hi Thomas,

uploaded! Thanks for your contribution.

Please consider adding autopkgtest for the next upload. If you
prepare them before freeze, please let me know and I will upload it.

Regards

Anton

Am Do., 14. Jan. 2021 um 00:39 Uhr schrieb Thomas Schiex
:
>
> Dear Anton,
>
> I have tried to prepare toulbar2 with a new upstream version. If something is 
> missing I'm happy to inject extra effort in it.
>
> Thomas



Sponsoring before freeze

2021-01-13 Thread Thomas Schiex
Dear Anton,

I have tried to prepare toulbar2 with a new upstream version. If something is 
missing I'm happy to inject extra effort in it.

Thomas