Dear Anton
Thanks very much for taking a look and giving helpful feedback.
On 05/11/2022 18:20, Anton Gladky wrote:
Hi Jeremy!
Looks good. Some notes:
- overriding lintian "veusz source: source-is-missing
[Documents/manual/html/searchindex.js]"
please drop it from the source and use dh --sphinxtools to symlink it.
Ok. I got rid of the file that way and removed the lintian override.
The package already uses --with=python3,sphinxdoc. Isn't that file
generated by sphinxdoc (in the rules) and is a project-specific
(non-linked) file indexing the text?
- d/rules:
override_dh_auto_build: export http_proxy=127.0.0.1:9
override_dh_auto_build: export https_proxy=127.0.0.1:9
override_dh_auto_build: delete_generated
dh_auto_build...
Looks weird. Is it really necessary to override auto_build several times?
I agree - it is weird. I was just following mindlessly what is here:
https://wiki.debian.org/SphinxDocumentation
To clean it up I removed the strange targets and set the environment
variables specifically for the sphinx build command.
Otherwise, please read "man dh" the section about "execute_after" and
"execute_before".
It can make your d/rules shorter.
Ok. I've replaced some of the rules with execute_after/execute_before as
appropriate, to reduce the length of the file.
When you are ready and the package needs to be sponsored - please let us know.
I think it's ready to be sponsored if that's possible.
Best wishes
Jeremy
Best regards
Anton
Am Sa., 5. Nov. 2022 um 13:09 Uhr schrieb Jeremy Sanders
:
Dear Science Team
It would be great if someone could have a look at the current version of
the Veusz packaging (for version 3.5.3) and review if it is ready to upload:
https://salsa.debian.org/science-team/veusz
The existing package currently fails to build under unstable and does
not run (see closed bug #1023185).
Thanks again
Jeremy
