Your message dated Tue, 20 Jan 2015 14:17:47 +0000
with message-id <87iog1k038....@port-kdr.hamilton.ie>
and subject line Fixed Upstream
has caused the Debian Bug report #752121,
regarding adolc: FTBFS with clang instead of gcc
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
752121: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=752121
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Source: adolc
Severity: minor
Tags: patch
User: pkg-llvm-t...@lists.alioth.debian.org
Usertags: clang-ftbfs

Hello,

Using the rebuild infrastructure, your package fails to build with clang 
(instead of gcc).

We detected this kinf of error:
http://clang.debian.net/status.php?version=3.4.2&key=NON-POD

Full build log is available here:
http://clang.debian.net/logs/2014-06-16/adolc_2.5.0-3_unstable_clang.log

Thanks,
Alexander


-- System Information:
Debian Release: jessie/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 3.13-1-amd64 (SMP w/1 CPU core)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
--- adolc-2.5.0/ADOL-C/src/sparse/sparsedrivers.cpp	2013-09-12 07:26:28.000000000 -0400
+++ adolc-2.5.0-my/ADOL-C/src/sparse/sparsedrivers.cpp	2014-06-19 17:02:33.677055948 -0400
@@ -1139,7 +1139,8 @@
     setMode(ADTL_INDO);
     {
 #ifdef __GNUC__
-	adouble x[n],y[m];
+	adouble *x = static_cast<adouble *>(alloca(sizeof(adouble) * n));
+	adouble *y = static_cast<adouble *>(alloca(sizeof(adouble) * m));
 #else
 	adouble *x, *y;
 	x = new adouble[n];
@@ -1202,7 +1203,8 @@
     setMode(ADTL_FOV);
     {
 #ifdef __GNUC__
-	adouble x[n],y[m];
+	adouble *x = static_cast<adouble *>(alloca(sizeof(adouble) * n));
+	adouble *y = static_cast<adouble *>(alloca(sizeof(adouble) * m));
 #else
 	adouble *x, *y;
 	x = new adouble[n];

--- End Message ---
--- Begin Message ---
Version: 2.5.1-1

Fixed upstream in 2.5.1, see below for details.

                                        --Barak.

$ git show upstream/2.5.1 -- ADOL-C/src/sparse/sparsedrivers.cpp | egrep -B2 
-A48 ADTL_IND

@@ -1138,13 +1138,9 @@ int ADOLC_get_sparse_jacobian( func_ad *const fun,
     //setNumDir(n);
     setMode(ADTL_INDO);
     {
-#ifdef __GNUC__
-       adouble x[n],y[m];
-#else
        adouble *x, *y;
        x = new adouble[n];
        y = new adouble[m];
-#endif
     for (i=0; i < n ; i++){
       x[i] = basepoints[i];
       //x[i].setADValue(i,1);
@@ -1159,10 +1155,8 @@ int ADOLC_get_sparse_jacobian( func_ad *const fun,
     }
 
     ret_val = ADOLC_get_sparse_pattern(y, m, sJinfos.JP );
-#ifndef __GNUC__
        delete[] x;
        delete[] y;
-#endif
     }
     sJinfos.depen = m;
     sJinfos.nnz_in = 0;
@@ -1201,13 +1195,10 @@ int ADOLC_get_sparse_jacobian( func_ad *const fun,
     setNumDir(sJinfos.seed_clms);
     setMode(ADTL_FOV);
     {
-#ifdef __GNUC__
-       adouble x[n],y[m];
-#else
        adouble *x, *y;
        x = new adouble[n];
        y = new adouble[m];
-#endif
+
     for (i=0; i < n ; i++){
       x[i] = basepoints[i];
       for (j=0; j < sJinfos.seed_clms; j++)
@@ -1219,10 +1210,9 @@ int ADOLC_get_sparse_jacobian( func_ad *const fun,
     for (i=0;i<m;i++)
        for (j=0; j< sJinfos.seed_clms;j++)
           sJinfos.B[i][j] = y[i].getADValue(j);
-#ifndef __GNUC__
+
        delete[] x;
        delete[] y;
-#endif
     }
        /* recover compressed Jacobian => ColPack library */

--- End Message ---
-- 
debian-science-maintainers mailing list
debian-science-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-science-maintainers

Reply via email to