Hi Kurt Kremitzki,
many thanks for the package!
As the package is huge, I think review will take some time and probably
some iterations. I will start on the review, but I hope that others
will chime in. (I will not have enough time for a complete review
today)
- d/README.Debian.html
I'm not
Control: tags -1 moreinfo
Hallo Kurt,
Sorry for the delay, I did not find time for a review up to
now...
- Please consider the feedback from Anton
- d/compat is 11, but you B-D only on debhelper > 9
- d/rules: --with quilt is not needed, also the B-D on quilt is not.
- c/changelog: The Entry
Hi,
just to avoid a dead-lock: you're still working on the package, nothing to
review atm?
Just let us know (and remove the moreinfo tag as sign) when ready for
the next round of review. (I'd like to avoid reviewing when not everything
has been implemented)
--
tobi
On Thu, Feb 22, 2018 at
Hi Kurt,
On Fri, Mar 09, 2018 at 01:13:54AM -0600, Kurt Kremitzki wrote:
> Control: tags -1 - moreinfo
>
> Alright, I've addressed all the points brought up by you two (thanks for the
> feedback so far!)
>
> I have done a thorough check of the licenses, updated d/copyright, and found
> a few
(Anton, there is a question below for you, that's why you are in To:))
On Fri, Mar 09, 2018 at 01:13:54AM -0600, Kurt Kremitzki wrote:
> Control: tags -1 - moreinfo
>
> Alright, I've addressed all the points brought up by you two (thanks for the
> feedback so far!)
>
> I have done a thorough
On Wed, Mar 14, 2018 at 11:46:28AM +0100, Tobias Frost wrote:
> What is still missing from my side is a complete d/copyright review,
> but I need a break right now... Will continue later.
Ok, went over the package for a copyright review.
One part of the result resulted in a MR [1], but n
On Tue, Mar 27, 2018 at 01:40:28AM -0500, Kurt Kremitzki wrote:
> Ok, I've concluded the next round of work on the package. I recreated the
> repo with `gbp import-dscs --debsnap`. I moved my d/watch and
> +Files-Excluded d/copyright file but ran into issues with missing files
> (e.g. src/Standard
On Sat, Mar 31, 2018 at 03:16:30PM -0500, Kurt Kremitzki wrote:
> Someone on the FreeCAD forum pointed out to me that there's a problem in
> 32-bit builds with d/occt-draw.install. I've pushed the correction to the
> repo--not sure what else is required to correct the package since it looks
> like
On Fri, Mar 30, 2018 at 02:48:22PM +0200, Tobias Frost wrote:
PS: I forgot one thing:
Please update the date in the changelog; (convenient is to use
'dch -r ""' for this, with the "")
--
tobi
> On Tue, Mar 27, 2018 at 01:40:28AM -0500, Kurt Kremitzki wrote:
> > Ok,
On Sat, Mar 31, 2018 at 05:05:37AM -0500, Kurt Kremitzki wrote:
>
>
> On 03/31/2018 03:23 AM, Tobias Frost wrote:
> > On Fri, Mar 30, 2018 at 02:48:22PM +0200, Tobias Frost wrote:
> >
> > PS: I forgot one thing:
> > Please update the date in the changelog;
On Fri, Mar 16, 2018 at 09:43:26AM -0500, Kurt Kremitzki wrote:
>
>
> On 03/15/2018 04:37 PM, Tobias Frost wrote:
> > On Wed, Mar 14, 2018 at 11:46:28AM +0100, Tobias Frost wrote:
> > > What is still missing from my side is a complete d/copyright review,
> >
11 matches
Mail list logo
