Re: [RFS] mseed2sac and sac2mseed: seismic data conversion tools
On Thu, Feb 08, 2018 at 02:17:35PM +0100, Paride Legovini wrote: > On 2018-01-29 11:56, Sébastien Villemot wrote: > > > > So I just created the repositories in science-team on salsa and added you > > as Developer for each project (since you are apparently not yet a member of > > the > > Science Team group). > > > > The URLs should be: > > > > Vcs-Browser: https://salsa.debian.org/science-team/mseed2sac > > Vcs-Git: https://salsa.debian.org/science-team/mseed2sac.git > > Thanks Sébastien, I pushed the updated packaging repositories there. > > I also set: > > Maintainer: Debian Science Maintainers > Uploaders: Paride Legovini > > (Perhaps the Debian Science Policy Manual should be updated with the new > mailing list address.) I don't think we have decided which email address to use for the Maintainer field in the future. So for the time being debian-science-maintainers@lists.alioth.d.o seems the preferred option, since it still works. > >>> - please also use standard git-buildpackage branch names, i.e. "upstream" > >>> for > >>> upstream sources and "master" for Debian packaging (this naming scheme > >>> is > >>> expected in the Debian Science Team). > > Done, now I hope for a final review and finally for sponsorship. I think that the override_dh_auto_install should be replaced by a debian/mseed2sac.install file, which is cleaner. It however looks like your package has already been uploaded, so I guess this should be fixed in a future upload. Best, -- ⢀⣴⠾⠻⢶⣦⠀ Sébastien Villemot ⣾⠁⢠⠒⠀⣿⡁ Debian Developer ⢿⡄⠘⠷⠚⠋⠀ http://sebastien.villemot.name ⠈⠳⣄ http://www.debian.org signature.asc Description: PGP signature
Re: [RFS] mseed2sac and sac2mseed: seismic data conversion tools
On 2018-01-29 11:56, Sébastien Villemot wrote: > > So I just created the repositories in science-team on salsa and added you > as Developer for each project (since you are apparently not yet a member of > the > Science Team group). > > The URLs should be: > > Vcs-Browser: https://salsa.debian.org/science-team/mseed2sac > Vcs-Git: https://salsa.debian.org/science-team/mseed2sac.git Thanks Sébastien, I pushed the updated packaging repositories there. I also set: Maintainer: Debian Science Maintainers Uploaders: Paride Legovini (Perhaps the Debian Science Policy Manual should be updated with the new mailing list address.) >>> - please also use standard git-buildpackage branch names, i.e. "upstream" >>> for >>> upstream sources and "master" for Debian packaging (this naming scheme is >>> expected in the Debian Science Team). Done, now I hope for a final review and finally for sponsorship. Regards, Paride
Re: [RFS] mseed2sac and sac2mseed: seismic data conversion tools
On Thu, Jan 25, 2018 at 06:05:54PM +0100, Paride Legovini wrote: > Hello Sébastien, > > Thanks for your careful review. > > On 2018-01-23 16:47, Sébastien Villemot wrote: > > I just looked at mseed2sac, but maybe the remarks below also apply to > > sac2mseed: > > Indeed most of them did apply also to sac2mseed. > > > - the Vcs-Git and Vcs-Browser fields in debian/control should point to the > > Debian packaging (on salsa.debian.org), not to the upstream sources > > Fixed, but of course at some point I would prefer to host the > repositories in the science-team group. Sure. So I just created the repositories in science-team on salsa and added you as Developer for each project (since you are apparently not yet a member of the Science Team group). The URLs should be: Vcs-Browser: https://salsa.debian.org/science-team/mseed2sac Vcs-Git: https://salsa.debian.org/science-team/mseed2sac.git Note that both mseed2sac and sac2mseed repositories are currently empty, so it's up to you to initialize them (possibly by changing branch names, see below). > > - please also use standard git-buildpackage branch names, i.e. "upstream" > > for > > upstream sources and "master" for Debian packaging (this naming scheme is > > expected in the Debian Science Team). > > Well, I chose this naming scheme (branch "master" tracks upstream, > branch "debian/sid" contains the Debian packaging) because it was what > the gbp documentation suggested, see: > > /usr/share/doc/git-buildpackage/manual-html/gbp.import.upstream-git.html I see. This is because git-buildpackage now recommends to follow DEP-14 conventions (see http://dep.debian.net/deps/dep14/), at least when importing upstream's git history. > Are you asking me to change the names of the branches just to keep the > structure of the debian-science packages uniform, or is there another > reason I'm missing? Indeed it's mainly because in Debian Science we use the master/upstream/pristine-tar scheme (and we therefore do not apply DEP-14). It's also because we do not incorporate upstream's git history in our repositories. We just track the tarballs. See: https://debian-science.alioth.debian.org/debian-science-policy.html#idm45916841498176 > I'm asking just to understand: I have no problem in > changing the names, but on the other side I'd like to stick with a > somehow uniform workflow for my Debian packages. Is there a general best > practice to follow when using git and upstream tagged releases? There are many different workflows used across Debian. The one used by the Science Team is fairly popular, but it is obviously not the only one. > > Otherwise your packaging looks good (though I can't promise that there are > > no > > other issues that may be discovered in a second round of review). > > Thanks. In debian-science do you rely on mentors for reviewing, or do > you review directly from the git repository? We don't use mentors. We review directly from the git repository. Sponsorship requests should be sent to the debian-science@ list, just as you did, and hopefully someone will reply. If nobody replies, you can then try the “Sponsoring of the Blends” way, see https://wiki.debian.org/DebianPureBlends/SoB. Best, -- ⢀⣴⠾⠻⢶⣦⠀ Sébastien Villemot ⣾⠁⢠⠒⠀⣿⡁ Debian Developer ⢿⡄⠘⠷⠚⠋⠀ http://sebastien.villemot.name ⠈⠳⣄ http://www.debian.org signature.asc Description: PGP signature
Re: [RFS] mseed2sac and sac2mseed: seismic data conversion tools
Hello Sébastien, Thanks for your careful review. On 2018-01-23 16:47, Sébastien Villemot wrote: > I just looked at mseed2sac, but maybe the remarks below also apply to > sac2mseed: Indeed most of them did apply also to sac2mseed. > - the Vcs-Git and Vcs-Browser fields in debian/control should point to the > Debian packaging (on salsa.debian.org), not to the upstream sources Fixed, but of course at some point I would prefer to host the repositories in the science-team group. > - it looks like you repackaged the original tarball by removing the libmseed/ > directory. This should be made clear in the Debian version by adding a > suffix > (typically "+ds", for "Debian source", so that the Debian version will be > "2.2+ds-1"). Done, I'm using 2.2+ds1-1, so I have a version number to bump if I have to modify the Debian source branch. > Then you also want to update debian/watch to take into account the +ds > suffix (with the "dversionmangle" option), and also debian/copyright (by > using the Files-Excluded field) to make repacking easy (see the manpage for > "uscan" for both points) Done. > - please add a "pristine-tar" branch, we rely on it in the Debian Science Team Done. > - please also use standard git-buildpackage branch names, i.e. "upstream" for > upstream sources and "master" for Debian packaging (this naming scheme is > expected in the Debian Science Team). Well, I chose this naming scheme (branch "master" tracks upstream, branch "debian/sid" contains the Debian packaging) because it was what the gbp documentation suggested, see: /usr/share/doc/git-buildpackage/manual-html/gbp.import.upstream-git.html Are you asking me to change the names of the branches just to keep the structure of the debian-science packages uniform, or is there another reason I'm missing? I'm asking just to understand: I have no problem in changing the names, but on the other side I'd like to stick with a somehow uniform workflow for my Debian packages. Is there a general best practice to follow when using git and upstream tagged releases? > - why do you add -O3 in debian/rules? Unless you have a good reason (like it > avoids a build failure), you are expected to use standard Debian build flags Done. > Otherwise your packaging looks good (though I can't promise that there are no > other issues that may be discovered in a second round of review). Thanks. In debian-science do you rely on mentors for reviewing, or do you review directly from the git repository? Cheers, Paride
Re: [RFS] mseed2sac and sac2mseed: seismic data conversion tools
Dear Paride, On Wed, Jan 17, 2018 at 11:57:05AM +0100, Paride Legovini wrote: > On 2018-01-12 14:13, Paride Legovini wrote: > > Dear debian-scientists, > > > > I packaged two small utilities to convert seismic data between the two > > most commonly used data formats. Both the tools use the recently > > packaged libmseed2 library (thanks Pierre). > > > > Here are the ITPs: > > > > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=886993 > > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=886995 > > > > and the uploads to mentors: > > > > https://mentors.debian.net/package/mseed2sac > > https://mentors.debian.net/package/sac2mseed > > I updated the packages. The repositories are linked in the ITPs, I'll > copy the links here for convenience: > > https://salsa.debian.org/paride-guest/mseed2sac > https://salsa.debian.org/paride-guest/sac2mseed > > Checkout the "debian/sid" branch. > > Still looking for reviews and sponsorship :) I just looked at mseed2sac, but maybe the remarks below also apply to sac2mseed: - the Vcs-Git and Vcs-Browser fields in debian/control should point to the Debian packaging (on salsa.debian.org), not to the upstream sources - it looks like you repackaged the original tarball by removing the libmseed/ directory. This should be made clear in the Debian version by adding a suffix (typically "+ds", for "Debian source", so that the Debian version will be "2.2+ds-1"). Then you also want to update debian/watch to take into account the +ds suffix (with the "dversionmangle" option), and also debian/copyright (by using the Files-Excluded field) to make repacking easy (see the manpage for "uscan" for both points) - please add a "pristine-tar" branch, we rely on it in the Debian Science Team (see the Debian Science Policy, https://debian-science.alioth.debian.org/debian-science-policy.html) - please also use standard git-buildpackage branch names, i.e. "upstream" for upstream sources and "master" for Debian packaging (this naming scheme is expected in the Debian Science Team). Actually, we usually do not track upstream's git, but rather rely on upstream tarballs. - why do you add -O3 in debian/rules? Unless you have a good reason (like it avoids a build failure), you are expected to use standard Debian build flags (currently the default optimization is -O2). Incidentally, your modification probably breaks non-optimized build (triggered with DEB_BUILD_OPTIONS=noopt), since -O3 will be enforced even in that case. Otherwise your packaging looks good (though I can't promise that there are no other issues that may be discovered in a second round of review). Best, -- ⢀⣴⠾⠻⢶⣦⠀ Sébastien Villemot ⣾⠁⢠⠒⠀⣿⡁ Debian Developer ⢿⡄⠘⠷⠚⠋⠀ http://sebastien.villemot.name ⠈⠳⣄ http://www.debian.org signature.asc Description: PGP signature
Re: [RFS] mseed2sac and sac2mseed: seismic data conversion tools
On 2018-01-12 14:13, Paride Legovini wrote: > Dear debian-scientists, > > I packaged two small utilities to convert seismic data between the two > most commonly used data formats. Both the tools use the recently > packaged libmseed2 library (thanks Pierre). > > Here are the ITPs: > > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=886993 > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=886995 > > and the uploads to mentors: > > https://mentors.debian.net/package/mseed2sac > https://mentors.debian.net/package/sac2mseed I updated the packages. The repositories are linked in the ITPs, I'll copy the links here for convenience: https://salsa.debian.org/paride-guest/mseed2sac https://salsa.debian.org/paride-guest/sac2mseed Checkout the "debian/sid" branch. Still looking for reviews and sponsorship :) Cheers, Paride signature.asc Description: OpenPGP digital signature
[RFS] mseed2sac and sac2mseed: seismic data conversion tools
Dear debian-scientists, I packaged two small utilities to convert seismic data between the two most commonly used data formats. Both the tools use the recently packaged libmseed2 library (thanks Pierre). Here are the ITPs: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=886993 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=886995 and the uploads to mentors: https://mentors.debian.net/package/mseed2sac https://mentors.debian.net/package/sac2mseed I'd like to maintain these two packages in the debian-science team and I'm looking for a sponsor. Thank you, Paride signature.asc Description: OpenPGP digital signature
