Re: Repository rights on zarr

2025-05-12 Thread Antonio Valentino

Il 12/05/25 22:26, Julian Gilbey ha scritto:

On Sun, May 04, 2025 at 06:16:59PM +0100, Julian Gilbey wrote:

Hi Antonio,

On Sun, May 04, 2025 at 04:38:57PM +0200, Antonio Valentino wrote:

Hi Julian,

[...]

you have maintainer role now on the repository
you should be able to push now

kind regards


Thanks, just pushed!

All being well, it will fix this bug.  If it does, I'll also submit it
upstream.


Turns out that it did fix this bug, or at least it appears to.  Longer
term, upstream are in the process of refactoring their code to cope
with endianness in a much more general way, so I won't submit this
patch.  Once upstream releases their new version with these changes,
this patch can be dropped.

See https://github.com/zarr-developers/zarr-python/pull/2874

Best wishes,

Julian


Thanks Julian


--
Antonio Valentino



Re: Repository rights on zarr

2025-05-12 Thread Julian Gilbey
On Sun, May 04, 2025 at 06:16:59PM +0100, Julian Gilbey wrote:
> Hi Antonio,
> 
> On Sun, May 04, 2025 at 04:38:57PM +0200, Antonio Valentino wrote:
> > Hi Julian,
> > 
> > [...]
> > 
> > you have maintainer role now on the repository
> > you should be able to push now
> > 
> > kind regards
> 
> Thanks, just pushed!
> 
> All being well, it will fix this bug.  If it does, I'll also submit it
> upstream.

Turns out that it did fix this bug, or at least it appears to.  Longer
term, upstream are in the process of refactoring their code to cope
with endianness in a much more general way, so I won't submit this
patch.  Once upstream releases their new version with these changes,
this patch can be dropped.

See https://github.com/zarr-developers/zarr-python/pull/2874

Best wishes,

   Julian



Re: Repository rights on zarr

2025-05-04 Thread Julian Gilbey
Hi Antonio,

On Sun, May 04, 2025 at 04:38:57PM +0200, Antonio Valentino wrote:
> Hi Julian,
> 
> [...]
> 
> you have maintainer role now on the repository
> you should be able to push now
> 
> kind regards

Thanks, just pushed!

All being well, it will fix this bug.  If it does, I'll also submit it
upstream.

Best wishes,

   Julian



Re: Repository rights on zarr

2025-05-04 Thread Antonio Valentino

Hi Julian,

Il 04/05/25 14:49, Julian Gilbey ha scritto:

Hi!

I'm in the science-team group on salsa, and just tried to push a
commit to zarr (g...@salsa.debian.org:science-team/zarr) to fix the RC
bug I raised earlier today, but my push is being rejected:

remote: GitLab: You are not allowed to push code to protected branches on this 
project.
To salsa.debian.org:science-team/zarr.git
  ! [remote rejected] master -> master (pre-receive hook declined)
error: failed to push some refs to 'salsa.debian.org:science-team/zarr.git'

I'm going to push the built package to fto-master anyway, but it would
obviously be good if I could also push my changes to salsa.  If anyone
could look at this for me, I'd appreciate it.  If you'd prefer me to
make an MR on salsa for my changes, that would be fine too.

Best wishes,

Julian



you have maintainer role now on the repository
you should be able to push now

kind regards
--
Antonio Valentino