Re: Tried to upgrade skimage to see whether #945389 is fixed but failed
Hi Ole, I had a quick look what you mean and tried to make the build more standard[1]. The build issues are remaining and need some work. Kind regards, Andreas. [1] https://salsa.debian.org/science-team/skimage/commit/d787835f7293dc105b9b8cf37d59c1f9fbf46110 On Mon, Dec 02, 2019 at 01:01:07PM +0100, Ole Streicher wrote: > Hi Andreas, > > I think that is the moment where the skimage build should be simplified > to the "official" build process: Python convention is that symbols > starting with an underscore are internal only (and ofcourse subject to > quick and unannounced changes). debian/bin/process_pyx.py however > depends on them (_build.py and f.e. the _changed() function). IMO this > should be taken out completely in favor of a standard, simplified build. > No idea however how difficult this is. > > Cheers > > Ole > > > I tried my luck with #945389 since two Debian Med packages are depending > > from skimage. So at first I tried to upgrade to the latest upstream > > version to possibly forward some reasonable bug report. Unfortunately > > the build starts very early: > > > > ... > > debian/rules build > > py3versions: no X-Python3-Version in control file, using supported versions > > /usr/bin/make -j 4 -f debian/rules _build > > make[1]: Entering directory '/build/skimage-0.16.2' > > py3versions: no X-Python3-Version in control file, using supported versions > > python3.7 debian/bin/process_pyx.py 4 > > Traceback (most recent call last): > > File "debian/bin/process_pyx.py", line 13, in > > from _build import _changed, process_tempita_pyx > > ImportError: cannot import name '_changed' from '_build' > > (/build/skimage-0.16.2/debian/bin/_build.py) > > make[1]: *** [debian/rules:71: debian/build-stamp-pyx] Error 1 > > ... > > -- http://fam-tille.de
Re: Tried to upgrade skimage to see whether #945389 is fixed but failed
Hi Ole, On Mon, Dec 02, 2019 at 01:01:07PM +0100, Ole Streicher wrote: > Hi Andreas, > > I think that is the moment where the skimage build should be simplified > to the "official" build process: Python convention is that symbols > starting with an underscore are internal only (and ofcourse subject to > quick and unannounced changes). debian/bin/process_pyx.py however > depends on them (_build.py and f.e. the _changed() function). IMO this > should be taken out completely in favor of a standard, simplified build. > No idea however how difficult this is. Me neither. Official Uploaders in CC to clarify the idea behind it. Stefan / Yaroslav could you comment on this? Could you please also declare your intention to work on this package in the future? If you realise that you do not manage to work on it please say so to make sure we try to find active Uploaders. Kind regards Andreas. > > > I tried my luck with #945389 since two Debian Med packages are depending > > from skimage. So at first I tried to upgrade to the latest upstream > > version to possibly forward some reasonable bug report. Unfortunately > > the build starts very early: > > > > ... > > debian/rules build > > py3versions: no X-Python3-Version in control file, using supported versions > > /usr/bin/make -j 4 -f debian/rules _build > > make[1]: Entering directory '/build/skimage-0.16.2' > > py3versions: no X-Python3-Version in control file, using supported versions > > python3.7 debian/bin/process_pyx.py 4 > > Traceback (most recent call last): > > File "debian/bin/process_pyx.py", line 13, in > > from _build import _changed, process_tempita_pyx > > ImportError: cannot import name '_changed' from '_build' > > (/build/skimage-0.16.2/debian/bin/_build.py) > > make[1]: *** [debian/rules:71: debian/build-stamp-pyx] Error 1 > > ... > > -- http://fam-tille.de
Re: Tried to upgrade skimage to see whether #945389 is fixed but failed
Hi Andreas, I think that is the moment where the skimage build should be simplified to the "official" build process: Python convention is that symbols starting with an underscore are internal only (and ofcourse subject to quick and unannounced changes). debian/bin/process_pyx.py however depends on them (_build.py and f.e. the _changed() function). IMO this should be taken out completely in favor of a standard, simplified build. No idea however how difficult this is. Cheers Ole > I tried my luck with #945389 since two Debian Med packages are depending > from skimage. So at first I tried to upgrade to the latest upstream > version to possibly forward some reasonable bug report. Unfortunately > the build starts very early: > > ... > debian/rules build > py3versions: no X-Python3-Version in control file, using supported versions > /usr/bin/make -j 4 -f debian/rules _build > make[1]: Entering directory '/build/skimage-0.16.2' > py3versions: no X-Python3-Version in control file, using supported versions > python3.7 debian/bin/process_pyx.py 4 > Traceback (most recent call last): > File "debian/bin/process_pyx.py", line 13, in > from _build import _changed, process_tempita_pyx > ImportError: cannot import name '_changed' from '_build' > (/build/skimage-0.16.2/debian/bin/_build.py) > make[1]: *** [debian/rules:71: debian/build-stamp-pyx] Error 1 > ...
