Re: Segyio is lagging behind upstream (Was: segyio ftbfs with Python 3.12)
Hi Tino, thanks for the hint which reduced the number of test suite failures to one as you can see in Salsa CI[1]. In case someone might find a solution for this one we might upload - if not I wonder whether this package is a candidate for removal. Please note: I have no interest into this package at all - just hunting for Python3.12 issues. Kind regards Andreas. [1]https://salsa.debian.org/science-team/segyio/-/jobs/5338110 Am Wed, Feb 21, 2024 at 11:42:58AM +0100 schrieb Tino Didriksen: > std::uint16_t is in #include > > stdint.h is the C header, which doesn't import the symbols to the std:: > namespace. In general, the headers Standard C++ imports from Standard C > snips the .h and prefixes c, so stdint.h -> cstdint, stdio.h -> cstdio, etc. > > -- Tino Didriksen > > > On Wed, 21 Feb 2024 at 11:16, Andreas Tille wrote: > > > Hi, > > > > I've found in the set of patches for segyio other cherry-picked patches > > to adapt to certain Python3.x versions[1]. The patch kindly suggested > > by s3v to fix this bug[2] would simply be another cherry-pick from upstream > > who has meanwhile released a couple of new versions incorporating all > > patches we seem to need for Python3.12 - thus by upgrading to latest > > upstream the current bug would be fixed. > > > > Usually I would do this in case of team maintained packages but I faced > > some problems with latest upstream and thus I simply created a branch > > version_1.9.12 with all proposed changes including current packaging > > standards and fixing a further bug. Unfortunately the build system is > > all but smooth compared to other packages and I finally stumbled upon > > a C++ conversion issue[4] which is not solved by simply adding > >#include > > and my further attempt leads to a test suite issue which seems to > > indicate that my poor C++ understanding is wrong. > > > > So I'm giving up here by leaving two questions: > > > >1. Anybody up for fixing this package and bringing it to latest > > upstream? > >2. Alternatively do we want to drop this package from Debian? > > > > Kind regards > > Andreas. > > > > > > [1] > > https://salsa.debian.org/science-team/segyio/-/tree/master/debian/patches?ref_type=heads > > [2] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1055728#14 > > [3] > > https://salsa.debian.org/science-team/segyio/-/tree/version_1.9.12?ref_type=heads > > [4] > > https://salsa.debian.org/science-team/segyio/-/blob/version_1.9.12/debian/patches/gcc-13.patch?ref_type=heads#L6-9 > > > > -- > > http://fam-tille.de > > > > -- http://fam-tille.de
Re: Segyio is lagging behind upstream (Was: segyio ftbfs with Python 3.12)
std::uint16_t is in #include stdint.h is the C header, which doesn't import the symbols to the std:: namespace. In general, the headers Standard C++ imports from Standard C snips the .h and prefixes c, so stdint.h -> cstdint, stdio.h -> cstdio, etc. -- Tino Didriksen On Wed, 21 Feb 2024 at 11:16, Andreas Tille wrote: > Hi, > > I've found in the set of patches for segyio other cherry-picked patches > to adapt to certain Python3.x versions[1]. The patch kindly suggested > by s3v to fix this bug[2] would simply be another cherry-pick from upstream > who has meanwhile released a couple of new versions incorporating all > patches we seem to need for Python3.12 - thus by upgrading to latest > upstream the current bug would be fixed. > > Usually I would do this in case of team maintained packages but I faced > some problems with latest upstream and thus I simply created a branch > version_1.9.12 with all proposed changes including current packaging > standards and fixing a further bug. Unfortunately the build system is > all but smooth compared to other packages and I finally stumbled upon > a C++ conversion issue[4] which is not solved by simply adding >#include > and my further attempt leads to a test suite issue which seems to > indicate that my poor C++ understanding is wrong. > > So I'm giving up here by leaving two questions: > >1. Anybody up for fixing this package and bringing it to latest > upstream? >2. Alternatively do we want to drop this package from Debian? > > Kind regards > Andreas. > > > [1] > https://salsa.debian.org/science-team/segyio/-/tree/master/debian/patches?ref_type=heads > [2] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1055728#14 > [3] > https://salsa.debian.org/science-team/segyio/-/tree/version_1.9.12?ref_type=heads > [4] > https://salsa.debian.org/science-team/segyio/-/blob/version_1.9.12/debian/patches/gcc-13.patch?ref_type=heads#L6-9 > > -- > http://fam-tille.de > >
Segyio is lagging behind upstream (Was: segyio ftbfs with Python 3.12)
Hi, I've found in the set of patches for segyio other cherry-picked patches to adapt to certain Python3.x versions[1]. The patch kindly suggested by s3v to fix this bug[2] would simply be another cherry-pick from upstream who has meanwhile released a couple of new versions incorporating all patches we seem to need for Python3.12 - thus by upgrading to latest upstream the current bug would be fixed. Usually I would do this in case of team maintained packages but I faced some problems with latest upstream and thus I simply created a branch version_1.9.12 with all proposed changes including current packaging standards and fixing a further bug. Unfortunately the build system is all but smooth compared to other packages and I finally stumbled upon a C++ conversion issue[4] which is not solved by simply adding #include and my further attempt leads to a test suite issue which seems to indicate that my poor C++ understanding is wrong. So I'm giving up here by leaving two questions: 1. Anybody up for fixing this package and bringing it to latest upstream? 2. Alternatively do we want to drop this package from Debian? Kind regards Andreas. [1] https://salsa.debian.org/science-team/segyio/-/tree/master/debian/patches?ref_type=heads [2] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1055728#14 [3] https://salsa.debian.org/science-team/segyio/-/tree/version_1.9.12?ref_type=heads [4] https://salsa.debian.org/science-team/segyio/-/blob/version_1.9.12/debian/patches/gcc-13.patch?ref_type=heads#L6-9 -- http://fam-tille.de
