Bug#694077: Package review

2019-08-26 Thread Jérôme Lebleu
Hi Lisandro, Le 25/08/2019 à 17:33, Lisandro Damián Nicanor Pérez Meyer a écrit : > On Sun, 25 Aug 2019 at 12:26, Lisandro Damián Nicanor Pérez Meyer > wrote: > [snip] >> >> Mmm, I'm not entirely sure if the code in plugins/hid is >> DFSG-compliant. It's license it's too lax. I think I'll upload

Bug#694077: Package review

2019-08-25 Thread Lisandro Damián Nicanor Pérez Meyer
If you go for the patch approach add a Comment field in the copyright file, so reviewers know what to expect-. On Sun, 25 Aug 2019 at 12:33, Lisandro Damián Nicanor Pérez Meyer wrote: > > On Sun, 25 Aug 2019 at 12:26, Lisandro Damián Nicanor Pérez Meyer > wrote: > [snip] > > > > Mmm, I'm not

Bug#694077: Package review

2019-08-25 Thread Lisandro Damián Nicanor Pérez Meyer
On Sun, 25 Aug 2019 at 12:26, Lisandro Damián Nicanor Pérez Meyer wrote: [snip] > > Mmm, I'm not entirely sure if the code in plugins/hid is > DFSG-compliant. It's license it's too lax. I think I'll upload it non > the less in the meantime, and see what FTP masters think. Better yet, I looked

Bug#694077: Package review

2019-08-25 Thread Lisandro Damián Nicanor Pérez Meyer
Hi! On Sun, 25 Aug 2019 at 06:22, Jérôme Lebleu wrote: > > Le 24/08/2019 à 22:26, Lisandro Damián Nicanor Pérez Meyer a écrit : > > please release it (dch -r), push it and I'll upload. > > It is now done and pushed, thanks in advance! > > I tried again to build the package and didn't have any

Bug#694077: Package review

2019-08-25 Thread Jérôme Lebleu
Le 24/08/2019 à 22:26, Lisandro Damián Nicanor Pérez Meyer a écrit : > please release it (dch -r), push it and I'll upload. It is now done and pushed, thanks in advance! I tried again to build the package and didn't have any failure this time. The one that didn't pass was at this line:

Bug#694077: Package review

2019-08-24 Thread Lisandro Damián Nicanor Pérez Meyer
please release it (dch -r), push it and I'll upload. On Tue, 20 Aug 2019 at 09:07, Lisandro Damián Nicanor Pérez Meyer wrote: > > Hi! > > El mar., 20 ago. 2019 05:35, Jérôme Lebleu escribió: >> >> Hi Lisandro, >> >> I am happy to read from you! >> >> Le 19/08/2019 à 21:42, Lisandro Damián

Bug#694077: Package review

2019-08-20 Thread Lisandro Damián Nicanor Pérez Meyer
Hi! El mar., 20 ago. 2019 05:35, Jérôme Lebleu escribió: > Hi Lisandro, > > I am happy to read from you! > > Le 19/08/2019 à 21:42, Lisandro Damián Nicanor Pérez Meyer a écrit : > > I'm afraid it's failing to build from source: > > > > x86_64-linux-gnu/qt5 -isystem >

Bug#694077: Package review

2019-08-20 Thread Jérôme Lebleu
Hi Lisandro, I am happy to read from you! Le 19/08/2019 à 21:42, Lisandro Damián Nicanor Pérez Meyer a écrit : > I'm afraid it's failing to build from source: > > x86_64-linux-gnu/qt5 -isystem /usr/include/x86_64-linux-gnu/qt5/QtMultimedia > -isystem /usr/include/x86_64-linux-gnu/qt5/QtGui

Bug#694077: Package review

2019-08-19 Thread Lisandro Damián Nicanor Pérez Meyer
I'm afraid it's failing to build from source: x86_64-linux-gnu/qt5 -isystem /usr/include/x86_64-linux-gnu/qt5/QtMultimedia -isystem /usr/include/x86_64-linux-gnu/qt5/QtGui -isystem /usr/include/x86_64-linux-gnu/qt5/QtNetwork -isystem /usr/include/x86_64-linux-gnu/qt5/QtScript -isystem

Bug#694077: Package review

2019-08-19 Thread Lisandro Damián Nicanor Pérez Meyer
On 19/08/13 11:06, Jérôme Lebleu wrote: > Hi Lisandro, > > Thanks a lot for your review and all your advice! It gives me more > motivation to follow through this package. Great! I've looked into the changes and really liked what I saw :-) > On Sat, 3 Aug 2019 23:27:28 -0300 Lisandro Damián

Bug#694077: Package review

2019-08-13 Thread Jérôme Lebleu
Hi Lisandro, Thanks a lot for your review and all your advice! It gives me more motivation to follow through this package. On Sat, 3 Aug 2019 23:27:28 -0300 Lisandro Damián Nicanor Pérez Meyer wrote: > = debian/changelog > > As it's the first upload the only line really needed is: > > *

Bug#694077: Package review

2019-08-03 Thread Lisandro Damián Nicanor Pérez Meyer
On Sat, 3 Aug 2019 at 23:30, Lisandro Damián Nicanor Pérez Meyer wrote: > > = debian/changelog > > As it's the first upload the only line really needed is: > > * Initial release (Closes: #694077) > > = debian/patches > > Why are you disabling patches? The patch description is not clear > about

Bug#694077: Package review

2019-08-03 Thread Lisandro Damián Nicanor Pérez Meyer
= debian/changelog As it's the first upload the only line really needed is: * Initial release (Closes: #694077) = debian/patches Why are you disabling patches? The patch description is not clear about it. I had to read debian/rules to know why :-) Try this: override_dh_auto_test-arch: