Bug#870836: imake generated makefile use deprecated -D_BSD_SOURCE and -D_SVID_SOURCE

[Steve McIntyre]

On Sat, Nov 24, 2018 at 02:02:58PM -0800, Bart Massey wrote:
>Hilariously, I just ran into this today when building a program I wrote in
>1987. Thanks huge to Teemu for working out the patch; I have verified that it
>works for me. It would be great if this could be packaged.

Still seeing this over 5 years later. Is there any reason not to do an
upload with the patch here?

-- 
Steve McIntyre, Cambridge, UK.st...@einval.com
You raise the blade, you make the change... You re-arrange me 'til I'm sane...

Bug#870836: imake generated makefile use deprecated -D_BSD_SOURCE and -D_SVID_SOURCE

[Bart Massey]

Hilariously, I just ran into this today when building a program I wrote in
1987. Thanks huge to Teemu for working out the patch; I have verified that
it works for me. It would be great if this could be packaged.

Bug#870836: imake generated makefile use deprecated -D_BSD_SOURCE and -D_SVID_SOURCE

[Teemu Ikonen]

Hi,

The attached patch against the xutils-dev git repo at salsa fixes
this for me. Note that there are also other definitions of
-D_BSD_SOURCE and -D_SVID_SOURCE in the sources, but they
probably do not affect Debian.

Best,
TeemuFrom eb20e1365cb9d564ad9d06736a33105f1fd12846 Mon Sep 17 00:00:00 2001
From: Teemu Ikonen 
Date: Tue, 23 Oct 2018 15:29:38 +0300
Subject: [PATCH] New patch: 09_default_source.diff

Change -D_BSD_SOURCE and -D_SVID_SOURCE to -D_DEFAULT_SOURCE

Closes: #870836
---
 debian/patches/09_default_source.diff | 26 ++
 debian/patches/series |  1 +
 2 files changed, 27 insertions(+)
 create mode 100644 debian/patches/09_default_source.diff

diff --git a/debian/patches/09_default_source.diff b/debian/patches/09_default_source.diff
new file mode 100644
index 000..5e71e5f
--- /dev/null
+++ b/debian/patches/09_default_source.diff
@@ -0,0 +1,26 @@
+Index: git-xutils-dev/xorg-cf-files/gnu.cf
+===
+--- git-xutils-dev.orig/xorg-cf-files/gnu.cf
 git-xutils-dev/xorg-cf-files/gnu.cf
+@@ -245,7 +245,7 @@ InstallNamedTargetNoClobber(install,file
+ 
+ # define GnuSourceDefines	-D_POSIX_C_SOURCE=199309L \
+ -D_POSIX_SOURCE -D_XOPEN_SOURCE \
+--D_BSD_SOURCE -D_SVID_SOURCE \
++-D_DEFAULT_SOURCE \
+ GnuAdditionalIncludes GnuGnuSourceDefines \
+ GnuLocaleDefines
+ # define XawI18nDefines		-DHAS_WCHAR_H -DHAS_WCTYPE_H -DNO_WIDEC_H
+Index: git-xutils-dev/xorg-cf-files/linux.cf
+===
+--- git-xutils-dev.orig/xorg-cf-files/linux.cf
 git-xutils-dev/xorg-cf-files/linux.cf
+@@ -350,7 +350,7 @@ InstallNamedTargetNoClobber(install,file
+ #if LinuxCLibMajorVersion >= 6
+ # define LinuxSourceDefines	-D_POSIX_C_SOURCE=199309L \
+ -D_POSIX_SOURCE -D_XOPEN_SOURCE \
+--D_BSD_SOURCE -D_SVID_SOURCE \
++-D_DEFAULT_SOURCE \
+ -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 \
+ LinuxAdditionalIncludes LinuxGnuSourceDefines \
+ LinuxLocaleDefines
diff --git a/debian/patches/series b/debian/patches/series
index c91cb22..bb9f5c2 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -4,3 +4,4 @@
 06_font_path.diff
 07_gnu_manpath.diff
 08_xorg_with_xmlto.diff
+09_default_source.diff
-- 
2.11.0