[jira] Commented: (DERBY-578) Grouped select from temporary table raises null pointer exception in byte code generator

2006-06-30 Thread Kathey Marsden (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-578?page=comments#action_12418683 ] Kathey Marsden commented on DERBY-578: -- If there are no comments on the merge and comments I added I will run derbyall and commit this on Monday and put this poor patch (p

Re: [jira] Commented: (DERBY-578) Grouped select from temporary table raises null pointer exception in byte code generator

2006-06-20 Thread Rick Hillegas
Thanks, Manish. I can add the new canon myself. I just want to make sure that you've seen and understood this diff and don't regard it as a regression. Regards, -Rick Manish Khettry wrote: Yes for some reason there is a missing newline in the patch I submitted :( Do you want to edit the su

Re: [jira] Commented: (DERBY-578) Grouped select from temporary table raises null pointer exception in byte code generator

2006-06-20 Thread Manish Khettry
Yes for some reason there is a missing newline in the patch I submitted :( Do you want to edit the subquery.out file yourself or should I attach another patch? Do you want the entire patch or just subquery.diff? On 6/20/06, Rick Hillegas (JIRA) wrote: [ http://issues.a

[jira] Commented: (DERBY-578) Grouped select from temporary table raises null pointer exception in byte code generator

2006-06-20 Thread Rick Hillegas (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-578?page=comments#action_12416915 ] Rick Hillegas commented on DERBY-578: - Thanks for the explanation, Manish. I ran derbyall and came up with one unexpected diff in lang/subquery.sql. It's some extra cruft o

[jira] Commented: (DERBY-578) Grouped select from temporary table raises null pointer exception in byte code generator

2006-06-19 Thread Manish Khettry (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-578?page=comments#action_12416814 ] Manish Khettry commented on DERBY-578: -- Thanks for taking time to review the fix. The xaHelper is not related to this but when I was debugging using ij, this bit of code w

[jira] Commented: (DERBY-578) Grouped select from temporary table raises null pointer exception in byte code generator

2006-06-19 Thread Rick Hillegas (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-578?page=comments#action_12416803 ] Rick Hillegas commented on DERBY-578: - Thanks, Manish. As you said, the fix looks pretty simple. I'm running regression tests now. I have a couple questions: 1) I don't un

Re: [jira] Commented: (DERBY-578) Grouped select from temporary table raises null pointer exception in byte code generator

2006-06-16 Thread Manish Khettry
Since only predicatePushdown failed, I generated a context diff for this one file. I already have a bunch of other uncommitted changes in my view, so I'm not sure how I can generate one patch file without pulling in a lot of other stuff. The following sequence of steps should work. 1. Apply the c

[jira] Commented: (DERBY-578) Grouped select from temporary table raises null pointer exception in byte code generator

2006-06-16 Thread Rick Hillegas (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-578?page=comments#action_12416588 ] Rick Hillegas commented on DERBY-578: - Hi Manish, I'm confused about what I'm supposed to do with the latest attachment. It looks like it might just be the changes to pred

[jira] Commented: (DERBY-578) Grouped select from temporary table raises null pointer exception in byte code generator

2006-06-15 Thread Rick Hillegas (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-578?page=comments#action_12416403 ] Rick Hillegas commented on DERBY-578: - Hi Manish, I would like to take a look at this patch, but I get the following errors when I try to apply it to my workspace. Could y